Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036183 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-06-06 12:18 | 2017-07-24 12:12 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | platform | |||||||
| Priority | low | Resolution | no change required | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036183: Platform: EntityPersistenceEventObserver validations has a high log level | |||||||
| Description | Entity validations created extending EntityPersistenceEventObserver, when the validation fails an exception is thrown, and it is registered in the openbravo log file. These kind of exceptions are functional validations and should not be registered in the openbravo log with a high level | |||||||
| Steps To Reproduce | For example to make fail the validation implemented in org.openbravo.retail.posterminal.event.ProductEventHandler, try to create a product with type "Service" and checked "Show stock". The validation appears and the record cannot be saved. Observe the openbravo log a exception is registered. | |||||||
| Proposed Solution | The infrastructure does not log anything by default. The problem is some of these observers are throwing OBException, which by default log stack traces. Candidates to check: $ find -name *.java | xargs grep "extends.*EntityPersistenceEventObserver" -l | xargs grep OBException -l | sort == Functional == ./modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java ./modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AcctSchemaEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java ./src/org/openbravo/event/ConversionRateEventHandler.java ./src/org/openbravo/event/DocTypeEventHandler.java ./src/org/openbravo/event/GLJournalLineEventHandler.java ./src/org/openbravo/event/InvoiceTaxEventHandler.java ./src/org/openbravo/event/MInOutLineEventHandler.java ./src/org/openbravo/event/OrderDiscountEventHandler.java ./src/org/openbravo/event/PeriodEventHandler.java ./src/org/openbravo/event/ProductAumEventHandler.java ./src/org/openbravo/event/ProductCharacteristicEventHandler.java ./src/org/openbravo/event/ProductEventHandler.java ./src/org/openbravo/event/ProductionLineEventHandler.java ./src/org/openbravo/event/ServiceOrderLineEventHandler.java ./src/org/openbravo/event/ServicePriceRuleRangeEventHandler.java ./src/org/openbravo/event/SimpleGLJournalEventHandler.java ./src/org/openbravo/event/UOMConversionEventHandler.java == Platform == ./modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/FieldHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RoleAccessUniqueHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TableEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TableTreeEventHandler.java ./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/WindowPersonalizationEventHandler.java ./src/org/openbravo/event/ADTableEventHandler.java ./src/org/openbravo/event/ProcessRequestEventHandler.java == Retail == ./modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java ./modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/ServerStateBackgroundEventHandler.java ./modules/org.openbravo.retail.discounts/src/org/openbravo/retail/discounts/event/MOfferEventHandler.java ./modules/org.openbravo.retail.discounts/src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/ADOrgWarehouseEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/AppPaymentEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/PaymentMethodEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/ProductEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/TerminalTypePaymentMethodEventHandler.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java ./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/PaymentMethodHandler.java | |||||||
| Tags | SER-QA | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0097204) alostale (manager) 2017-06-08 11:03 |
Downgraded severity according to reporting guidelines [1]. [1] http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^] |
|
(0098198) alostale (manager) 2017-07-24 12:12 |
After OBException behavior change (0036527) all cases have been reviewed and none of them make sense to be logged. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-06-06 12:18 | adrianromero | New Issue | |
| 2017-06-06 12:18 | adrianromero | Assigned To | => platform |
| 2017-06-06 12:18 | adrianromero | Modules | => Core |
| 2017-06-06 12:18 | adrianromero | Resolution time | => 1497909600 |
| 2017-06-06 12:18 | adrianromero | Triggers an Emergency Pack | => No |
| 2017-06-06 12:19 | adrianromero | Tag Attached: SER-QA | |
| 2017-06-08 11:03 | alostale | Relationship added | blocks 0036162 |
| 2017-06-08 11:03 | alostale | Note Added: 0097204 | |
| 2017-06-08 11:03 | alostale | Priority | normal => low |
| 2017-06-08 11:03 | alostale | Severity | major => minor |
| 2017-06-08 11:03 | alostale | Status | new => acknowledged |
| 2017-06-08 11:03 | alostale | Resolution time | 1497909600 => |
| 2017-06-08 13:35 | alostale | Note Added: 0097216 | |
| 2017-06-08 14:27 | alostale | Proposed Solution updated | |
| 2017-06-08 14:27 | alostale | Note Deleted: 0097216 | |
| 2017-06-08 14:28 | alostale | Issue cloned | 0036207 |
| 2017-06-08 14:28 | alostale | Relationship added | related to 0036207 |
| 2017-06-08 14:30 | alostale | Issue cloned | 0036208 |
| 2017-06-08 14:30 | alostale | Relationship added | related to 0036208 |
| 2017-06-08 14:34 | alostale | Summary | EntityPersistenceEventObserver validations has a high log level => Platform: EntityPersistenceEventObserver validations has a high log level |
| 2017-06-08 14:34 | alostale | Proposed Solution updated | |
| 2017-07-24 12:06 | alostale | Relationship added | related to 0036527 |
| 2017-07-24 12:11 | alostale | Status | acknowledged => scheduled |
| 2017-07-24 12:12 | alostale | Status | scheduled => feedback |
| 2017-07-24 12:12 | alostale | Review Assigned To | => alostale |
| 2017-07-24 12:12 | alostale | Note Added: 0098198 | |
| 2017-07-24 12:12 | alostale | Status | feedback => closed |
| 2017-07-24 12:12 | alostale | Resolution | open => no change required |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |