0036208: Retail: EntityPersistenceEventObserver validations has a high log level

Description

Entity validations created extending EntityPersistenceEventObserver, when the validation fails an exception is thrown, and it is registered in the openbravo log file. These kind of exceptions are functional validations and should not be registered in the openbravo log with a high level

Steps To Reproduce

For example to make fail the validation implemented in org.openbravo.retail.posterminal.event.ProductEventHandler, try to create a product with type "Service" and checked "Show stock". The validation appears and the record cannot be saved. Observe the openbravo log a exception is registered.

Proposed Solution

The infrastructure does not log anything by default. The problem is some of these observers are throwing OBException, which by default log stack traces.

Candidates to check:

$ find -name *.java | xargs grep "extends.*EntityPersistenceEventObserver" -l | xargs grep OBException -l | sort

== Functional ==
./modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java
./modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_PaymentEventListener.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AcctSchemaEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java
./src/org/openbravo/event/ConversionRateEventHandler.java
./src/org/openbravo/event/DocTypeEventHandler.java
./src/org/openbravo/event/GLJournalLineEventHandler.java
./src/org/openbravo/event/InvoiceTaxEventHandler.java
./src/org/openbravo/event/MInOutLineEventHandler.java
./src/org/openbravo/event/OrderDiscountEventHandler.java
./src/org/openbravo/event/PeriodEventHandler.java
./src/org/openbravo/event/ProductAumEventHandler.java
./src/org/openbravo/event/ProductCharacteristicEventHandler.java
./src/org/openbravo/event/ProductEventHandler.java
./src/org/openbravo/event/ProductionLineEventHandler.java
./src/org/openbravo/event/ServiceOrderLineEventHandler.java
./src/org/openbravo/event/ServicePriceRuleRangeEventHandler.java
./src/org/openbravo/event/SimpleGLJournalEventHandler.java
./src/org/openbravo/event/UOMConversionEventHandler.java

== Platform ==
./modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/FieldHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RoleAccessUniqueHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TableEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TableTreeEventHandler.java
./modules/org.openbravo.client.application/src/org/openbravo/client/application/event/WindowPersonalizationEventHandler.java
./src/org/openbravo/event/ADTableEventHandler.java
./src/org/openbravo/event/ProcessRequestEventHandler.java

== Retail ==
./modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/MultiServerPreferenceEventHandler.java
./modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/servercontroller/ServerStateBackgroundEventHandler.java
./modules/org.openbravo.retail.discounts/src/org/openbravo/retail/discounts/event/MOfferEventHandler.java
./modules/org.openbravo.retail.discounts/src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/ADOrgWarehouseEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/AppPaymentEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/PaymentMethodEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/ProductEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/event/TerminalTypePaymentMethodEventHandler.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
./modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/PaymentMethodHandler.java

Issue History
Date Modified	Username	Field	Change
2017-06-08 14:30	alostale	New Issue
2017-06-08 14:30	alostale	Assigned To	=> platform
2017-06-08 14:30	alostale	Modules	=> Core
2017-06-08 14:30	alostale	Triggers an Emergency Pack	=> No
2017-06-08 14:30	alostale	Issue generated from	0036183
2017-06-08 14:30	alostale	Relationship added	related to 0036183
2017-06-08 14:31	alostale	Project	Openbravo ERP => Java Client POS
2017-06-08 14:32	alostale	Project	Java Client POS => Retail Modules
2017-06-08 14:32	alostale	Category	Z. Others => Web POS
2017-06-08 14:33	alostale	Relationship added	blocks 0036162
2017-06-08 14:34	alostale	Assigned To	platform => Retail
2017-06-08 14:35	alostale	Proposed Solution updated
2017-07-24 12:07	alostale	Relationship added	related to 0036527
2017-07-24 12:07	alostale	Note Added: 0098196

Notes
(0098196) alostale (manager) 2017-07-24 12:07	After changing default behavior for OBException (0036527), review none of them should be actually logged.