Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035961
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2017-05-09 16:032017-06-13 18:41
ReporterguilleaerView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision4a1814f2f5dd
ProjectionnoneETAnoneTarget VersionRR17Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035961: Due to previous fix, popups are closed if a resize event occurs while a popup is opened

DescriptionA bit of history about this issue:

Before to 17Q2, there was one issue which we were unable to fix (32975, 31071 and 31163) for a long time. The problem reported by all issues mentioned above talks about the same problem:
- "Popups do not work if you resize the window while the popup is opened"
- "Popups in web pos stop working if they are opened and the the pos window is resized"

Finally in 17Q2 we were able to find a fix, but this fix have one restriction explained in the notes:
"If you open a popup and then, having the popup opened the window is resized then the popup will be closed. The user can open it again and continue working."

Later in april, we decided that this restriction is not acceptable so this issue has been created. We need to completely solve the problem, even if the popup is opened.

Important note: This issue is not a regression because without the previous fix, popups are not closed but they are not working

why we can't close the popups if a resize occurs:

1. Imagine that a user is filling a long form which is is a popup and suddenly a resize event occurs. In this case the user will lose the data inserted in the popup
2. Some payments gateways are rendered using a popup. If a resize event occurs during the communication with the payment gateway, the popup will be closed and the user perception about the result of the transaction will be unpredictable.
Steps To ReproduceOpen receipts popup
resize the window

Result: Popup will be closed.
Proposed SolutionPopups should continue working even if a resize event happens.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0036025 newRetail Verified returns popup is not shown correctly on mobile devices 
depends on design defect 0032975 closedguilleaer [SER QA 969] Search popups in web pos (Receipts/BPs/Locations) stop working if they are opened and the the pos window is resized 
depends on design defect 0034327 closedranjith_qualiantech_com [UX] If popups are not working properly, an error message should be shown 
depends on backport 0036246RR17Q2.1 closedguilleaer Due to previous fix, popups are closed if a resize event occurs while a popup is opened 
depends on backport 0036247RR17Q1.2 closedguilleaer Due to previous fix, popups are closed if a resize event occurs while a popup is opened 
has duplicate defect 0036236 closedRetail If WEBPOS is resized the arrow icon in the left side is not displaying the menu 

-  Notes
(0096492)
hgbot (developer)
2017-05-09 16:31

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7cd14c331c55e6a25720f3c2e1718edfe27ad7a3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:26:31 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7cd14c331c55e6a25720f3c2e1718edfe27ad7a3 [^]

Related to issue 35961: Remove code which shows a popup when popups are not working fine

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0096494)
hgbot (developer)
2017-05-09 16:32

 Repository: tools/automation/pi-mobile
Changeset: dab151f76d7cd6e4d85ed1a25274ca68514fd941
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:28:55 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dab151f76d7cd6e4d85ed1a25274ca68514fd941 [^]

Related to issue 35961: remove test which is no longer needed. Popup to show errors will not be shown anymore

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34327_VerifyScanAreaNotification.java
---
(0096495)
guilleaer (manager)
2017-05-09 16:39
edited on: 2017-05-09 17:15

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d97e45818055
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:24:56 2017 +0200
URL: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d97e45818055 [^]

Fixed issue 35961: Popups will continue working if a resize event occurs, even if they are opened.

This fix have three parts.
1st: Remove the changes done to fix the issue 32975
2nd: Remove the code which shows a message in case that we detect that popups are broken (Issue 34327)
3th part: Add code to avoid the render process for components which are popup when a resize event occurs:
When a resize event happens, the whole application are rendered, including popups. When popups are re-rendered the ones which exists are destroyed (enyo objects are destroyed) but the DOM object are not destroyed. The result is a popup which is being shown in the screen but it is being handled by a component which is destroyed. (previous fix removes the invalid dom elements and then when popup is reopened everything works because popup DOM is re-rendered)

What we have done is avoid this destroy/render process when a resize event happens. Doing it enyo object is still valid and also the DOM which is now managed by a valid enyo component.
This code, only is executed when resize event is being executed, that's why a flag "OB.resizing" was created to wrap the render process.

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0096671)
hgbot (developer)
2017-05-19 09:50

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 51504365e8e1879ceee8c50591f8a32f11fedd17
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 18 12:13:27 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/51504365e8e1879ceee8c50591f8a32f11fedd17 [^]

Related to issue 35961: Change the way to select popups

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
---
(0097368)
guilleaer (manager)
2017-06-13 17:54

 Reopened because menu is not working fine if a resize event happens when the menu is opened.
If resize occurs when menu is opened the menu is closed and it will not work again until the web POS is refreshed
(0097369)
hgbot (developer)
2017-06-13 17:56

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4a1814f2f5dd34893f894c6f3c62a8ec979cf8b1
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 17:55:49 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a1814f2f5dd34893f894c6f3c62a8ec979cf8b1 [^]

Fixed issue 35961: Menu will work fine even if a resize event occurs

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
---
(0097371)
hgbot (developer)
2017-06-13 18:29

 Repository: retail/backports/3.0RR17Q1.2/org.openbravo.retail.posterminal
Changeset: 08a7d6b513f223cc6e37d20ee6e3486221f99b11
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:28:53 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.2/org.openbravo.retail.posterminal/rev/08a7d6b513f223cc6e37d20ee6e3486221f99b11 [^]

Related to issue 36247 backport of issue 35961: Remove red popup about not working popups

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0097373)
hgbot (developer)
2017-06-13 18:31

 Repository: retail/backports/3.0RR17Q1.2/org.openbravo.mobile.core
Changeset: c1f972b56fccfc773b42a67e8cb750bd31983fb3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:30:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.2/org.openbravo.mobile.core/rev/c1f972b56fccfc773b42a67e8cb750bd31983fb3 [^]

Related to issue 36247 backport of issue 35961: Remove old code and apply new fix

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0097376)
hgbot (developer)
2017-06-13 18:39

 Repository: retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal
Changeset: f6c9961bc1d01b63e90266eef4e0c311f197e6fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:39:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/f6c9961bc1d01b63e90266eef4e0c311f197e6fa [^]

Related to issue 36246 backport of issue 35961: Remove red popup about not working popups

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0097378)
hgbot (developer)
2017-06-13 18:41

 Repository: retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core
Changeset: e812f2772dc030460b2fb97233e5da716832fe93
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:40:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core/rev/e812f2772dc030460b2fb97233e5da716832fe93 [^]

Related to issue 36246 backport of issue 35961: Remove old code and apply new fix

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---

- Issue History
Date Modified Username Field Change
2017-05-09 16:03 guilleaer New Issue
2017-05-09 16:03 guilleaer Assigned To => guilleaer
2017-05-09 16:03 guilleaer Triggers an Emergency Pack => No
2017-05-09 16:13 guilleaer Description Updated View Revisions
2017-05-09 16:31 hgbot Checkin
2017-05-09 16:31 hgbot Note Added: 0096492
2017-05-09 16:32 hgbot Checkin
2017-05-09 16:32 hgbot Note Added: 0096494
2017-05-09 16:39 guilleaer Status new => scheduled
2017-05-09 16:39 guilleaer Note Added: 0096495
2017-05-09 16:39 guilleaer Status scheduled => resolved
2017-05-09 16:39 guilleaer Fixed in Version => RR17Q3
2017-05-09 16:39 guilleaer Resolution open => fixed
2017-05-09 16:39 guilleaer Note Edited: 0096495 View Revisions
2017-05-09 16:40 guilleaer Note Edited: 0096495 View Revisions
2017-05-09 16:42 guilleaer Note Edited: 0096495 View Revisions
2017-05-09 16:43 guilleaer Relationship added depends on 0032975
2017-05-09 16:43 guilleaer Relationship added depends on 0034327
2017-05-09 17:15 guilleaer Note Edited: 0096495 View Revisions
2017-05-17 14:08 marvintm Relationship added related to 0036025
2017-05-17 14:09 marvintm Review Assigned To => marvintm
2017-05-17 14:09 marvintm Status resolved => closed
2017-05-19 09:50 hgbot Checkin
2017-05-19 09:50 hgbot Note Added: 0096671
2017-06-13 17:54 guilleaer Note Added: 0097368
2017-06-13 17:54 guilleaer Status closed => new
2017-06-13 17:54 guilleaer Resolution fixed => open
2017-06-13 17:54 guilleaer Fixed in Version RR17Q3 =>
2017-06-13 17:56 hgbot Checkin
2017-06-13 17:56 hgbot Note Added: 0097369
2017-06-13 17:56 hgbot Status new => resolved
2017-06-13 17:56 hgbot Resolution open => fixed
2017-06-13 17:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a1814f2f5dd34893f894c6f3c62a8ec979cf8b1 [^]
2017-06-13 18:09 guilleaer Status resolved => new
2017-06-13 18:09 guilleaer Resolution fixed => open
2017-06-13 18:11 guilleaer Status new => scheduled
2017-06-13 18:11 guilleaer Status scheduled => resolved
2017-06-13 18:11 guilleaer Fixed in Version => RR17Q3
2017-06-13 18:11 guilleaer Resolution open => fixed
2017-06-13 18:29 hgbot Checkin
2017-06-13 18:29 hgbot Note Added: 0097371
2017-06-13 18:31 hgbot Checkin
2017-06-13 18:31 hgbot Note Added: 0097373
2017-06-13 18:31 marvintm Relationship added has duplicate 0036236
2017-06-13 18:31 marvintm Status resolved => closed
2017-06-13 18:39 hgbot Checkin
2017-06-13 18:39 hgbot Note Added: 0097376
2017-06-13 18:41 hgbot Checkin
2017-06-13 18:41 hgbot Note Added: 0097378

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker