Openbravo Issue Tracking System - Retail Modules |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0035961 | Retail Modules | Web POS | public | 2017-05-09 16:03 | 2017-06-13 18:41 |
|
Reporter | guilleaer | |
Assigned To | guilleaer | |
Priority | normal | Severity | major | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | RR17Q3 | Fixed in Version | RR17Q3 | |
Merge Request Status | |
Review Assigned To | marvintm |
OBNetwork customer | |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0035961: Due to previous fix, popups are closed if a resize event occurs while a popup is opened |
Description | A bit of history about this issue:
Before to 17Q2, there was one issue which we were unable to fix (32975, 31071 and 31163) for a long time. The problem reported by all issues mentioned above talks about the same problem:
- "Popups do not work if you resize the window while the popup is opened"
- "Popups in web pos stop working if they are opened and the the pos window is resized"
Finally in 17Q2 we were able to find a fix, but this fix have one restriction explained in the notes:
"If you open a popup and then, having the popup opened the window is resized then the popup will be closed. The user can open it again and continue working."
Later in april, we decided that this restriction is not acceptable so this issue has been created. We need to completely solve the problem, even if the popup is opened.
Important note: This issue is not a regression because without the previous fix, popups are not closed but they are not working
why we can't close the popups if a resize occurs:
1. Imagine that a user is filling a long form which is is a popup and suddenly a resize event occurs. In this case the user will lose the data inserted in the popup
2. Some payments gateways are rendered using a popup. If a resize event occurs during the communication with the payment gateway, the popup will be closed and the user perception about the result of the transaction will be unpredictable. |
Steps To Reproduce | Open receipts popup
resize the window
Result: Popup will be closed. |
Proposed Solution | Popups should continue working even if a resize event happens. |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | defect | 0036025 | | new | Retail | Verified returns popup is not shown correctly on mobile devices | depends on | design defect | 0032975 | | closed | guilleaer | [SER QA 969] Search popups in web pos (Receipts/BPs/Locations) stop working if they are opened and the the pos window is resized | depends on | design defect | 0034327 | | closed | ranjith_qualiantech_com | [UX] If popups are not working properly, an error message should be shown | depends on | backport | 0036246 | RR17Q2.1 | closed | guilleaer | Due to previous fix, popups are closed if a resize event occurs while a popup is opened | depends on | backport | 0036247 | RR17Q1.2 | closed | guilleaer | Due to previous fix, popups are closed if a resize event occurs while a popup is opened | has duplicate | defect | 0036236 | | closed | Retail | If WEBPOS is resized the arrow icon in the left side is not displaying the menu |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2017-05-09 16:03 | guilleaer | New Issue | |
2017-05-09 16:03 | guilleaer | Assigned To | => guilleaer |
2017-05-09 16:03 | guilleaer | Triggers an Emergency Pack | => No |
2017-05-09 16:13 | guilleaer | Description Updated | bug_revision_view_page.php?rev_id=15134#r15134 |
2017-05-09 16:31 | hgbot | Checkin | |
2017-05-09 16:31 | hgbot | Note Added: 0096492 | |
2017-05-09 16:32 | hgbot | Checkin | |
2017-05-09 16:32 | hgbot | Note Added: 0096494 | |
2017-05-09 16:39 | guilleaer | Status | new => scheduled |
2017-05-09 16:39 | guilleaer | Note Added: 0096495 | |
2017-05-09 16:39 | guilleaer | Status | scheduled => resolved |
2017-05-09 16:39 | guilleaer | Fixed in Version | => RR17Q3 |
2017-05-09 16:39 | guilleaer | Resolution | open => fixed |
2017-05-09 16:39 | guilleaer | Note Edited: 0096495 | bug_revision_view_page.php?bugnote_id=0096495#r15136 |
2017-05-09 16:40 | guilleaer | Note Edited: 0096495 | bug_revision_view_page.php?bugnote_id=0096495#r15137 |
2017-05-09 16:42 | guilleaer | Note Edited: 0096495 | bug_revision_view_page.php?bugnote_id=0096495#r15138 |
2017-05-09 16:43 | guilleaer | Relationship added | depends on 0032975 |
2017-05-09 16:43 | guilleaer | Relationship added | depends on 0034327 |
2017-05-09 17:15 | guilleaer | Note Edited: 0096495 | bug_revision_view_page.php?bugnote_id=0096495#r15139 |
2017-05-17 14:08 | marvintm | Relationship added | related to 0036025 |
2017-05-17 14:09 | marvintm | Review Assigned To | => marvintm |
2017-05-17 14:09 | marvintm | Status | resolved => closed |
2017-05-19 09:50 | hgbot | Checkin | |
2017-05-19 09:50 | hgbot | Note Added: 0096671 | |
2017-06-13 17:54 | guilleaer | Note Added: 0097368 | |
2017-06-13 17:54 | guilleaer | Status | closed => new |
2017-06-13 17:54 | guilleaer | Resolution | fixed => open |
2017-06-13 17:54 | guilleaer | Fixed in Version | RR17Q3 => |
2017-06-13 17:56 | hgbot | Checkin | |
2017-06-13 17:56 | hgbot | Note Added: 0097369 | |
2017-06-13 17:56 | hgbot | Status | new => resolved |
2017-06-13 17:56 | hgbot | Resolution | open => fixed |
2017-06-13 17:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4a1814f2f5dd34893f894c6f3c62a8ec979cf8b1 [^] |
2017-06-13 18:09 | guilleaer | Status | resolved => new |
2017-06-13 18:09 | guilleaer | Resolution | fixed => open |
2017-06-13 18:11 | guilleaer | Status | new => scheduled |
2017-06-13 18:11 | guilleaer | Status | scheduled => resolved |
2017-06-13 18:11 | guilleaer | Fixed in Version | => RR17Q3 |
2017-06-13 18:11 | guilleaer | Resolution | open => fixed |
2017-06-13 18:29 | hgbot | Checkin | |
2017-06-13 18:29 | hgbot | Note Added: 0097371 | |
2017-06-13 18:31 | hgbot | Checkin | |
2017-06-13 18:31 | hgbot | Note Added: 0097373 | |
2017-06-13 18:31 | marvintm | Relationship added | has duplicate 0036236 |
2017-06-13 18:31 | marvintm | Status | resolved => closed |
2017-06-13 18:39 | hgbot | Checkin | |
2017-06-13 18:39 | hgbot | Note Added: 0097376 | |
2017-06-13 18:41 | hgbot | Checkin | |
2017-06-13 18:41 | hgbot | Note Added: 0097378 | |
Notes |
|
(0096492)
|
hgbot
|
2017-05-09 16:31
|
|
|
|
(0096494)
|
hgbot
|
2017-05-09 16:32
|
|
Repository: tools/automation/pi-mobile
Changeset: dab151f76d7cd6e4d85ed1a25274ca68514fd941
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:28:55 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/dab151f76d7cd6e4d85ed1a25274ca68514fd941 [^]
Related to issue 35961: remove test which is no longer needed. Popup to show errors will not be shown anymore
---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I34327_VerifyScanAreaNotification.java
---
|
|
|
(0096495)
|
guilleaer
|
2017-05-09 16:39
(edited on: 2017-05-09 17:15) |
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d97e45818055
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:24:56 2017 +0200
URL: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d97e45818055 [^]
Fixed issue 35961: Popups will continue working if a resize event occurs, even if they are opened.
This fix have three parts.
1st: Remove the changes done to fix the issue 32975
2nd: Remove the code which shows a message in case that we detect that popups are broken (Issue 34327)
3th part: Add code to avoid the render process for components which are popup when a resize event occurs:
When a resize event happens, the whole application are rendered, including popups. When popups are re-rendered the ones which exists are destroyed (enyo objects are destroyed) but the DOM object are not destroyed. The result is a popup which is being shown in the screen but it is being handled by a component which is destroyed. (previous fix removes the invalid dom elements and then when popup is reopened everything works because popup DOM is re-rendered)
What we have done is avoid this destroy/render process when a resize event happens. Doing it enyo object is still valid and also the DOM which is now managed by a valid enyo component.
This code, only is executed when resize event is being executed, that's why a flag "OB.resizing" was created to wrap the render process.
---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
|
|
|
(0096671)
|
hgbot
|
2017-05-19 09:50
|
|
|
|
|
Reopened because menu is not working fine if a resize event happens when the menu is opened.
If resize occurs when menu is opened the menu is closed and it will not work again until the web POS is refreshed |
|
|
(0097369)
|
hgbot
|
2017-06-13 17:56
|
|
|
|
(0097371)
|
hgbot
|
2017-06-13 18:29
|
|
|
|
(0097373)
|
hgbot
|
2017-06-13 18:31
|
|
Repository: retail/backports/3.0RR17Q1.2/org.openbravo.mobile.core
Changeset: c1f972b56fccfc773b42a67e8cb750bd31983fb3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:30:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.2/org.openbravo.mobile.core/rev/c1f972b56fccfc773b42a67e8cb750bd31983fb3 [^]
Related to issue 36247 backport of issue 35961: Remove old code and apply new fix
---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
|
|
|
(0097376)
|
hgbot
|
2017-06-13 18:39
|
|
|
|
(0097378)
|
hgbot
|
2017-06-13 18:41
|
|
Repository: retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core
Changeset: e812f2772dc030460b2fb97233e5da716832fe93
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 13 18:40:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.mobile.core/rev/e812f2772dc030460b2fb97233e5da716832fe93 [^]
Related to issue 36246 backport of issue 35961: Remove old code and apply new fix
---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
|
|