Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0032975
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2016-05-17 18:072017-05-09 16:45
ReporterVictorVillarView Statuspublic 
Assigned Toguilleaer 
PriorityurgentResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revisionf64a3739162d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032975: [SER QA 969] Search popups in web pos (Receipts/BPs/Locations) stop working if they are opened and the the pos window is resized

DescriptionWhen a search popup is opened in webpos (e.g. the Receipts popup), then dismissed, and then the browser is resized, the next time the same popup is opened, it won't work.
The html element of the search popup will appear duplicated
Steps To ReproduceLogin in web pos.
Open the Receipts search and verify it works.
Close the popup.
Resize the browser.
Open the Receipts search popup again.
The popup doesn't work anymore.
Verify that there are two html divs representing two different instances of the same popup.

Attached video: https://drive.google.com/a/openbravo.com/file/d/0B3RBrE5TUxwbVjJ5RVlfR3B6VzA/view [^]

The workaround is press F5.
TagsSER-QA
Attached Filespatch file icon 32975mobilecore.patch [^] (806 bytes) 2016-06-15 16:17 [Show Content]
patch file icon 32975posterminal.patch [^] (2,325 bytes) 2016-06-15 16:18 [Show Content]
diff file icon diffIssue32975_mobilecore.diff [^] (3,791 bytes) 2017-01-13 15:16 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
duplicate of defect 0031163 closedRetail [SERQA 293] Search popups in web pos (Receipts/BPs/Locations) stop working if they are opened and the the pos window is resized 
depends on backport 0034976RR17Q1 closedguilleaer [SER QA 969] Search popups in web pos (Receipts/BPs/Locations) stop working if they are opened and the the pos window is resized 
has duplicate defect 0031071 closedRetail Popups do not work if you resize the window while the popup is opened 
related to design defect 0034327 closedranjith_qualiantech_com [UX] If popups are not working properly, an error message should be shown 
blocks defect 0035961RR17Q3 closedguilleaer Due to previous fix, popups are closed if a resize event occurs while a popup is opened 

-  Notes
(0087311)
mario_castello (developer)
2016-06-15 16:29

Attached a solution for this issue.

In posterminal added some property to Receipts, BPartner and BPLocations popups.
- Floating set false to prevent duplicated div with the same popup.
- Model set to true that not allow action behind the popup.

Mobile core delete floating to allow center the popup.
(0093547)
guilleaer (manager)
2017-01-13 14:50

Attached patches
- 32975mobilecore.patch
- 32975posterminal.patch
seems to be not valid.

Now attaching a new patch for mobile core module which should resolve the problem with just one exception:
- If you open a popup and then, having the popup opened the window is resized then the popup will be closed. The user can open it again and continue working.

The scenario explained in that issue is working fine with this fix

patch attached (diffIssue32975_mobilecore.diff)
(0093616)
hgbot (developer)
2017-01-16 20:06

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f64a3739162d6077d00b3f9ae3fa78aa870650f7
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Jan 13 15:09:40 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f64a3739162d6077d00b3f9ae3fa78aa870650f7 [^]

Fixed issue 32975: Popups will continue working even after a resize event

This fix have 2 parts:
1st part: When a popup is redered (included into the DOM) a list of rendered popups is managed. This is done in the render function of OB.UI.Popup component
2nd part: When a resize event happens, we will iterate the list of rendered popups (rendered means that it is part of the DOM, not thet it is being shown). If the popup is being shown we will hide it and we will destroy the DOM element. Destroying it, the render process which is executed after resize will work fine and no duplicates will be created in the DOM

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0093678)
hgbot (developer)
2017-01-18 10:25

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: aacb0ab10b5a980cf6144ec00edc957c3eab59b0
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Jan 18 10:24:56 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aacb0ab10b5a980cf6144ec00edc957c3eab59b0 [^]

Related to issue 32975: Check correct property -showing- to detect if a popup is opened

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0093705)
hgbot (developer)
2017-01-18 16:54

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1d4c0e4c608e88641dff76c3354cc8e13291e0c2
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Jan 18 16:54:08 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1d4c0e4c608e88641dff76c3354cc8e13291e0c2 [^]

Related to issue 32975: Update copyright year

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0096491)
hgbot (developer)
2017-05-09 16:31

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d97e45818055783e547458bc6c5040dfac715f16
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue May 09 16:24:56 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d97e45818055783e547458bc6c5040dfac715f16 [^]

Fixed isssue 35961: Popups will continue working if a resize event occurs, even if they are opened.

This fix have three parts.
1st: Remove the changes done to fix the issue 32975
2nd: Remove the code which shows a message in case that we detect that popups are broken (Issue
34327)
3th part: Add code to avoid the render process for components which are popup when a resize event occurs:
More details: When a resize event happens, the whole applicattion are rendered, included popups. When popups are re-rendered the ones which exists are destroyed (enyo onjects are destroyed) but the DOM object are not destroyed. The result is a popup which is being shown in the screen but it is being handled by a component which is destroyed.
What we have done is avoid this destroy/render process when a resize event happens. Doing it enyo object is still valid and also the DOM which is now managed by a valid enyo component.
This code, only is executed when resize event is being executed, that's why a flag "OB.resizing" was created to wrap the render process.

---
M web/org.openbravo.mobile.core/build/enyo.js
M web/org.openbravo.mobile.core/enyo/source/dom/Control.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0096497)
guilleaer (manager)
2017-05-09 16:45

This code has been removed because finally we have a fix for popups:
https://issues.openbravo.com/view.php?id=35961 [^]

- Issue History
Date Modified Username Field Change
2016-05-17 18:07 VictorVillar New Issue
2016-05-17 18:07 VictorVillar Assigned To => Retail
2016-05-17 18:07 VictorVillar Resolution time => 1464645600
2016-05-17 18:07 VictorVillar Triggers an Emergency Pack => No
2016-05-17 18:07 VictorVillar Tag Attached: SER-QA
2016-05-17 18:14 VictorVillar Steps to Reproduce Updated View Revisions
2016-05-17 18:20 VictorVillar Relationship added duplicate of 0031163
2016-05-19 10:20 Orekaria Status new => acknowledged
2016-05-20 11:47 VictorVillar Steps to Reproduce Updated View Revisions
2016-05-23 16:36 mario_castello Assigned To Retail => mario_castello
2016-05-23 18:56 mario_castello Status acknowledged => scheduled
2016-06-02 22:50 Orekaria Assigned To mario_castello => Retail
2016-06-02 22:50 Orekaria Status scheduled => acknowledged
2016-06-03 13:58 Orekaria Type defect => design defect
2016-06-15 16:17 mario_castello File Added: 32975mobilecore.patch
2016-06-15 16:18 mario_castello File Added: 32975posterminal.patch
2016-06-15 16:29 mario_castello Note Added: 0087311
2016-10-27 22:16 dbaz Relationship added related to 0034327
2017-01-13 14:50 guilleaer Note Added: 0093547
2017-01-13 14:50 guilleaer File Added: diffIssue32975_mobilecore.diff
2017-01-13 15:16 guilleaer File Deleted: diffIssue32975_mobilecore.diff
2017-01-13 15:16 guilleaer File Added: diffIssue32975_mobilecore.diff
2017-01-16 20:06 hgbot Checkin
2017-01-16 20:06 hgbot Note Added: 0093616
2017-01-16 20:06 hgbot Status acknowledged => resolved
2017-01-16 20:06 hgbot Resolution open => fixed
2017-01-16 20:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f64a3739162d6077d00b3f9ae3fa78aa870650f7 [^]
2017-01-17 08:54 guilleaer Assigned To Retail => guilleaer
2017-01-17 08:54 guilleaer Status resolved => new
2017-01-17 08:54 guilleaer Resolution fixed => open
2017-01-17 08:54 guilleaer Status new => scheduled
2017-01-17 08:55 guilleaer Status scheduled => resolved
2017-01-17 08:55 guilleaer Fixed in Version => RR17Q2
2017-01-17 08:55 guilleaer Resolution open => fixed
2017-01-18 10:25 hgbot Checkin
2017-01-18 10:25 hgbot Note Added: 0093678
2017-01-18 16:54 hgbot Checkin
2017-01-18 16:54 hgbot Note Added: 0093705
2017-01-24 09:31 marvintm Review Assigned To => marvintm
2017-01-24 09:31 marvintm Status resolved => closed
2017-04-18 10:33 guilleaer Relationship added has duplicate 0031071
2017-05-09 16:31 hgbot Checkin
2017-05-09 16:31 hgbot Note Added: 0096491
2017-05-09 16:43 guilleaer Relationship added blocks 0035961
2017-05-09 16:45 guilleaer Note Added: 0096497


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker