Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035149 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | N/A | 2017-02-03 08:17 | 2017-03-15 20:19 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d54c0d9a007f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035149: Review classes extending BaseProcessActionHandler to use ResponseActionsBuilder to generate the response | |||||||
| Description | Classes extending BaseProcessActionHandler should be reviewed in order to make use of the new ResponseActionsBuilder API. This class is a helper that can be used to generate the handler response when it is returning any of the available standard response actions[1]. This will help to have cleaner code in those classes. [1] http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Returning_Several_Actions [^] | |||||||
| Steps To Reproduce | In description | |||||||
| Proposed Solution | Change platform processes: * BaseReportActionHandler * DefaultsProcessActionHandler * GrantPortalAccessProcess * KillProcess | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0094035) caristu (developer) 2017-02-03 11:57 edited on: 2017-02-03 12:54 |
Review summary: - BaseReportActionHandler: ResponseActionsBuilder will be used to configure the 'retryExecution' and 'showResultInProcessView' settings and also to return the message error when it fails. This process also makes use of some custom response actions which currently does not make sense to expose in the ResponseActionsBuilder API, so we are keeping their addition in a "manual" way. - DefaultsProcessActionHandler: no change required. It is not using response actions. - GrantPortalAccessProcess: to be updated, it is not exactly using the response actions feature, but it is returning a message with the process result. - KillProcess: to be updated, it is using response actions to return a message with the result. |
|
(0094037) hgbot (developer) 2017-02-03 12:49 |
Repository: erp/devel/pi Changeset: bea15095b80ff89f6758fe0bf2b7515057ea6edb Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Fri Feb 03 12:48:19 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/bea15095b80ff89f6758fe0bf2b7515057ea6edb [^] related to issue 35149: Added required methods in ResponseActionsBuilder API - Overloading showMsgInProcessView to allow not to specify a message title. In this case a default title is taken in the client side, depending on the message type. - Added new showResultsInProcessView method which allows to configure a response to show the result of a process in the process window itself. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java --- |
|
(0094038) hgbot (developer) 2017-02-03 13:06 |
Repository: erp/devel/pi Changeset: d54c0d9a007f0643849e6060add1ba0a576b97bf Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Fri Feb 03 13:03:52 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/d54c0d9a007f0643849e6060add1ba0a576b97bf [^] fixes issue 35149: use ResponseActionsBuilder API --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java M src/org/openbravo/common/actionhandler/KillProcess.java M src/org/openbravo/portal/GrantPortalAccessProcess.java --- |
|
(0094203) alostale (manager) 2017-02-10 08:42 |
reviewed |
|
(0095156) hudsonbot (developer) 2017-03-15 20:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^] Maturity status: Test |
|
(0095157) hudsonbot (developer) 2017-03-15 20:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-02-03 08:17 | alostale | New Issue | |
| 2017-02-03 08:17 | alostale | Assigned To | => platform |
| 2017-02-03 08:17 | alostale | Modules | => Core |
| 2017-02-03 08:17 | alostale | Triggers an Emergency Pack | => No |
| 2017-02-03 08:17 | alostale | Issue generated from | 0035091 |
| 2017-02-03 08:17 | alostale | Relationship added | related to 0035091 |
| 2017-02-03 08:18 | alostale | Relationship added | depends on 0035074 |
| 2017-02-03 08:19 | alostale | Status | new => acknowledged |
| 2017-02-03 08:20 | alostale | Proposed Solution updated | |
| 2017-02-03 08:21 | alostale | Proposed Solution updated | |
| 2017-02-03 10:18 | caristu | Assigned To | platform => caristu |
| 2017-02-03 10:18 | caristu | Status | acknowledged => scheduled |
| 2017-02-03 11:57 | caristu | Note Added: 0094035 | |
| 2017-02-03 12:00 | caristu | Note Edited: 0094035 | View Revisions |
| 2017-02-03 12:06 | caristu | Note Edited: 0094035 | View Revisions |
| 2017-02-03 12:14 | caristu | Note Edited: 0094035 | View Revisions |
| 2017-02-03 12:49 | hgbot | Checkin | |
| 2017-02-03 12:49 | hgbot | Note Added: 0094037 | |
| 2017-02-03 12:54 | caristu | Note Edited: 0094035 | View Revisions |
| 2017-02-03 13:06 | hgbot | Checkin | |
| 2017-02-03 13:06 | hgbot | Note Added: 0094038 | |
| 2017-02-03 13:06 | hgbot | Status | scheduled => resolved |
| 2017-02-03 13:06 | hgbot | Resolution | open => fixed |
| 2017-02-03 13:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d54c0d9a007f0643849e6060add1ba0a576b97bf [^] |
| 2017-02-03 13:06 | caristu | Review Assigned To | => alostale |
| 2017-02-10 08:42 | alostale | Note Added: 0094203 | |
| 2017-02-10 08:42 | alostale | Status | resolved => closed |
| 2017-02-10 08:42 | alostale | Fixed in Version | => 3.0PR17Q2 |
| 2017-03-15 20:19 | hudsonbot | Checkin | |
| 2017-03-15 20:19 | hudsonbot | Note Added: 0095156 | |
| 2017-03-15 20:19 | hudsonbot | Checkin | |
| 2017-03-15 20:19 | hudsonbot | Note Added: 0095157 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |