Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035149Openbravo ERPA. Platformpublic2017-02-03 08:172017-03-15 20:19
Reporteralostale 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035149: Review classes extending BaseProcessActionHandler to use ResponseActionsBuilder to generate the response
DescriptionClasses extending BaseProcessActionHandler should be reviewed in order to make use of the new ResponseActionsBuilder API.

This class is a helper that can be used to generate the handler response when it is returning any of the available standard response actions[1].

This will help to have cleaner code in those classes.

[1] http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Returning_Several_Actions [^]
Steps To ReproduceIn description
Proposed SolutionChange platform processes:
* BaseReportActionHandler
* DefaultsProcessActionHandler
* GrantPortalAccessProcess
* KillProcess
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0035091 new Triage Omni OMS Review classes extending BaseProcessActionHandler to use ResponseActionsBuilder to generate the response 
depends on feature request 0035074 closed caristu Create a builder for the BaseProcessActionHandler response actions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-02-03 08:17alostaleNew Issue
2017-02-03 08:17alostaleAssigned To => platform
2017-02-03 08:17alostaleModules => Core
2017-02-03 08:17alostaleTriggers an Emergency Pack => No
2017-02-03 08:17alostaleIssue generated from0035091
2017-02-03 08:17alostaleRelationship addedrelated to 0035091
2017-02-03 08:18alostaleRelationship addeddepends on 0035074
2017-02-03 08:19alostaleStatusnew => acknowledged
2017-02-03 08:20alostaleProposed Solution updated
2017-02-03 08:21alostaleProposed Solution updated
2017-02-03 10:18caristuAssigned Toplatform => caristu
2017-02-03 10:18caristuStatusacknowledged => scheduled
2017-02-03 11:57caristuNote Added: 0094035
2017-02-03 12:00caristuNote Edited: 0094035bug_revision_view_page.php?bugnote_id=0094035#r14458
2017-02-03 12:06caristuNote Edited: 0094035bug_revision_view_page.php?bugnote_id=0094035#r14459
2017-02-03 12:14caristuNote Edited: 0094035bug_revision_view_page.php?bugnote_id=0094035#r14460
2017-02-03 12:49hgbotCheckin
2017-02-03 12:49hgbotNote Added: 0094037
2017-02-03 12:54caristuNote Edited: 0094035bug_revision_view_page.php?bugnote_id=0094035#r14461
2017-02-03 13:06hgbotCheckin
2017-02-03 13:06hgbotNote Added: 0094038
2017-02-03 13:06hgbotStatusscheduled => resolved
2017-02-03 13:06hgbotResolutionopen => fixed
2017-02-03 13:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d54c0d9a007f0643849e6060add1ba0a576b97bf [^]
2017-02-03 13:06caristuReview Assigned To => alostale
2017-02-10 08:42alostaleNote Added: 0094203
2017-02-10 08:42alostaleStatusresolved => closed
2017-02-10 08:42alostaleFixed in Version => 3.0PR17Q2
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095156
2017-03-15 20:19hudsonbotCheckin
2017-03-15 20:19hudsonbotNote Added: 0095157

Notes
(0094035)
caristu   
2017-02-03 11:57   
(edited on: 2017-02-03 12:54)
Review summary:

- BaseReportActionHandler: ResponseActionsBuilder will be used to configure the 'retryExecution' and 'showResultInProcessView' settings and also to return the message error when it fails. This process also makes use of some custom response actions which currently does not make sense to expose in the ResponseActionsBuilder API, so we are keeping their addition in a "manual" way.

- DefaultsProcessActionHandler: no change required. It is not using response actions.

- GrantPortalAccessProcess: to be updated, it is not exactly using the response actions feature, but it is returning a message with the process result.

- KillProcess: to be updated, it is using response actions to return a message with the result.
(0094037)
hgbot   
2017-02-03 12:49   
Repository: erp/devel/pi
Changeset: bea15095b80ff89f6758fe0bf2b7515057ea6edb
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 03 12:48:19 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bea15095b80ff89f6758fe0bf2b7515057ea6edb [^]

related to issue 35149: Added required methods in ResponseActionsBuilder API

- Overloading showMsgInProcessView to allow not to specify a message title. In this case a default title is taken in the client side, depending on the message type.
- Added new showResultsInProcessView method which allows to configure a response to show the result of a process in the process window itself.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0094038)
hgbot   
2017-02-03 13:06   
Repository: erp/devel/pi
Changeset: d54c0d9a007f0643849e6060add1ba0a576b97bf
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 03 13:03:52 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d54c0d9a007f0643849e6060add1ba0a576b97bf [^]

fixes issue 35149: use ResponseActionsBuilder API

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
M src/org/openbravo/common/actionhandler/KillProcess.java
M src/org/openbravo/portal/GrantPortalAccessProcess.java
---
(0094203)
alostale   
2017-02-10 08:42   
reviewed
(0095156)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095157)
hudsonbot   
2017-03-15 20:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test