Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033817
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2016-08-26 08:532016-09-02 14:28
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision00c493919c46
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2015-11-19
Regression introduced in release3.0PR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/336cbe497bec [^]
Triggers an Emergency PackNo
Summary

0033817: No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt

DescriptionNo error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt
Steps To ReproduceAs group admin role:
   Close the current period for AP Payment and AR Receipt documents
   Check it is opened for AR Invoice and AP Invoice
   Create a sales invoice with today's date
   Complete it
   Try to void it and check the status is still Completed and no error message is shown
   The log shows:
      ERROR org.openbravo.base.exception.OBException - The Period does not exist or it is not opened
org.openbravo.base.exception.OBException: The Period does not exist or it is not opened
    at org.openbravo.advpaymentmngt.process.FIN_PaymentProcess.processPayment(FIN_PaymentProcess.java:1141)
    at org.openbravo.advpaymentmngt.process.FIN_PaymentProcess.execute(FIN_PaymentProcess.java:99)
    at org.openbravo.advpaymentmngt.process.FIN_AddPayment.processPayment(FIN_AddPayment.java:1584)
    at org.openbravo.advpaymentmngt.process.FIN_AddPayment.processPayment(FIN_AddPayment.java:1529)
    at org.openbravo.advpaymentmngt.ad_actionbutton.ProcessInvoice.doPost(ProcessInvoice.java:343)
   The problem is also reproduced with Purchase Invoices
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00338193.0PR16Q3.2 closedAtulOpenbravo No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt 
depends on backport 00338203.0PR16Q2.3 closedAtulOpenbravo No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt 
caused by defect 00309713.0PR16Q1 closedaferraz When voiding an unpaid invoice, payment schedule details should be canceled instead of deleted 

-  Notes
(0089472)
dmitry_mezentsev (developer)
2016-08-26 18:31

http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^]
(0089559)
AtulOpenbravo (developer)
2016-08-30 20:11
edited on: 2016-09-01 11:06

Test Plan
- Login as group admin role:
- Close the current period for AP Payment and AR Receipt documents
- Check it is opened for AR Invoice and AP Invoice
- Create a sales invoice with today's date, Payment Term = Immediate.
- Complete it.
- Try to void it and check that error message is shown."An error occurred when processing the payment:
The Period does not exist or it is not opened".

- Go to Open and Close Period Control. For current period, open AR Receipt document.
- Try to void previous Sales Invoice.
- Check that void action is successfully performed.

(0089617)
psanjuan (manager)
2016-08-31 13:05

issue verified.
(0089641)
psanjuan (manager)
2016-09-01 11:11
edited on: 2016-09-01 11:21

Test Plan
- Login as F&B International group admin role:
- Close the current period (September 2016) for AP Payment and AR Receipt documents
- Check it is opened for AR Invoice and AP Invoice
- Create a sales invoice with today's date, (September 1st) for F&B EspaƱa.
- Complete it and post it.
- Unpost it and Reactivate it. No error is shown.
- Complete it again and post it.
- Try to void it and check that error message is shown:
"An error occurred when processing the payment: The Period does not exist or it is not opened".
- Try to pay the invoice and check that same error is shown.

- Go to Open and Close Period Control. For current period, (September 2016) open AR Receipt document.
- Try to void previous Sales Invoice.
- Check that void action is successfully performed, and a reversed document has been created including a payment plan.

Repeat same test as above for purchase invoice.

Repeat same tests as above for a purchase invoice and a sales invoice do not dated on the period close (i.e. October 2016) . Verify that no error is shown.

Additional test:
- Close once again AR Receipt for September 2016. Try to Complete a payment in for that period. Check that same error is shown.

- Create a sales order for that period. Book it. Try to pay the order. Check that same error is shown. Try to close the order. Verify it can be closed without any problem.

- Repeat additional test also for purchase order and AP Payment.

(0089643)
psanjuan (manager)
2016-09-01 11:27

Test Plan above verified.
Issue can be code reviewed and closed.
(0089672)
hgbot (developer)
2016-09-01 17:55

Repository: erp/devel/pi
Changeset: 00c493919c46a6bac975d594038fab456559fa50
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 30 23:25:40 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/00c493919c46a6bac975d594038fab456559fa50 [^]

Fixes issue 33817: No error shown when voiding an invoice and period is closed

Error message shown in this case "An error occurred when processing the payment: The Period does not exist or it is not opened"

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0089674)
aferraz (manager)
2016-09-01 17:56

Code review OK
(0089707)
hudsonbot (developer)
2016-09-02 14:28

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-08-26 08:53 ngarcia New Issue
2016-08-26 08:53 ngarcia Assigned To => Triage Finance
2016-08-26 08:53 ngarcia Modules => Core
2016-08-26 08:53 ngarcia Resolution time => 1473976800
2016-08-26 08:53 ngarcia Triggers an Emergency Pack => No
2016-08-26 08:54 ngarcia Issue Monitored: networkb
2016-08-26 08:56 ngarcia Relationship added caused by 0030971
2016-08-26 09:17 aferraz Assigned To Triage Finance => AtulOpenbravo
2016-08-26 10:37 aferraz Status new => scheduled
2016-08-26 18:31 dmitry_mezentsev Note Added: 0089472
2016-08-26 18:31 dmitry_mezentsev Severity major => minor
2016-08-30 20:11 AtulOpenbravo Note Added: 0089559
2016-08-31 13:05 psanjuan Note Added: 0089617
2016-09-01 10:30 psanjuan Note Added: 0089639
2016-09-01 10:32 psanjuan Note Edited: 0089639 View Revisions
2016-09-01 10:34 psanjuan Note Edited: 0089639 View Revisions
2016-09-01 10:35 psanjuan Note Edited: 0089639 View Revisions
2016-09-01 11:03 psanjuan Note Deleted: 0089639
2016-09-01 11:06 psanjuan Note Edited: 0089559 View Revisions
2016-09-01 11:11 psanjuan Note Added: 0089641
2016-09-01 11:14 psanjuan Note Edited: 0089641 View Revisions
2016-09-01 11:21 psanjuan Note Edited: 0089641 View Revisions
2016-09-01 11:27 psanjuan Note Added: 0089643
2016-09-01 17:55 hgbot Checkin
2016-09-01 17:55 hgbot Note Added: 0089672
2016-09-01 17:55 hgbot Status scheduled => resolved
2016-09-01 17:55 hgbot Resolution open => fixed
2016-09-01 17:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/00c493919c46a6bac975d594038fab456559fa50 [^]
2016-09-01 17:56 aferraz Review Assigned To => aferraz
2016-09-01 17:56 aferraz Note Added: 0089674
2016-09-01 17:56 aferraz Status resolved => closed
2016-09-01 17:56 aferraz Fixed in Version => 3.0PR16Q4
2016-09-01 18:38 aferraz Regression level => Production - Confirmed Stable
2016-09-01 18:38 aferraz Regression date => 2015-11-19
2016-09-01 18:38 aferraz Regression introduced in release => 3.0PR16Q1
2016-09-01 18:38 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/336cbe497bec [^]
2016-09-02 14:28 hudsonbot Checkin
2016-09-02 14:28 hudsonbot Note Added: 0089707


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker