Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033817Openbravo ERPZ. Otherspublic2016-08-26 08:532016-09-02 14:28
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-11-19
Regression introduced in release3.0PR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/336cbe497bec [^]
Triggers an Emergency PackNo
Summary0033817: No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt
DescriptionNo error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt
Steps To ReproduceAs group admin role:
   Close the current period for AP Payment and AR Receipt documents
   Check it is opened for AR Invoice and AP Invoice
   Create a sales invoice with today's date
   Complete it
   Try to void it and check the status is still Completed and no error message is shown
   The log shows:
      ERROR org.openbravo.base.exception.OBException - The Period does not exist or it is not opened
org.openbravo.base.exception.OBException: The Period does not exist or it is not opened
    at org.openbravo.advpaymentmngt.process.FIN_PaymentProcess.processPayment(FIN_PaymentProcess.java:1141)
    at org.openbravo.advpaymentmngt.process.FIN_PaymentProcess.execute(FIN_PaymentProcess.java:99)
    at org.openbravo.advpaymentmngt.process.FIN_AddPayment.processPayment(FIN_AddPayment.java:1584)
    at org.openbravo.advpaymentmngt.process.FIN_AddPayment.processPayment(FIN_AddPayment.java:1529)
    at org.openbravo.advpaymentmngt.ad_actionbutton.ProcessInvoice.doPost(ProcessInvoice.java:343)
   The problem is also reproduced with Purchase Invoices
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00338193.0PR16Q3.2 closed AtulOpenbravo No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt 
depends on backport 00338203.0PR16Q2.3 closed AtulOpenbravo No error message shown when voiding an invoice and the period is closed for AP Payment and AR Receipt 
caused by defect 00309713.0PR16Q1 closed aferraz When voiding an unpaid invoice, payment schedule details should be canceled instead of deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-26 08:53ngarciaNew Issue
2016-08-26 08:53ngarciaAssigned To => Triage Finance
2016-08-26 08:53ngarciaModules => Core
2016-08-26 08:53ngarciaResolution time => 1473976800
2016-08-26 08:53ngarciaTriggers an Emergency Pack => No
2016-08-26 08:54ngarciaIssue Monitored: networkb
2016-08-26 08:56ngarciaRelationship addedcaused by 0030971
2016-08-26 09:17aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-08-26 10:37aferrazStatusnew => scheduled
2016-08-26 18:31dmitry_mezentsevNote Added: 0089472
2016-08-26 18:31dmitry_mezentsevSeveritymajor => minor
2016-08-30 20:11AtulOpenbravoNote Added: 0089559
2016-08-31 13:05psanjuanNote Added: 0089617
2016-09-01 10:30psanjuanNote Added: 0089639
2016-09-01 10:32psanjuanNote Edited: 0089639bug_revision_view_page.php?bugnote_id=0089639#r13007
2016-09-01 10:34psanjuanNote Edited: 0089639bug_revision_view_page.php?bugnote_id=0089639#r13008
2016-09-01 10:35psanjuanNote Edited: 0089639bug_revision_view_page.php?bugnote_id=0089639#r13009
2016-09-01 11:03psanjuanNote Deleted: 0089639
2016-09-01 11:06psanjuanNote Edited: 0089559bug_revision_view_page.php?bugnote_id=0089559#r13011
2016-09-01 11:11psanjuanNote Added: 0089641
2016-09-01 11:14psanjuanNote Edited: 0089641bug_revision_view_page.php?bugnote_id=0089641#r13013
2016-09-01 11:21psanjuanNote Edited: 0089641bug_revision_view_page.php?bugnote_id=0089641#r13014
2016-09-01 11:27psanjuanNote Added: 0089643
2016-09-01 17:55hgbotCheckin
2016-09-01 17:55hgbotNote Added: 0089672
2016-09-01 17:55hgbotStatusscheduled => resolved
2016-09-01 17:55hgbotResolutionopen => fixed
2016-09-01 17:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/00c493919c46a6bac975d594038fab456559fa50 [^]
2016-09-01 17:56aferrazReview Assigned To => aferraz
2016-09-01 17:56aferrazNote Added: 0089674
2016-09-01 17:56aferrazStatusresolved => closed
2016-09-01 17:56aferrazFixed in Version => 3.0PR16Q4
2016-09-01 18:38aferrazRegression level => Production - Confirmed Stable
2016-09-01 18:38aferrazRegression date => 2015-11-19
2016-09-01 18:38aferrazRegression introduced in release => 3.0PR16Q1
2016-09-01 18:38aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/336cbe497bec [^]
2016-09-02 14:28hudsonbotCheckin
2016-09-02 14:28hudsonbotNote Added: 0089707

Notes
(0089472)
dmitry_mezentsev   
2016-08-26 18:31   
http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^]
(0089559)
AtulOpenbravo   
2016-08-30 20:11   
(edited on: 2016-09-01 11:06)
Test Plan
- Login as group admin role:
- Close the current period for AP Payment and AR Receipt documents
- Check it is opened for AR Invoice and AP Invoice
- Create a sales invoice with today's date, Payment Term = Immediate.
- Complete it.
- Try to void it and check that error message is shown."An error occurred when processing the payment:
The Period does not exist or it is not opened".

- Go to Open and Close Period Control. For current period, open AR Receipt document.
- Try to void previous Sales Invoice.
- Check that void action is successfully performed.
(0089617)
psanjuan   
2016-08-31 13:05   
issue verified.
(0089641)
psanjuan   
2016-09-01 11:11   
(edited on: 2016-09-01 11:21)
Test Plan
- Login as F&B International group admin role:
- Close the current period (September 2016) for AP Payment and AR Receipt documents
- Check it is opened for AR Invoice and AP Invoice
- Create a sales invoice with today's date, (September 1st) for F&B España.
- Complete it and post it.
- Unpost it and Reactivate it. No error is shown.
- Complete it again and post it.
- Try to void it and check that error message is shown:
"An error occurred when processing the payment: The Period does not exist or it is not opened".
- Try to pay the invoice and check that same error is shown.

- Go to Open and Close Period Control. For current period, (September 2016) open AR Receipt document.
- Try to void previous Sales Invoice.
- Check that void action is successfully performed, and a reversed document has been created including a payment plan.

Repeat same test as above for purchase invoice.

Repeat same tests as above for a purchase invoice and a sales invoice do not dated on the period close (i.e. October 2016) . Verify that no error is shown.

Additional test:
- Close once again AR Receipt for September 2016. Try to Complete a payment in for that period. Check that same error is shown.

- Create a sales order for that period. Book it. Try to pay the order. Check that same error is shown. Try to close the order. Verify it can be closed without any problem.

- Repeat additional test also for purchase order and AP Payment.
(0089643)
psanjuan   
2016-09-01 11:27   
Test Plan above verified.
Issue can be code reviewed and closed.
(0089672)
hgbot   
2016-09-01 17:55   
Repository: erp/devel/pi
Changeset: 00c493919c46a6bac975d594038fab456559fa50
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 30 23:25:40 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/00c493919c46a6bac975d594038fab456559fa50 [^]

Fixes issue 33817: No error shown when voiding an invoice and period is closed

Error message shown in this case "An error occurred when processing the payment: The Period does not exist or it is not opened"

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0089674)
aferraz   
2016-09-01 17:56   
Code review OK
(0089707)
hudsonbot   
2016-09-02 14:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test