Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033438
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorsometimes2016-07-06 10:062016-08-11 18:40
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision89ad9b716896
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033438: DalConnectionProvider.getTransactionConnection does not obtain connection from common pool

DescriptionDalConnectionProvider.getTransactionConnection method used to keep transaction in sqlc, obtains the new connection directly from Hibernate's pool regardless how Openbravo pool is configured.

The consequences are:

  • New connection does not get initialized with the session config parameters, this can cause the problem reported in 0033429
  • These new connections are autonomously managed out of the declared pool
Steps To ReproduceUsing Oracle, install 3.1.1200 version of the aging balance module: https://code.openbravo.com/erp/mods/org.openbravo.agingbalance [^]

Go to Receivables Aging Balance.
Launch the report with the parameters:
*Organization: F&B España
*General Ledger: F&B España
*As of date: 27-06-2016
*Show Details: Checked
The rest of the parameters can be set with the default values

It should throw an error:
55585 [http-8081-2] ERROR org.openbravo.base.exception.OBException - Error
javax.servlet.ServletException: @CODE=1843@ORA-01843: not a valid month

    at org.openbravo.agingbalance.ad_reports.AgingDaoData.selectDetail(AgingDaoData.java:492)
    at org.openbravo.agingbalance.ad_reports.AgingDao.getOpenReceivablesAgingScheduleDetails(AgingDao.java:217)
    at org.openbravo.agingbalance.ad_reports.AgingProcess.printPageDetails(AgingProcess.java:391)
    at org.openbravo.agingbalance.ad_reports.AgingProcess.doPost(AgingProcess.java:156)
    at org.openbravo.base.HttpBaseServlet.doGet(HttpBaseServlet.java:294)

This behavior is not always consistent.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033429 closedaferraz Modules Problems in Aging Balance Report with Oracle due to date formats 
related to defect 0027878 closedmarvintm Openbravo ERP Code in DalConnectionprovider relate to getTransactionConnection seems to leak db connections always 
related to defect 00334413.0PR16Q4 closedNaroaIriarte Openbravo ERP query to check if ad_context_info exists executed once per request 
related to defect 0033507 closedNaroaIriarte Openbravo ERP copy lines can generate incorrect audit trail info 
related to defect 0038097 closedalostale Openbravo ERP DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query 

-  Notes
(0088238)
hgbot (developer)
2016-07-06 13:35

 Repository: erp/mods/org.openbravo.agingbalance
Changeset: eae2aeebcc7e0ed2974264cf62c7e1f891d3c0fc
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 06 12:48:00 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/eae2aeebcc7e0ed2974264cf62c7e1f891d3c0fc [^]

Fixed bug 33429: Problems in Aging Balance Report with Oracle due to date formats

This is a workaround for issue 33438. We pass the connection provider from the servlet to avoid this random problems on Oracle only

---
M src/org/openbravo/agingbalance/ad_reports/AgingDao.java
M src/org/openbravo/agingbalance/ad_reports/AgingProcess.java
---
(0088242)
hgbot (developer)
2016-07-06 13:59

 Repository: erp/devel/pi
Changeset: 89ad9b716896f01b574bfbac7f14e7a9775c1450
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 06 10:55:04 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/89ad9b716896f01b574bfbac7f14e7a9775c1450 [^]

fixed bug 33438: DCP.getTransactionConnection doesn't get connection from pool

  DalConnectionProvider.getTransactionConnection obtained connection directly
  from Hibernate's pool rather than from the configured one. This caused that
  connection not to be set with the correct configuration parameters, as well
  as it not to be centrally managed.

  This problem is now fixed by making public the method to obtain a new connection
  from the configured pool in SessionHandler, now DalConnectionProvider invokes
  it to get the connection instead of doing it explicitly.

---
M src/org/openbravo/dal/core/SessionHandler.java
M src/org/openbravo/service/db/DalConnectionProvider.java
---
(0088635)
caristu (viewer)
2016-07-22 13:02

 Code review + testing OK

Verified in pi@ea24d6781214
(0088992)
hudsonbot (viewer)
2016-08-11 18:40

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-07-06 10:06 alostale New Issue
2016-07-06 10:06 alostale Assigned To => platform
2016-07-06 10:06 alostale OBNetwork customer => No
2016-07-06 10:06 alostale Modules => Core
2016-07-06 10:06 alostale Triggers an Emergency Pack => No
2016-07-06 10:06 alostale Issue generated from 0033429
2016-07-06 10:06 alostale Relationship added related to 0033429
2016-07-06 10:13 alostale Summary Problems in Aging Balance Report with Oracle due to date formats => DalConnectionProvider.getTransactionConnection does not obtain connection from common pool
2016-07-06 10:13 alostale Description Updated View Revisions
2016-07-06 10:13 alostale Steps to Reproduce Updated View Revisions
2016-07-06 10:13 alostale Proposed Solution updated
2016-07-06 10:14 alostale Description Updated View Revisions
2016-07-06 10:15 alostale Relationship added related to 0027878
2016-07-06 12:18 alostale Relationship added related to 0033441
2016-07-06 12:18 alostale Assigned To platform => alostale
2016-07-06 12:19 alostale Status new => scheduled
2016-07-06 13:35 hgbot Checkin
2016-07-06 13:35 hgbot Note Added: 0088238
2016-07-06 13:59 hgbot Checkin
2016-07-06 13:59 hgbot Note Added: 0088242
2016-07-06 13:59 hgbot Status scheduled => resolved
2016-07-06 13:59 hgbot Resolution open => fixed
2016-07-06 13:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/89ad9b716896f01b574bfbac7f14e7a9775c1450 [^]
2016-07-08 07:54 alostale Review Assigned To => caristu
2016-07-20 12:48 alostale Relationship added related to 0033507
2016-07-22 13:02 caristu Note Added: 0088635
2016-07-22 13:02 caristu Status resolved => closed
2016-07-22 13:02 caristu Fixed in Version => 3.0PR16Q4
2016-08-11 18:40 hudsonbot Checkin
2016-08-11 18:40 hudsonbot Note Added: 0088992
2018-03-09 15:20 alostale Relationship added related to 0038097

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker