Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0038097
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2018-03-09 15:172018-03-14 18:24
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision226c41af46d2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038097: DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query

DescriptionConnections obtained using old commons dbcp pool with DalConnectionProvider.getTransactionConnection method, do not set db config query configured in Openbravo.properties.
Steps To Reproduce0. In an Oracle instance configured to use old pool (db.externalPoolClassName=)
1. Run RecordID2Test
  -> They fail with:
14303 [main] ERROR org.openbravo.erpCommon.ad_forms.AcctServerData - SQL error in query: SELECT C_Currency_Convert(TO_NUMBER(?), ?, ?,TO_DATE(?),TO_CHAR(?), ?, ?) AS CONVERTED FROM DUAL :java.sql.SQLDataException: ORA-01843: not a valid month

14314 [main] WARN org.openbravo.erpCommon.ad_forms.AcctServer - javax.servlet.ServletException: @CODE=1843@ORA-01843: not a valid month

javax.servlet.ServletException: @CODE=1843@ORA-01843: not a valid month

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0010330 closedmtaal Unable to Generate and Post Invoices in mass invoicing 
related to defect 0033438 closedalostale DalConnectionProvider.getTransactionConnection does not obtain connection from common pool 
related to defect 0038014 closedalostale DB connection leak using old pool in test cases 

-  Notes
(0103173)
hgbot (developer)
2018-03-13 07:40

Repository: erp/devel/pi
Changeset: 226c41af46d2050c23e717ed197612fbfd3b5300
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 09 15:28:54 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/226c41af46d2050c23e717ed197612fbfd3b5300 [^]

fixed bug 38097: DCP.getTransactionConnection in old pool doesn't set db config

  Connections obtained with DalConnectionProvider.getTransactionConnection in old
  pool didn't have executed the db config query.

---
M src/org/openbravo/dal/core/DalSessionFactory.java
M src/org/openbravo/dal/core/SessionHandler.java
---
(0103215)
hudsonbot (developer)
2018-03-13 17:24

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test
(0103249)
caristu (developer)
2018-03-14 18:24

Code reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2018-03-09 15:17 alostale New Issue
2018-03-09 15:17 alostale Assigned To => platform
2018-03-09 15:17 alostale Modules => Core
2018-03-09 15:17 alostale Triggers an Emergency Pack => No
2018-03-09 15:19 alostale Relationship added related to 0010330
2018-03-09 15:20 alostale Relationship added related to 0033438
2018-03-09 15:24 alostale Summary DalConnectionProvider. => DalConnectionProvider.getTransactionConnection with dbcp pool does not set db config query
2018-03-09 15:29 alostale Relationship added related to 0038014
2018-03-12 14:50 alostale Assigned To platform => alostale
2018-03-12 14:50 alostale Review Assigned To => caristu
2018-03-13 07:40 hgbot Checkin
2018-03-13 07:40 hgbot Note Added: 0103173
2018-03-13 07:40 hgbot Status new => resolved
2018-03-13 07:40 hgbot Resolution open => fixed
2018-03-13 07:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/226c41af46d2050c23e717ed197612fbfd3b5300 [^]
2018-03-13 17:24 hudsonbot Checkin
2018-03-13 17:24 hudsonbot Note Added: 0103215
2018-03-14 18:24 caristu Note Added: 0103249
2018-03-14 18:24 caristu Status resolved => closed
2018-03-14 18:24 caristu Fixed in Version => 3.0PR18Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker