Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032838
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2016-05-03 12:352016-06-17 19:37
ReporterJONHMView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona08db06ea86f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR16Q1SCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2016-04-08
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Triggers an Emergency PackNo
Summary

0032838: Cannot export CSV from Widgets

DescriptionAt trying to export CSV from any widget no file is exported nor error window showed
Steps To Reproduce1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Proposed SolutionSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00330243.0PR16Q1.2 closedcaristu Cannot export CSV from Widgets 
depends on backport 00330253.0PR15Q4.7 closedcaristu Cannot export CSV from Widgets 
depends on backport 00330273.0PR16Q2 closedcaristu Cannot export CSV from Widgets 
caused by defect 0032233 closedinigosanchez Payment In and Payment Out lines are not exported to CSV 

-  Notes
(0086200)
hgbot (developer)
2016-05-05 09:54

 Repository: erp/devel/pi
Changeset: 7cb0220888a9e411984d8f7bc26c863456219dd9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:31:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7cb0220888a9e411984d8f7bc26c863456219dd9 [^]

related to bug 32838: Cannot export CSV from Widgets

  Replcaed "magic numbers" with constant to get tabId param value

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0086201)
hgbot (developer)
2016-05-05 09:55

 Repository: erp/devel/pi
Changeset: 50cfbabf4fe370d4f75bacfff17905437b9c324e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:49:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^]

fixed bug 32838: Cannot export CSV from Widgets

  NPE was thrown when trying to export CSV from widgets because a refactor on
  that area of code changed sent value for tabId from null to undefined.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0086202)
hgbot (developer)
2016-05-05 09:55

 Repository: erp/devel/pi
Changeset: 385262689f5ebb0a683b178afefa439e8b5237e9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:53:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/385262689f5ebb0a683b178afefa439e8b5237e9 [^]

related to bug 32838: using JsonUtils.isValueEmpty
  to remove some code duplicities

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0086216)
caristu (developer)
2016-05-05 13:49

 Code review + testing OK on pi@385262689f5e
(0087517)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087518)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087519)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-05-03 12:35 JONHM New Issue
2016-05-03 12:35 JONHM Assigned To => platform
2016-05-03 12:35 JONHM Modules => Core
2016-05-03 12:35 JONHM Resolution time => 1465855200
2016-05-03 12:35 JONHM Triggers an Emergency Pack => No
2016-05-03 13:25 caristu Regression level => Pre packaging ( pi )
2016-05-03 13:25 caristu Regression date => 2016-04-08
2016-05-03 13:25 caristu Regression introduced in release => pi
2016-05-03 13:25 caristu Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/8cffe0e6a0dd [^]
2016-05-03 13:25 caristu Priority high => immediate
2016-05-03 13:25 caristu Proposed Solution updated
2016-05-03 13:25 caristu Proposed Solution updated
2016-05-03 13:26 caristu Proposed Solution updated
2016-05-03 13:29 caristu Relationship added caused by 0032610
2016-05-03 13:34 caristu Proposed Solution updated
2016-05-03 13:35 caristu Proposed Solution updated
2016-05-05 09:54 hgbot Checkin
2016-05-05 09:54 hgbot Note Added: 0086200
2016-05-05 09:55 hgbot Checkin
2016-05-05 09:55 hgbot Note Added: 0086201
2016-05-05 09:55 hgbot Status new => resolved
2016-05-05 09:55 hgbot Resolution open => fixed
2016-05-05 09:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^]
2016-05-05 09:55 hgbot Checkin
2016-05-05 09:55 hgbot Note Added: 0086202
2016-05-05 09:59 alostale Review Assigned To => caristu
2016-05-05 09:59 alostale Assigned To platform => alostale
2016-05-05 13:49 caristu Note Added: 0086216
2016-05-05 13:49 caristu Status resolved => closed
2016-05-05 13:49 caristu Fixed in Version => pi
2016-05-23 11:36 caristu Regression introduced by commit https://code.openbravo.com/erp/devel/pi/rev/8cffe0e6a0dd [^] => https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
2016-05-23 11:36 caristu Proposed Solution updated
2016-05-23 11:37 caristu Relationship deleted caused by 0032610
2016-05-23 11:37 caristu Relationship added caused by 0032233
2016-05-23 11:42 caristu Proposed Solution updated
2016-05-23 12:17 caristu Status closed => new
2016-05-23 12:17 caristu Resolution fixed => open
2016-05-23 12:17 caristu Fixed in Version pi =>
2016-05-23 12:17 caristu Status new => scheduled
2016-05-23 13:04 caristu Relationship added depends on 0033025
2016-05-23 13:10 caristu Status scheduled => acknowledged
2016-05-23 13:10 caristu Status acknowledged => scheduled
2016-05-23 13:35 hgbot Checkin
2016-05-23 13:35 hgbot Note Added: 0086648
2016-05-23 13:35 hgbot Status scheduled => resolved
2016-05-23 13:35 hgbot Resolution open => fixed
2016-05-23 13:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^] => http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/a08db06ea86f8190fec16c1fa6961331280d5c24 [^]
2016-05-23 13:35 caristu Note Deleted: 0086648
2016-05-24 07:35 alostale Status resolved => closed
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087517
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087518
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087519

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker