Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032838Openbravo ERPA. Platformpublic2016-05-03 12:352016-06-17 19:37
ReporterJONHM 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q1 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-04-08
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Triggers an Emergency PackNo
Summary0032838: Cannot export CSV from Widgets
DescriptionAt trying to export CSV from any widget no file is exported nor error window showed
Steps To Reproduce1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Proposed SolutionSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00330243.0PR16Q1.2 closed caristu Cannot export CSV from Widgets 
depends on backport 00330253.0PR15Q4.7 closed caristu Cannot export CSV from Widgets 
depends on backport 00330273.0PR16Q2 closed caristu Cannot export CSV from Widgets 
caused by defect 0032233 closed inigosanchez Payment In and Payment Out lines are not exported to CSV 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-03 12:35JONHMNew Issue
2016-05-03 12:35JONHMAssigned To => platform
2016-05-03 12:35JONHMModules => Core
2016-05-03 12:35JONHMResolution time => 1465855200
2016-05-03 12:35JONHMTriggers an Emergency Pack => No
2016-05-03 13:25caristuRegression level => Pre packaging ( pi )
2016-05-03 13:25caristuRegression date => 2016-04-08
2016-05-03 13:25caristuRegression introduced in release => pi
2016-05-03 13:25caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/8cffe0e6a0dd [^]
2016-05-03 13:25caristuPriorityhigh => immediate
2016-05-03 13:25caristuProposed Solution updated
2016-05-03 13:25caristuProposed Solution updated
2016-05-03 13:26caristuProposed Solution updated
2016-05-03 13:29caristuRelationship addedcaused by 0032610
2016-05-03 13:34caristuProposed Solution updated
2016-05-03 13:35caristuProposed Solution updated
2016-05-05 09:54hgbotCheckin
2016-05-05 09:54hgbotNote Added: 0086200
2016-05-05 09:55hgbotCheckin
2016-05-05 09:55hgbotNote Added: 0086201
2016-05-05 09:55hgbotStatusnew => resolved
2016-05-05 09:55hgbotResolutionopen => fixed
2016-05-05 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^]
2016-05-05 09:55hgbotCheckin
2016-05-05 09:55hgbotNote Added: 0086202
2016-05-05 09:59alostaleReview Assigned To => caristu
2016-05-05 09:59alostaleAssigned Toplatform => alostale
2016-05-05 13:49caristuNote Added: 0086216
2016-05-05 13:49caristuStatusresolved => closed
2016-05-05 13:49caristuFixed in Version => pi
2016-05-23 11:36caristuRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8cffe0e6a0dd [^] => https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
2016-05-23 11:36caristuProposed Solution updated
2016-05-23 11:37caristuRelationship deletedcaused by 0032610
2016-05-23 11:37caristuRelationship addedcaused by 0032233
2016-05-23 11:42caristuProposed Solution updated
2016-05-23 12:17caristuStatusclosed => new
2016-05-23 12:17caristuResolutionfixed => open
2016-05-23 12:17caristuFixed in Versionpi =>
2016-05-23 12:17caristuStatusnew => scheduled
2016-05-23 13:04caristuRelationship addeddepends on 0033025
2016-05-23 13:10caristuStatusscheduled => acknowledged
2016-05-23 13:10caristuStatusacknowledged => scheduled
2016-05-23 13:35hgbotCheckin
2016-05-23 13:35hgbotNote Added: 0086648
2016-05-23 13:35hgbotStatusscheduled => resolved
2016-05-23 13:35hgbotResolutionopen => fixed
2016-05-23 13:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^] => http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/a08db06ea86f8190fec16c1fa6961331280d5c24 [^]
2016-05-23 13:35caristuNote Deleted: 0086648
2016-05-24 07:35alostaleStatusresolved => closed
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087517
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087518
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087519

Notes
(0086200)
hgbot   
2016-05-05 09:54   
Repository: erp/devel/pi
Changeset: 7cb0220888a9e411984d8f7bc26c863456219dd9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:31:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7cb0220888a9e411984d8f7bc26c863456219dd9 [^]

related to bug 32838: Cannot export CSV from Widgets

  Replcaed "magic numbers" with constant to get tabId param value

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0086201)
hgbot   
2016-05-05 09:55   
Repository: erp/devel/pi
Changeset: 50cfbabf4fe370d4f75bacfff17905437b9c324e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:49:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/50cfbabf4fe370d4f75bacfff17905437b9c324e [^]

fixed bug 32838: Cannot export CSV from Widgets

  NPE was thrown when trying to export CSV from widgets because a refactor on
  that area of code changed sent value for tabId from null to undefined.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0086202)
hgbot   
2016-05-05 09:55   
Repository: erp/devel/pi
Changeset: 385262689f5ebb0a683b178afefa439e8b5237e9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 09:53:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/385262689f5ebb0a683b178afefa439e8b5237e9 [^]

related to bug 32838: using JsonUtils.isValueEmpty
  to remove some code duplicities

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0086216)
caristu   
2016-05-05 13:49   
Code review + testing OK on pi@385262689f5e
(0087517)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087518)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087519)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test