Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032558
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-03-30 13:212016-04-26 13:29
ReporterageteView Statuspublic 
Assigned Tomario_castello 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision26875b0b6fad
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032558: [SERQA 859] Do not allow to add quantity 0 in a line returned

DescriptionMaking a verified return of a receipt, it is not possible to change the quantity of the line, just if you add qty 0, in this case the line desappears.
Steps To Reproduce1. Create a receipt with a line and pay it --> Receipt 1
2. Create a receipt
3. Select the menu option verified return and select the previous receipt
4. Select the line of the receipt and click apply
5. Click on number 0 and quantity button. The line disapears
 --> ERROR: in order to have a consistent functionality, quantity should not be changed in any case in a return. if you want to delete a line, click on the right side button "Delete"
Proposed SolutionNot to allow to change the quantity in a returned line in any case, not to allow it also with cero.
Tagsser, SER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0032481 closedRetail [SERQA 789] Return lines in verified returns cannot be deleted pressing '+' 

-  Notes
(0085492)
hgbot (developer)
2016-04-07 15:44

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 79415646f85d190fac412f21403cd2dad2437206
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Apr 05 08:26:17 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^]

Fixed issue 32558: Added validation to avoid changing the amount in return line from original

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0085493)
hgbot (developer)
2016-04-07 16:07

 Repository: tools/automation/pi-mobile
Changeset: 3f15ebf75bfb8112686ce22bea27488d74a9f889
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Apr 07 08:05:42 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3f15ebf75bfb8112686ce22bea27488d74a9f889 [^]

Related to issue 32558: Added automated test

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085770)
migueldejuana (viewer)
2016-04-20 10:04

 Instead of showing a message telling that you cannot do something is better to disable those not allowed actions.

Here you have the correct fix:

--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
@@ -1244,7 +1244,7 @@
     if (selectedLinesLength > 1) {
       for (i = 0; i < selectedLinesLength; i++) {
         product = selectedLines[i].get('product');
- if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct'))) {
+ if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct')) || selectedLines[0].get('originalOrderLineId')) {
           enableButton = false;
           break;
         }
@@ -1254,7 +1254,7 @@
       }
     } else {
       product = selectedLines[0].get('product');
- if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct'))) {
+ if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct')) || selectedLines[0].get('originalOrderLineId')) {
         enableButton = false;
       }
     }
(0085786)
hgbot (developer)
2016-04-20 17:44

 Repository: tools/automation/pi-mobile
Changeset: da4331a5c6182b7d188187e8c5ea53215286ca9c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 09:44:04 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/da4331a5c6182b7d188187e8c5ea53215286ca9c [^]

Related to issue 32558: The test has been deactivated until the fix is ready.

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085837)
hgbot (developer)
2016-04-21 15:50

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eae6500d26cdf0bfb851c867a963a62551a86e20
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 10:10:14 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eae6500d26cdf0bfb851c867a963a62551a86e20 [^]

Backed out issue 32558, changeset: 79415646f85d

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0085838)
hgbot (developer)
2016-04-21 15:54
edited on: 2016-04-21 16:19

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26875b0b6fadbde6daff4035cf84b104408b666a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 10:00:06 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26875b0b6fadbde6daff4035cf84b104408b666a [^]

Fixed issue 32558: Added validation to show quantity buttons.
if the line selected is a returned line then the quantity button is desabled to prevent modify the quantity of the line.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0085936)
hgbot (developer)
2016-04-23 17:07

 Repository: tools/automation/pi-mobile
Changeset: 54dfe4a1c482c5a269836b30da43f2a34727607d
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Apr 21 09:23:48 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/54dfe4a1c482c5a269836b30da43f2a34727607d [^]

Related to issue 32558: Added changes to automated test

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085987)
migueldejuana (viewer)
2016-04-26 13:29

 Tested and reviewed in a003f89753a6

- Issue History
Date Modified Username Field Change
2016-03-30 13:21 agete New Issue
2016-03-30 13:21 agete Assigned To => Retail
2016-03-30 13:21 agete OBNetwork customer => Yes
2016-03-30 13:21 agete Resolution time => 1460066400
2016-03-30 13:21 agete Triggers an Emergency Pack => No
2016-03-30 13:22 agete Tag Attached: ser
2016-03-30 13:22 agete Tag Attached: SER-QA
2016-03-30 13:26 Orekaria Relationship added related to 0032481
2016-03-30 13:27 Orekaria Status new => acknowledged
2016-03-30 13:27 agete Resolution time 1460066400 => 1460498400
2016-03-30 15:56 mario_castello Assigned To Retail => mario_castello
2016-03-30 15:57 mario_castello Status acknowledged => scheduled
2016-04-07 15:44 hgbot Checkin
2016-04-07 15:44 hgbot Note Added: 0085492
2016-04-07 15:44 hgbot Status scheduled => resolved
2016-04-07 15:44 hgbot Resolution open => fixed
2016-04-07 15:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^]
2016-04-07 16:07 hgbot Checkin
2016-04-07 16:07 hgbot Note Added: 0085493
2016-04-20 10:04 migueldejuana Note Added: 0085770
2016-04-20 10:04 migueldejuana Status resolved => new
2016-04-20 10:04 migueldejuana Resolution fixed => open
2016-04-20 10:52 Orekaria Status new => scheduled
2016-04-20 17:44 hgbot Checkin
2016-04-20 17:44 hgbot Note Added: 0085786
2016-04-21 15:50 hgbot Checkin
2016-04-21 15:50 hgbot Note Added: 0085837
2016-04-21 15:54 hgbot Checkin
2016-04-21 15:54 hgbot Note Added: 0085838
2016-04-21 15:54 hgbot Status scheduled => resolved
2016-04-21 15:54 hgbot Resolution open => fixed
2016-04-21 15:54 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26875b0b6fadbde6daff4035cf84b104408b666a [^]
2016-04-21 16:19 mario_castello Note Edited: 0085838 View Revisions
2016-04-23 17:07 hgbot Checkin
2016-04-23 17:07 hgbot Note Added: 0085936
2016-04-26 13:29 migueldejuana Review Assigned To => migueldejuana
2016-04-26 13:29 migueldejuana Note Added: 0085987
2016-04-26 13:29 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker