Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032558Retail ModulesWeb POSpublic2016-03-30 13:212016-04-26 13:29
Reporteragete 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032558: [SERQA 859] Do not allow to add quantity 0 in a line returned
DescriptionMaking a verified return of a receipt, it is not possible to change the quantity of the line, just if you add qty 0, in this case the line desappears.
Steps To Reproduce1. Create a receipt with a line and pay it --> Receipt 1
2. Create a receipt
3. Select the menu option verified return and select the previous receipt
4. Select the line of the receipt and click apply
5. Click on number 0 and quantity button. The line disapears
 --> ERROR: in order to have a consistent functionality, quantity should not be changed in any case in a return. if you want to delete a line, click on the right side button "Delete"
Proposed SolutionNot to allow to change the quantity in a returned line in any case, not to allow it also with cero.
Additional Information
Tagsser, SER-QA
Relationships
related to defect 0032481 closed Retail [SERQA 789] Return lines in verified returns cannot be deleted pressing '+' 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-30 13:21ageteNew Issue
2016-03-30 13:21ageteAssigned To => Retail
2016-03-30 13:21ageteResolution time => 1460066400
2016-03-30 13:21ageteTriggers an Emergency Pack => No
2016-03-30 13:22ageteTag Attached: ser
2016-03-30 13:22ageteTag Attached: SER-QA
2016-03-30 13:26OrekariaRelationship addedrelated to 0032481
2016-03-30 13:27OrekariaStatusnew => acknowledged
2016-03-30 13:27ageteResolution time1460066400 => 1460498400
2016-03-30 15:56mario_castelloAssigned ToRetail => mario_castello
2016-03-30 15:57mario_castelloStatusacknowledged => scheduled
2016-04-07 15:44hgbotCheckin
2016-04-07 15:44hgbotNote Added: 0085492
2016-04-07 15:44hgbotStatusscheduled => resolved
2016-04-07 15:44hgbotResolutionopen => fixed
2016-04-07 15:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^]
2016-04-07 16:07hgbotCheckin
2016-04-07 16:07hgbotNote Added: 0085493
2016-04-20 10:04migueldejuanaNote Added: 0085770
2016-04-20 10:04migueldejuanaStatusresolved => new
2016-04-20 10:04migueldejuanaResolutionfixed => open
2016-04-20 10:52OrekariaStatusnew => scheduled
2016-04-20 17:44hgbotCheckin
2016-04-20 17:44hgbotNote Added: 0085786
2016-04-21 15:50hgbotCheckin
2016-04-21 15:50hgbotNote Added: 0085837
2016-04-21 15:54hgbotCheckin
2016-04-21 15:54hgbotNote Added: 0085838
2016-04-21 15:54hgbotStatusscheduled => resolved
2016-04-21 15:54hgbotResolutionopen => fixed
2016-04-21 15:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26875b0b6fadbde6daff4035cf84b104408b666a [^]
2016-04-21 16:19mario_castelloNote Edited: 0085838bug_revision_view_page.php?bugnote_id=0085838#r11822
2016-04-23 17:07hgbotCheckin
2016-04-23 17:07hgbotNote Added: 0085936
2016-04-26 13:29migueldejuanaReview Assigned To => migueldejuana
2016-04-26 13:29migueldejuanaNote Added: 0085987
2016-04-26 13:29migueldejuanaStatusresolved => closed

Notes
(0085492)
hgbot   
2016-04-07 15:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 79415646f85d190fac412f21403cd2dad2437206
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Apr 05 08:26:17 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79415646f85d190fac412f21403cd2dad2437206 [^]

Fixed issue 32558: Added validation to avoid changing the amount in return line from original

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0085493)
hgbot   
2016-04-07 16:07   
Repository: tools/automation/pi-mobile
Changeset: 3f15ebf75bfb8112686ce22bea27488d74a9f889
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Apr 07 08:05:42 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3f15ebf75bfb8112686ce22bea27488d74a9f889 [^]

Related to issue 32558: Added automated test

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085770)
migueldejuana   
2016-04-20 10:04   
Instead of showing a message telling that you cannot do something is better to disable those not allowed actions.

Here you have the correct fix:

--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
@@ -1244,7 +1244,7 @@
     if (selectedLinesLength > 1) {
       for (i = 0; i < selectedLinesLength; i++) {
         product = selectedLines[i].get('product');
- if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct'))) {
+ if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct')) || selectedLines[0].get('originalOrderLineId')) {
           enableButton = false;
           break;
         }
@@ -1254,7 +1254,7 @@
       }
     } else {
       product = selectedLines[0].get('product');
- if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct'))) {
+ if (!product.get('groupProduct') || (product.get('productType') === 'S' && product.get('isLinkedToProduct')) || selectedLines[0].get('originalOrderLineId')) {
         enableButton = false;
       }
     }
(0085786)
hgbot   
2016-04-20 17:44   
Repository: tools/automation/pi-mobile
Changeset: da4331a5c6182b7d188187e8c5ea53215286ca9c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 09:44:04 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/da4331a5c6182b7d188187e8c5ea53215286ca9c [^]

Related to issue 32558: The test has been deactivated until the fix is ready.

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085837)
hgbot   
2016-04-21 15:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eae6500d26cdf0bfb851c867a963a62551a86e20
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 10:10:14 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eae6500d26cdf0bfb851c867a963a62551a86e20 [^]

Backed out issue 32558, changeset: 79415646f85d

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0085838)
hgbot   
2016-04-21 15:54   
(edited on: 2016-04-21 16:19)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26875b0b6fadbde6daff4035cf84b104408b666a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Apr 20 10:00:06 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26875b0b6fadbde6daff4035cf84b104408b666a [^]

Fixed issue 32558: Added validation to show quantity buttons.
if the line selected is a returned line then the quantity button is desabled to prevent modify the quantity of the line.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0085936)
hgbot   
2016-04-23 17:07   
Repository: tools/automation/pi-mobile
Changeset: 54dfe4a1c482c5a269836b30da43f2a34727607d
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Apr 21 09:23:48 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/54dfe4a1c482c5a269836b30da43f2a34727607d [^]

Related to issue 32558: Added changes to automated test

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32558_VerifiedReturnsChangeQuantityLine.java
---
(0085987)
migueldejuana   
2016-04-26 13:29   
Tested and reviewed in a003f89753a6