Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0032317 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2016-02-23 13:04 | 2016-04-26 12:54 | |||
Reporter | migueldejuana | View Status | public | |||||
Assigned To | adrianromero | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 5244b4b7d7b1 | ||||
Projection | none | ETA | none | Target Version | RR16Q3 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | migueldejuana | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0032317: Ensure stable ids in docs send from WebPOS to the server | |||||||
Description | This method doesn't set entity id: createLinesForServiceProduct https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f915390c2c1f#l2.68 [^] | |||||||
Steps To Reproduce | See Description | |||||||
Proposed Solution | See patch attached | |||||||
Tags | No tags attached. | |||||||
Attached Files | issue32317.diff [^] (1,190 bytes) 2016-03-31 13:34 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0084763) hgbot (developer) 2016-03-07 11:47 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e46772a9ec39af7de4d186f4f86918aa24014047 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Fri Feb 26 12:59:07 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^] Fixes issue 0032317: Ensure stable ids in docs send from WebPOS to the server --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0084876) migueldejuana (developer) 2016-03-10 17:57 edited on: 2016-03-30 10:22 |
In OrderLoader.java: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047#l1.7 [^] Check if orderLine.getLineNo() is really needed to generate an unique id: olServiceRelation.setId(OBMOBCUtils.getUUIDbyString(orderLine.getId()+orderLine.getLineNo() + i)); The idea is to generate an unique id. getUUIDbyString method generate an UUID with the passed string but we should pass the shortest string we can. |
(0085941) hgbot (developer) 2016-04-25 09:32 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 5244b4b7d7b168a49eec09c2d1c3ef210a093fe8 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Wed Mar 30 11:17:36 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5244b4b7d7b168a49eec09c2d1c3ef210a093fe8 [^] Fixes issue 0032317: Ensure stable ids in docs send from WebPOS to the server * Removing not needed lineno parameter to calculate the service relation ID --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
(0085981) migueldejuana (developer) 2016-04-26 12:54 |
Tested and reviewed in a003f89753a6 |
Issue History | |||
Date Modified | Username | Field | Change |
2016-02-23 13:04 | migueldejuana | New Issue | |
2016-02-23 13:04 | migueldejuana | Assigned To | => aaroncalero |
2016-02-23 13:04 | migueldejuana | Triggers an Emergency Pack | => No |
2016-02-23 13:04 | migueldejuana | Relationship added | related to 0031654 |
2016-02-24 09:18 | adrianromero | Assigned To | aaroncalero => adrianromero |
2016-02-24 09:18 | adrianromero | Status | new => scheduled |
2016-02-24 09:19 | adrianromero | Review Assigned To | => migueldejuana |
2016-03-07 11:47 | hgbot | Checkin | |
2016-03-07 11:47 | hgbot | Note Added: 0084763 | |
2016-03-07 11:47 | hgbot | Status | scheduled => resolved |
2016-03-07 11:47 | hgbot | Resolution | open => fixed |
2016-03-07 11:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^] |
2016-03-10 17:57 | migueldejuana | Note Added: 0084876 | |
2016-03-10 17:57 | migueldejuana | Status | resolved => new |
2016-03-10 17:57 | migueldejuana | Resolution | fixed => open |
2016-03-30 10:22 | migueldejuana | Note Edited: 0084876 | View Revisions |
2016-03-30 10:30 | Orekaria | Status | new => scheduled |
2016-03-30 10:31 | Orekaria | Target Version | => RR16Q2 |
2016-03-30 15:01 | mtaal | Target Version | RR16Q2 => RR16Q3 |
2016-03-31 13:34 | adrianromero | File Added: issue32317.diff | |
2016-03-31 13:35 | adrianromero | Proposed Solution updated | |
2016-04-25 09:32 | hgbot | Checkin | |
2016-04-25 09:32 | hgbot | Note Added: 0085941 | |
2016-04-25 09:32 | hgbot | Status | scheduled => resolved |
2016-04-25 09:32 | hgbot | Resolution | open => fixed |
2016-04-25 09:32 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5244b4b7d7b168a49eec09c2d1c3ef210a093fe8 [^] |
2016-04-26 12:54 | migueldejuana | Note Added: 0085981 | |
2016-04-26 12:54 | migueldejuana | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |