Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032317Retail ModulesWeb POSpublic2016-02-23 13:042016-04-26 12:54
Reportermigueldejuana 
Assigned Toadrianromero 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032317: Ensure stable ids in docs send from WebPOS to the server
DescriptionThis method doesn't set entity id: createLinesForServiceProduct

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f915390c2c1f#l2.68 [^]
Steps To ReproduceSee Description
Proposed SolutionSee patch attached
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031654 closed migueldejuana Ensure stable ids in docs send from WebPOS to the server 
Attached Filesdiff issue32317.diff (1,190) 2016-03-31 13:34
https://issues.openbravo.com/file_download.php?file_id=9229&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-23 13:04migueldejuanaNew Issue
2016-02-23 13:04migueldejuanaAssigned To => aaroncalero
2016-02-23 13:04migueldejuanaTriggers an Emergency Pack => No
2016-02-23 13:04migueldejuanaRelationship addedrelated to 0031654
2016-02-24 09:18adrianromeroAssigned Toaaroncalero => adrianromero
2016-02-24 09:18adrianromeroStatusnew => scheduled
2016-02-24 09:19adrianromeroReview Assigned To => migueldejuana
2016-03-07 11:47hgbotCheckin
2016-03-07 11:47hgbotNote Added: 0084763
2016-03-07 11:47hgbotStatusscheduled => resolved
2016-03-07 11:47hgbotResolutionopen => fixed
2016-03-07 11:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^]
2016-03-10 17:57migueldejuanaNote Added: 0084876
2016-03-10 17:57migueldejuanaStatusresolved => new
2016-03-10 17:57migueldejuanaResolutionfixed => open
2016-03-30 10:22migueldejuanaNote Edited: 0084876bug_revision_view_page.php?bugnote_id=0084876#r11560
2016-03-30 10:30OrekariaStatusnew => scheduled
2016-03-30 10:31OrekariaTarget Version => RR16Q2
2016-03-30 15:01mtaalTarget VersionRR16Q2 => RR16Q3
2016-03-31 13:34adrianromeroFile Added: issue32317.diff
2016-03-31 13:35adrianromeroProposed Solution updated
2016-04-25 09:32hgbotCheckin
2016-04-25 09:32hgbotNote Added: 0085941
2016-04-25 09:32hgbotStatusscheduled => resolved
2016-04-25 09:32hgbotResolutionopen => fixed
2016-04-25 09:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5244b4b7d7b168a49eec09c2d1c3ef210a093fe8 [^]
2016-04-26 12:54migueldejuanaNote Added: 0085981
2016-04-26 12:54migueldejuanaStatusresolved => closed

Notes
(0084763)
hgbot   
2016-03-07 11:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e46772a9ec39af7de4d186f4f86918aa24014047
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 26 12:59:07 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047 [^]

Fixes issue 0032317: Ensure stable ids in docs send from WebPOS to the server

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0084876)
migueldejuana   
2016-03-10 17:57   
(edited on: 2016-03-30 10:22)
In OrderLoader.java:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e46772a9ec39af7de4d186f4f86918aa24014047#l1.7 [^]

Check if orderLine.getLineNo() is really needed to generate an unique id:

olServiceRelation.setId(OBMOBCUtils.getUUIDbyString(orderLine.getId()+orderLine.getLineNo() + i));

The idea is to generate an unique id. getUUIDbyString method generate an UUID with the passed string but we should pass the shortest string we can.
(0085941)
hgbot   
2016-04-25 09:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5244b4b7d7b168a49eec09c2d1c3ef210a093fe8
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Mar 30 11:17:36 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5244b4b7d7b168a49eec09c2d1c3ef210a093fe8 [^]

Fixes issue 0032317: Ensure stable ids in docs send from WebPOS to the server
* Removing not needed lineno parameter to calculate the service relation ID

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0085981)
migueldejuana   
2016-04-26 12:54   
Tested and reviewed in a003f89753a6