Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030384 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] 09. Financial management | trivial | N/A | 2015-07-17 09:05 | 2015-09-15 15:56 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 023d06d04ece | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | dmiguelez | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030384: Create a JUnit test for AD_ISORGINCLUDED function | |||||||
| Description | The AD_ISORGINCLUDED is going to be modified to improve its performance. Before doing this change, we need to be sure we don't enter any regression. So, it's necessary to create a JUnit test (OBBaseTest) that covers every possible scenario for this function: distinct orgs in the same branch with different levels, in different branches (not included), swapping parent/child order, mixing with organizations of different clients, passing the same organization, organization id that doesn't exist, etc. The test should be included in src-test folder | |||||||
| Steps To Reproduce | NA | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0079029) shuehner (administrator) 2015-07-22 14:45 |
Note: especially for the case of 'id's that do not exist' maybe interesting to define what is intended behavior. I.e. does it matter to get exact same current behavior? Or does it not (for that case) |
|
(0080387) hgbot (developer) 2015-09-14 18:05 |
Repository: erp/devel/pi Changeset: 023d06d04ececed8a71ca546bfa150d3471f9e48 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Jul 27 15:09:29 2015 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^] Fixes Issue 30384:Junit test cases for AD_ORGISINCLUDED db function Junit test handles following cases: * Case I: Distinct Organization in the same branch with different levels. * Case II: Distinct Organization in the different branch with different levels. * Case III: Swap parent/child order * Case IV: Organization with different clients * Case V: Same Organization * Case VI: Organization that does not exists. --- A src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java --- |
|
(0080388) dmiguelez (viewer) 2015-09-14 18:08 |
Code Review + Testing Ok |
|
(0080406) hudsonbot (viewer) 2015-09-15 15:56 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/27462487da9b [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-07-17 09:05 | vmromanos | New Issue | |
| 2015-07-17 09:05 | vmromanos | Assigned To | => Triage Finance |
| 2015-07-17 09:05 | vmromanos | OBNetwork customer | => No |
| 2015-07-17 09:05 | vmromanos | Modules | => Core |
| 2015-07-17 09:05 | vmromanos | Triggers an Emergency Pack | => No |
| 2015-07-22 10:29 | AtulOpenbravo | Assigned To | Triage Finance => AtulOpenbravo |
| 2015-07-22 10:29 | AtulOpenbravo | Status | new => scheduled |
| 2015-07-22 14:45 | shuehner | Note Added: 0079029 | |
| 2015-07-22 14:45 | shuehner | Issue Monitored: shuehner | |
| 2015-09-14 18:05 | hgbot | Checkin | |
| 2015-09-14 18:05 | hgbot | Note Added: 0080387 | |
| 2015-09-14 18:05 | hgbot | Status | scheduled => resolved |
| 2015-09-14 18:05 | hgbot | Resolution | open => fixed |
| 2015-09-14 18:05 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/023d06d04ececed8a71ca546bfa150d3471f9e48 [^] |
| 2015-09-14 18:08 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-09-14 18:08 | dmiguelez | Note Added: 0080388 | |
| 2015-09-14 18:08 | dmiguelez | Status | resolved => closed |
| 2015-09-15 15:56 | hudsonbot | Checkin | |
| 2015-09-15 15:56 | hudsonbot | Note Added: 0080406 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |