Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0029426 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2015-03-26 11:29 | 2015-03-27 02:12 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR15Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 54218273885c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0029426: unneeded param in callback for client side validation of process definition | |||||||
| Description | Client side validation function for Process definition must invoke actionHandlerCall with a view parameter. This view parameter is useless because: * It should always be the same value as the view received by the validation process, invoking with another value has no sense * Caller has access to that view, so no need to receive it back * New clientSideValidationFail function which is also passed to client validation does not receive this parameter, so for consistency, it is better to be both homogeneous. Note this is not an API change because even if client side validation function is not modified and continues sending back the view, it will be just ignored. | |||||||
| Steps To Reproduce | N/A: just code clean up in doProcess function defined in ob-parameter-window-view.js | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0075993) hgbot (developer) 2015-03-26 11:43 |
Repository: erp/devel/pi Changeset: 54218273885cde18d83d448ea9111adb6b3f7200 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Mar 26 11:31:57 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/54218273885cde18d83d448ea9111adb6b3f7200 [^] fixed issue 29426: unneeded param in callback for client side validation Callback function sent to client side validation had a mandatory view paramter that required to be the same one as the received one. This paramter has been removed --- M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js M web/js/validateCostingRuleProcess.js --- |
|
(0076029) AugustoMauch (administrator) 2015-03-26 18:05 |
Code reviewed and verified in pi@9a240957107d |
|
(0076038) hudsonbot (developer) 2015-03-27 02:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-03-26 11:29 | alostale | New Issue | |
| 2015-03-26 11:29 | alostale | Assigned To | => platform |
| 2015-03-26 11:29 | alostale | Modules | => Core |
| 2015-03-26 11:29 | alostale | Triggers an Emergency Pack | => No |
| 2015-03-26 11:29 | alostale | Relationship added | related to 0029388 |
| 2015-03-26 11:32 | alostale | Status | new => scheduled |
| 2015-03-26 11:32 | alostale | Assigned To | platform => alostale |
| 2015-03-26 11:43 | hgbot | Checkin | |
| 2015-03-26 11:43 | hgbot | Note Added: 0075993 | |
| 2015-03-26 11:43 | hgbot | Status | scheduled => resolved |
| 2015-03-26 11:43 | hgbot | Resolution | open => fixed |
| 2015-03-26 11:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/54218273885cde18d83d448ea9111adb6b3f7200 [^] |
| 2015-03-26 11:54 | alostale | Review Assigned To | => alostale |
| 2015-03-26 16:26 | alostale | Review Assigned To | alostale => AugustoMauch |
| 2015-03-26 18:05 | AugustoMauch | Note Added: 0076029 | |
| 2015-03-26 18:05 | AugustoMauch | Status | resolved => closed |
| 2015-03-26 18:05 | AugustoMauch | Fixed in Version | => 3.0PR15Q2 |
| 2015-03-27 02:12 | hudsonbot | Checkin | |
| 2015-03-27 02:12 | hudsonbot | Note Added: 0076038 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |