Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029426Openbravo ERPA. Platformpublic2015-03-26 11:292015-03-27 02:12
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029426: unneeded param in callback for client side validation of process definition
DescriptionClient side validation function for Process definition must invoke actionHandlerCall with a view parameter. This view parameter is useless because:

* It should always be the same value as the view received by the validation process, invoking with another value has no sense
* Caller has access to that view, so no need to receive it back
* New clientSideValidationFail function which is also passed to client validation does not receive this parameter, so for consistency, it is better to be both homogeneous.

Note this is not an API change because even if client side validation function is not modified and continues sending back the view, it will be just ignored.
Steps To ReproduceN/A: just code clean up in doProcess function defined in ob-parameter-window-view.js
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029388 closed alostale Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-26 11:29alostaleNew Issue
2015-03-26 11:29alostaleAssigned To => platform
2015-03-26 11:29alostaleModules => Core
2015-03-26 11:29alostaleTriggers an Emergency Pack => No
2015-03-26 11:29alostaleRelationship addedrelated to 0029388
2015-03-26 11:32alostaleStatusnew => scheduled
2015-03-26 11:32alostaleAssigned Toplatform => alostale
2015-03-26 11:43hgbotCheckin
2015-03-26 11:43hgbotNote Added: 0075993
2015-03-26 11:43hgbotStatusscheduled => resolved
2015-03-26 11:43hgbotResolutionopen => fixed
2015-03-26 11:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/54218273885cde18d83d448ea9111adb6b3f7200 [^]
2015-03-26 11:54alostaleReview Assigned To => alostale
2015-03-26 16:26alostaleReview Assigned Toalostale => AugustoMauch
2015-03-26 18:05AugustoMauchNote Added: 0076029
2015-03-26 18:05AugustoMauchStatusresolved => closed
2015-03-26 18:05AugustoMauchFixed in Version => 3.0PR15Q2
2015-03-27 02:12hudsonbotCheckin
2015-03-27 02:12hudsonbotNote Added: 0076038

Notes
(0075993)
hgbot   
2015-03-26 11:43   
Repository: erp/devel/pi
Changeset: 54218273885cde18d83d448ea9111adb6b3f7200
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 26 11:31:57 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/54218273885cde18d83d448ea9111adb6b3f7200 [^]

fixed issue 29426: unneeded param in callback for client side validation

  Callback function sent to client side validation had a mandatory view paramter
  that required to be the same one as the received one.

  This paramter has been removed

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M web/js/validateCostingRuleProcess.js
---
(0076029)
AugustoMauch   
2015-03-26 18:05   
Code reviewed and verified in pi@9a240957107d
(0076038)
hudsonbot   
2015-03-27 02:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^]
Maturity status: Test