Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029066
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2015-02-25 17:392015-03-30 10:36
ReportermaiteView Statuspublic 
Assigned Toinigosanchez 
PriorityurgentResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revisiond5f34315d255
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34318
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029066: Is not possible to add new payment from transaction window when working with a role defined as "Manual"

DescriptionIs not possible to add new payment from transaction window when working with a role defined as "Manual"
Steps To Reproduce1. Access Role window and give permissions to following windows to role "FInance España": "APRM GL Item", "Credit To Use" and "Order Invoice P&E"
2. Change role to "finance españa"
3. Go to Financial Account "Cuenta de banco" and create new transaction record
4. Add payment by pressing "+" button in payment's selector and realize that following error is obtained "Error occured: org.openbravo.base.exception.OBException: java.text.ParseException: Unparseable date: "null""

NOTE: problem is not reproducible when working with an Automatic role
Proposed SolutionError is thrown in AddPaymentActionHandler, when trying to parse "payment_date" because it is null.

Notice that the handler is receiving a null value because in "OB.APRM.AddPayment.onLoad = function(view)" , view.theForm.values does not contain all required parameters (it only contains issotrx parameter, probably due to permissions access)

Maybe it is necessary to review the behaviour of existing "AddPayment" process definition when working with Manual roles, in case they face other similar problems
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0029035 closedinigosanchez Process definition containing parameters defined as "window", should automatically inherit permissions 

-  Notes
(0075682)
alostale (viewer)
2015-03-17 10:38

 The problem is caused because the role has no access to Add Payment process which is executed when the + button is clicked:

867f0e26 256258 [http-8080-6] ERROR org.openbravo.client.application.process.BaseProcessActionHandler - No access to process OBUIAPP_Process(9BED7889E1034FE68BD85D5D16857320) (name: Add Payment)
(0075684)
inigosanchez (viewer)
2015-03-17 10:47

 A workaround is add "Add payment" process in "Process Definition" of current manual role.
(0075904)
inigosanchez (viewer)
2015-03-23 21:38

 This issue has two parts to solve:

* Issue 29066 (current issue): Problem related to access to a button process from a window.

* Issue https://issues.openbravo.com/view.php?id=29035 [^] (related issue): Problem related to "Processes" that containing parameters defined as "window". They should automatically inherit permissions: AccessTableNoView
(0075905)
hgbot (developer)
2015-03-23 21:57

 Repository: erp/devel/pi
Changeset: 4cf5f22234534c489da31108db50000e196d855f
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Mar 23 21:55:29 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^]

Fixed issue 29066: Process definition should inherit permissions from window

The problem was that in some cases when a rol had access to a window, he
did not have access to the processes of the window. The problem was when a
proccess was referenced by a OBUISEL_Selector reference.

This problem happens when is controlled access process. In many cases the
windowId is null.

Now, this problem has been solved because windowId will have a value.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0075951)
hudsonbot (viewer)
2015-03-25 07:30

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc321faea34e [^]
Maturity status: Test
(0076030)
hgbot (developer)
2015-03-26 18:11

 Repository: erp/devel/pi
Changeset: d5f34315d2555747eda15ac4651dfd34442b273c
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Mar 26 18:09:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d5f34315d2555747eda15ac4651dfd34442b273c [^]

Fixed issue 29066: check to prevent unexpected future consequences

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0076047)
hudsonbot (viewer)
2015-03-27 02:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^]
Maturity status: Test
(0076117)
alostale (viewer)
2015-03-30 10:36

 code reviewed

tested following steps to reproduce

- Issue History
Date Modified Username Field Change
2015-02-25 17:39 maite New Issue
2015-02-25 17:39 maite Assigned To => AugustoMauch
2015-02-25 17:39 maite OBNetwork customer => Yes
2015-02-25 17:39 maite Modules => Core
2015-02-25 17:39 maite Support ticket => 34318
2015-02-25 17:39 maite Resolution time => 1427065200
2015-02-25 17:39 maite Triggers an Emergency Pack => No
2015-02-25 17:39 maite Relationship added related to 0029035
2015-02-25 17:39 maite Issue Monitored: networkb
2015-03-06 09:18 alostale Status new => acknowledged
2015-03-11 10:54 inigosanchez Assigned To AugustoMauch => inigosanchez
2015-03-11 10:54 inigosanchez Status acknowledged => scheduled
2015-03-17 10:38 alostale Note Added: 0075682
2015-03-17 10:47 inigosanchez Note Added: 0075684
2015-03-23 21:38 inigosanchez Note Added: 0075904
2015-03-23 21:56 inigosanchez Review Assigned To => alostale
2015-03-23 21:56 inigosanchez Resolution open => fixed
2015-03-23 21:57 hgbot Checkin
2015-03-23 21:57 hgbot Note Added: 0075905
2015-03-23 21:57 hgbot Status scheduled => resolved
2015-03-23 21:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^]
2015-03-25 07:30 hudsonbot Checkin
2015-03-25 07:30 hudsonbot Note Added: 0075951
2015-03-26 18:11 hgbot Checkin
2015-03-26 18:11 hgbot Note Added: 0076030
2015-03-26 18:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^] => http://code.openbravo.com/erp/devel/pi/rev/d5f34315d2555747eda15ac4651dfd34442b273c [^]
2015-03-27 02:12 hudsonbot Checkin
2015-03-27 02:12 hudsonbot Note Added: 0076047
2015-03-30 10:36 alostale Note Added: 0076117
2015-03-30 10:36 alostale Status resolved => closed
2015-03-30 10:36 alostale Fixed in Version => 3.0PR15Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker