Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029066Openbravo ERPA. Platformpublic2015-02-25 17:392015-03-30 10:36
Reportermaite 
Assigned Toinigosanchez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029066: Is not possible to add new payment from transaction window when working with a role defined as "Manual"
DescriptionIs not possible to add new payment from transaction window when working with a role defined as "Manual"
Steps To Reproduce1. Access Role window and give permissions to following windows to role "FInance España": "APRM GL Item", "Credit To Use" and "Order Invoice P&E"
2. Change role to "finance españa"
3. Go to Financial Account "Cuenta de banco" and create new transaction record
4. Add payment by pressing "+" button in payment's selector and realize that following error is obtained "Error occured: org.openbravo.base.exception.OBException: java.text.ParseException: Unparseable date: "null""

NOTE: problem is not reproducible when working with an Automatic role
Proposed SolutionError is thrown in AddPaymentActionHandler, when trying to parse "payment_date" because it is null.

Notice that the handler is receiving a null value because in "OB.APRM.AddPayment.onLoad = function(view)" , view.theForm.values does not contain all required parameters (it only contains issotrx parameter, probably due to permissions access)

Maybe it is necessary to review the behaviour of existing "AddPayment" process definition when working with Manual roles, in case they face other similar problems
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029035 closed inigosanchez Process definition containing parameters defined as "window", should automatically inherit permissions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-25 17:39maiteNew Issue
2015-02-25 17:39maiteAssigned To => AugustoMauch
2015-02-25 17:39maiteModules => Core
2015-02-25 17:39maiteResolution time => 1427065200
2015-02-25 17:39maiteTriggers an Emergency Pack => No
2015-02-25 17:39maiteRelationship addedrelated to 0029035
2015-02-25 17:39maiteIssue Monitored: networkb
2015-03-06 09:18alostaleStatusnew => acknowledged
2015-03-11 10:54inigosanchezAssigned ToAugustoMauch => inigosanchez
2015-03-11 10:54inigosanchezStatusacknowledged => scheduled
2015-03-17 10:38alostaleNote Added: 0075682
2015-03-17 10:47inigosanchezNote Added: 0075684
2015-03-23 21:38inigosanchezNote Added: 0075904
2015-03-23 21:56inigosanchezReview Assigned To => alostale
2015-03-23 21:56inigosanchezResolutionopen => fixed
2015-03-23 21:57hgbotCheckin
2015-03-23 21:57hgbotNote Added: 0075905
2015-03-23 21:57hgbotStatusscheduled => resolved
2015-03-23 21:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^]
2015-03-25 07:30hudsonbotCheckin
2015-03-25 07:30hudsonbotNote Added: 0075951
2015-03-26 18:11hgbotCheckin
2015-03-26 18:11hgbotNote Added: 0076030
2015-03-26 18:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^] => http://code.openbravo.com/erp/devel/pi/rev/d5f34315d2555747eda15ac4651dfd34442b273c [^]
2015-03-27 02:12hudsonbotCheckin
2015-03-27 02:12hudsonbotNote Added: 0076047
2015-03-30 10:36alostaleNote Added: 0076117
2015-03-30 10:36alostaleStatusresolved => closed
2015-03-30 10:36alostaleFixed in Version => 3.0PR15Q2

Notes
(0075682)
alostale   
2015-03-17 10:38   
The problem is caused because the role has no access to Add Payment process which is executed when the + button is clicked:

867f0e26 256258 [http-8080-6] ERROR org.openbravo.client.application.process.BaseProcessActionHandler - No access to process OBUIAPP_Process(9BED7889E1034FE68BD85D5D16857320) (name: Add Payment)
(0075684)
inigosanchez   
2015-03-17 10:47   
A workaround is add "Add payment" process in "Process Definition" of current manual role.
(0075904)
inigosanchez   
2015-03-23 21:38   
This issue has two parts to solve:

* Issue 29066 (current issue): Problem related to access to a button process from a window.

* Issue https://issues.openbravo.com/view.php?id=29035 [^] (related issue): Problem related to "Processes" that containing parameters defined as "window". They should automatically inherit permissions: AccessTableNoView
(0075905)
hgbot   
2015-03-23 21:57   
Repository: erp/devel/pi
Changeset: 4cf5f22234534c489da31108db50000e196d855f
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Mar 23 21:55:29 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4cf5f22234534c489da31108db50000e196d855f [^]

Fixed issue 29066: Process definition should inherit permissions from window

The problem was that in some cases when a rol had access to a window, he
did not have access to the processes of the window. The problem was when a
proccess was referenced by a OBUISEL_Selector reference.

This problem happens when is controlled access process. In many cases the
windowId is null.

Now, this problem has been solved because windowId will have a value.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0075951)
hudsonbot   
2015-03-25 07:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc321faea34e [^]
Maturity status: Test
(0076030)
hgbot   
2015-03-26 18:11   
Repository: erp/devel/pi
Changeset: d5f34315d2555747eda15ac4651dfd34442b273c
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Mar 26 18:09:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d5f34315d2555747eda15ac4651dfd34442b273c [^]

Fixed issue 29066: check to prevent unexpected future consequences

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0076047)
hudsonbot   
2015-03-27 02:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b8858c8b542b [^]
Maturity status: Test
(0076117)
alostale   
2015-03-30 10:36   
code reviewed

tested following steps to reproduce