Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028366
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 09. Financial managementmajorhave not tried2014-12-09 16:532016-04-26 10:34
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PrioritynormalResolutionopenFixed in Version3.0PR15Q4
StatusclosedFix in branchFixed in SCM revision8860b648abb2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toeduardo_Argal
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028366: Add new functionality to calculate taxes per product BOM

DescriptionImplement the calculation of taxes of a product defined as a bill of materials based on the taxes definition of each of the individual components of the bill of materials.
This is a requirement for product bundles where the products is sold as unit with a price, but the calculation of taxes must be done based on the individual components of the bundle.

http://wiki.openbravo.com/wiki/Projects:Taxes_per_BOM [^]
Steps To ReproduceIn description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0032265 closedaferraz Openbravo ERP [SER QA 1434] Taxes at document level are not properly calculated in some cases 
related to defect 0035429 closedaferraz Openbravo ERP Error when creating a price including taxes invoice line with empty tax in Oracle 
causes defect 0032428 closedmarkmm82 Openbravo ERP Wrong Tax Amount and Total Gross Amount in orders created by the Copy Record process if price list includes taxes 
causes defect 0032472 closedmarkmm82 Modules Purchase Invoices with Total Gross Amount of 0 created from Procurement Contract Billing Process 
causes defect 0032668 closedalostale Openbravo ERP Wrong Total Gross Amount, Total Net Amount and Tax information is obtained in order and invoices 
causes defect 0032844 closedmarkmm82 Modules Wrong total net and gross amounts when generating an invoice with the Mass Invoicing process 
causes defect 0033859 closedAtulOpenbravo Openbravo ERP Wrong Total Gross Amount in orders and invoices as the changes made in tax tab records do not recalculate it 
causes defect 0034392 closedmarkmm82 Openbravo ERP Tax are duplicated in voided Sales Invoices if the original include a basic discount. Total Gross Amount does not match 
causes defect 0035699 closedAtulOpenbravo Openbravo ERP Wrong total gross amount when reactivating an order or a invoice which includes a basic discount of 100% 

-  Notes
(0078712)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: 23ae2ba611b99fc1b54753756bd9d628f5c44e38
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Dec 09 16:54:05 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/23ae2ba611b99fc1b54753756bd9d628f5c44e38 [^]

Issue 28366. Adding new fields as per bom and bom price

---
M src-db/database/model/tables/C_TAXCATEGORY.xml
M src-db/database/model/tables/M_PRODUCT_BOM.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0078713)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: bd8d146450b2de9b3b9219108a6ecdf7e13c8e14
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Fri Dec 12 15:17:27 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bd8d146450b2de9b3b9219108a6ecdf7e13c8e14 [^]

Related to issue 28366.Modified triggers to calculate net prices and amounts.

When the order and invoice uses tax including prices it is required to
calculate the net prices and amounts based on the gross price. C_ORDERLINE_TRG
and C_INVOICELINE_BEFORE_TRG triggers modified to include this logic. New
trigger created for invoice line because it is needed to do the update in a
"BEFORE" type trigger.

---
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
A src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
---
(0078714)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: ba259f6c45edd74fdc9f8d864fab6bd16690656e
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Dec 12 17:10:53 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ba259f6c45edd74fdc9f8d864fab6bd16690656e [^]

Issue 28366. Adding new fields as per bom and bom price
Reorder of new fields definition

---
M src-db/database/model/tables/C_TAXCATEGORY.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0078715)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: cb043e89291d38f104ff6cdfc0c37336d6500a63
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Dec 12 17:11:45 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cb043e89291d38f104ff6cdfc0c37336d6500a63 [^]

Issue 28366. Removing taxes calculation in c_order_post and c_invoice_post processes

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0078716)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: e94c3c67da6936ce4740e0cebd988cfc03d37362
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Dec 15 15:16:01 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e94c3c67da6936ce4740e0cebd988cfc03d37362 [^]

Issue 28366. Implementation of bom calculation in order

---
M src-db/database/model/functions/C_ORDERLINETAX_ROUNDING.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
---
(0078717)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: 48c379e1a19d74544d23124694103e41c7676183
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Dec 15 17:39:30 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/48c379e1a19d74544d23124694103e41c7676183 [^]

Issue 28366. Implementation of bom calculation in invoice

---
M src-db/database/model/functions/C_INVOICELINETAX_ROUNDING.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0078718)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: 2d5afbd49cdf8067a2bf798712a62c6de42e9e2f
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Dec 15 17:53:14 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2d5afbd49cdf8067a2bf798712a62c6de42e9e2f [^]

Issue 28366. Removing logic that rounds order and invoice taxes if price including taxes
This is done to make the BOM products work, because for BOM products, the net calculated by the function C_GET_TAX_AMT_FROM_NET does not take into account BOM products

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
---
(0078719)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: 67abae1140d645b51c194eb84d2ca5ab69de15b7
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Dec 18 13:46:32 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67abae1140d645b51c194eb84d2ca5ab69de15b7 [^]

Issue 28366. Implementation of bom calculation in net for orders

---
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
---
(0078720)
hgbot (developer)
2015-07-08 08:54

 Repository: erp/devel/pi
Changeset: 7e24e339184960fae0d1a304f63cf11f9dd24aee
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Dec 18 14:53:17 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7e24e339184960fae0d1a304f63cf11f9dd24aee [^]

Issue 28366. Implementation of bom calculation in net for invoices

---
M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
---
(0078721)
hgbot (developer)
2015-07-08 08:55

 Repository: erp/devel/pi
Changeset: 132fb37a6c25edf69060c5ab2840ee882a7b9bd0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Dec 18 20:01:25 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/132fb37a6c25edf69060c5ab2840ee882a7b9bd0 [^]

Issue 28366. Calculating warehouse for invoices

---
M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
(0078723)
hgbot (developer)
2015-07-08 08:55

 Repository: erp/devel/pi
Changeset: 846f97c041b3cd6fe3cb58413521902639728239
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Jan 16 09:58:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/846f97c041b3cd6fe3cb58413521902639728239 [^]

Backed out changeset 2d5afbd49cdf. Issue 28366. Removing logic that rounds order and invoice taxes if price including taxes.

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
---
(0078724)
hgbot (developer)
2015-07-08 08:55

 Repository: erp/devel/pi
Changeset: dc6cee2e3e2d2143fdaca2b3d471d3733303e830
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Jan 16 16:11:31 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dc6cee2e3e2d2143fdaca2b3d471d3733303e830 [^]

Issue 28366: Removing rounding logic at the end of invoice line tax trigger.
This rounding logic is already implemented in the invoice line trigger and also the order logic counterpart does not exist.

---
M src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml
---
(0078725)
hgbot (developer)
2015-07-08 08:55

 Repository: erp/devel/pi
Changeset: 5d2ff783338de03cd18e6050473f60b7264b7fd8
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Jan 22 13:47:04 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5d2ff783338de03cd18e6050473f60b7264b7fd8 [^]

Issue 28366: removing net calculation in M_PROMOTION_CALCULATE
Net is calculated in invoice line and order line triggers

---
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
---
(0078887)
adrianromero (manager)
2015-07-16 14:03

 author Adrián Romero <adrianromero@openbravo.com>
Thu Jul 16 09:31:09 2015 +0200 (4 hours ago)
changeset 27136 8860b648abb2
parent 27135 8578a3f9632c
child 27137 07d1c9787148
BOM Taxes project
This commit contains all the BOM Taxes project that implements the calculation of taxes for BOM products

https://code.openbravo.com/erp/devel/pi/rev/8860b648abb2 [^]


referencedata/sampledata/QA_Testing/C_INVOICE.xml
referencedata/sampledata/QA_Testing/C_INVOICELINE.xml
referencedata/sampledata/QA_Testing/C_TAX.xml
referencedata/sampledata/QA_Testing/C_TAXCATEGORY.xml
referencedata/sampledata/QA_Testing/C_TAXCATEGORY_TRL.xml
referencedata/sampledata/QA_Testing/C_TAX_ACCT.xml
referencedata/sampledata/QA_Testing/C_TAX_TRL.xml
referencedata/sampledata/QA_Testing/M_PRICELIST.xml
referencedata/sampledata/QA_Testing/M_PRICELIST_VERSION.xml
referencedata/sampledata/QA_Testing/M_PRODUCT.xml
referencedata/sampledata/QA_Testing/M_PRODUCTPRICE.xml
referencedata/sampledata/QA_Testing/M_PRODUCT_ACCT.xml
referencedata/sampledata/QA_Testing/M_PRODUCT_BOM.xml
src-db/database/model/functions/C_INVOICELINETAX_ROUNDING.xml
src-db/database/model/functions/C_INVOICELINETAX_ROUNDING_AMT.xml
src-db/database/model/functions/C_INVOICETAX_ROUNDING.xml
src-db/database/model/functions/C_INVOICE_POST.xml
src-db/database/model/functions/C_ORDERLINETAX_ROUNDING.xml
src-db/database/model/functions/C_ORDERLINETAX_ROUNDING_AMT.xml
src-db/database/model/functions/C_ORDERTAX_ROUNDING.xml
src-db/database/model/functions/C_ORDER_POST1.xml
src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
src-db/database/model/tables/C_TAXCATEGORY.xml
src-db/database/model/tables/M_PRODUCT_BOM.xml
src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml
src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
src-db/database/model/triggers/C_ORDERLINE_TRG.xml
src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-test/src/org/openbravo/test/AllAntTaskTests.java
src-test/src/org/openbravo/test/costing/TestCosting.java
src-test/src/org/openbravo/test/taxes/TaxesTest.java
src-test/src/org/openbravo/test/taxes/data/BPartnerDataConstants.java
src-test/src/org/openbravo/test/taxes/data/ProductDataConstants.java
src-test/src/org/openbravo/test/taxes/data/TaxDataConstants.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData1.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData10.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData11.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData12.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData13.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData14.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData15.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData16.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData17.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData18.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData19.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData2.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData20.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData21.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData22.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData23.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData24.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData25.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData26.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData27.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData28.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData29.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData3.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData30.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData31.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData32.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData33.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData34.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData4.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData5.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData6.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData7.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData8.java
src-test/src/org/openbravo/test/taxes/data/TaxesTestData9.java

- Issue History
Date Modified Username Field Change
2014-12-09 16:53 adrianromero New Issue
2014-12-09 16:53 adrianromero Assigned To => adrianromero
2014-12-09 16:53 adrianromero Modules => Core
2014-12-09 16:53 adrianromero Triggers an Emergency Pack => No
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078712
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078713
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078714
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078715
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078716
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078717
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078718
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078719
2015-07-08 08:54 hgbot Checkin
2015-07-08 08:54 hgbot Note Added: 0078720
2015-07-08 08:55 hgbot Checkin
2015-07-08 08:55 hgbot Note Added: 0078721
2015-07-08 08:55 hgbot Checkin
2015-07-08 08:55 hgbot Note Added: 0078723
2015-07-08 08:55 hgbot Checkin
2015-07-08 08:55 hgbot Note Added: 0078724
2015-07-08 08:55 hgbot Checkin
2015-07-08 08:55 hgbot Note Added: 0078725
2015-07-16 14:03 adrianromero Note Added: 0078887
2015-07-16 14:04 adrianromero Status new => scheduled
2015-07-16 14:05 adrianromero Review Assigned To => eduardo_Argal
2015-07-16 14:05 adrianromero Status scheduled => resolved
2015-07-16 14:05 adrianromero Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/8860b648abb2 [^]
2015-08-07 17:30 eduardo_Argal Status resolved => closed
2016-03-08 18:19 aferraz Relationship added causes 0032428
2016-03-14 19:02 ngarcia Relationship added causes 0032472
2016-04-26 08:42 alostale Relationship added causes 0032668
2016-04-26 10:34 alostale Fixed in Version => 3.0PR15Q4
2016-05-03 18:53 ngarcia Relationship added causes 0032844
2016-08-31 09:33 ngarcia Relationship added causes 0033859
2016-11-08 17:22 markmm82 Relationship added causes 0034392
2016-11-09 13:57 aferraz Relationship added related to 0032265
2017-03-06 16:46 aferraz Relationship added related to 0035429
2017-04-05 10:18 ngarcia Relationship added causes 0035699

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker