Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027506
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2014-08-29 11:082014-09-10 00:27
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionbf52a81816c6
ProjectionnoneETAnoneTarget VersionRR14Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toszapata
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027506: Stabilization: The 'pay' button should not be enabled if the order can't be payed

DescriptionStabilization: The 'pay' button should not be enabled if the order can't be payed
Steps To ReproduceLog into the WebPOS

Verify that the 'pay' button is enable even when:

- the receipt has not id:
      TestRegistry.registry('payment_paymentTabContent').enyoObject.model.get('order').get('id')
- the receipt has no product
- the receipt is deleted and a new one is shown

Verify that:
- if an old receipt is loaded, the pay button should be disabled
- if a stored layaway is loaded, the pay button should be enabled
- if a stored quotation is loaded, the pay button should be disabled
Proposed SolutionDisable the 'pay' button if the order has no 'id'

When the solution is made

Verify that loading an old receipt keeps the button disabled
Verify that layaways, multiorders, etc work properly
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0027287RR14Q4 closedOrekaria Stabilization: The 'pay' button should not be enabled by default on WebPOS load 
depends on feature request 0026894RR14Q4 closedOrekaria Stabilization: Improve the synchronization management 
blocks backport 0027431 closedRetail Sometimes the business partner is empty when the WebPOS loads 
blocks feature request 0027329 newRetail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 

-  Notes
(0069866)
Orekaria (administrator)
2014-09-01 00:32
edited on: 2014-09-01 01:23

 How to test the fix

Open an old receipt
Create a new receipt and add a product
Open a stored layaway
Create a new ticket (do not add a product
Open a stored quotation

Delete one by one each ticket
Verify that the pay button is enabled/disabled as expected


Create a new receipt
Verify that the pay button is disabled
Add a product
Verify that the pay button is enabled
Delete the product
Verify that the pay button is kept enabled (because it has id)
(0069868)
hgbot (developer)
2014-09-01 02:56

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 07afbe83e40163b674686b2d8afcdd9d9ba12a71
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 01 02:56:07 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0069869)
hgbot (developer)
2014-09-01 03:04

 Repository: tools/automation/pi-mobile
Changeset: efe62660b9bde7c69bca9d52ade4c0e7c55c8d90
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 01 03:03:45 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/efe62660b9bde7c69bca9d52ade4c0e7c55c8d90 [^]

Added test to verify the Issue 27506 fix: The pay button enables/disables depending on the receipt

---
M src-test/org/openbravo/retail/integrationtest/tests/issues/RetailIssuesTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/issues/I27506_PayButtonEnablingDisabling.java
---
(0069903)
hgbot (developer)
2014-09-02 11:58

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1422085708cdb5839c1aa243cb435cf089518e05
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 02 11:57:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information. Added bp check

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0070029)
hgbot (developer)
2014-09-08 23:50

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 08 22:57:53 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information. Better algorithm

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0070030)
hgbot (developer)
2014-09-08 23:50

 Repository: tools/automation/pi-mobile
Changeset: eefd568eee7875a65bbf10612ee4c1e4ee37789c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 08 23:03:44 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/eefd568eee7875a65bbf10612ee4c1e4ee37789c [^]

Related to issue 27506: 2 more tests have been added to verify the pay button states

---
M src-test/org/openbravo/retail/integrationtest/tests/RetailTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/PayButtonLayawayStates.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/PayButtonQuotationStates.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/RetailGeneralPayButtonTestSuite.java
---

- Issue History
Date Modified Username Field Change
2014-08-29 11:08 Orekaria New Issue
2014-08-29 11:08 Orekaria Assigned To => Orekaria
2014-08-29 11:08 Orekaria Triggers an Emergency Pack => No
2014-08-29 11:09 Orekaria Relationship added blocks 0027431
2014-08-29 11:09 Orekaria Relationship added blocks 0027329
2014-08-29 11:14 Orekaria Relationship added depends on 0027287
2014-09-01 00:25 Orekaria Summary Stabilization: The 'pay' button should not be enabled if the order has no 'id' => Stabilization: The 'pay' button should not be enabled if the order can't be payed
2014-09-01 00:25 Orekaria Description Updated View Revisions
2014-09-01 00:32 Orekaria Note Added: 0069866
2014-09-01 00:32 Orekaria Description Updated View Revisions
2014-09-01 00:32 Orekaria Steps to Reproduce Updated View Revisions
2014-09-01 01:23 Orekaria Note Edited: 0069866 View Revisions
2014-09-01 02:56 hgbot Checkin
2014-09-01 02:56 hgbot Note Added: 0069868
2014-09-01 02:56 hgbot Status new => resolved
2014-09-01 02:56 hgbot Resolution open => fixed
2014-09-01 02:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^]
2014-09-01 03:04 hgbot Checkin
2014-09-01 03:04 hgbot Note Added: 0069869
2014-09-01 10:01 Orekaria Relationship added depends on 0026894
2014-09-02 11:58 hgbot Checkin
2014-09-02 11:58 hgbot Note Added: 0069903
2014-09-02 11:58 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^]
2014-09-08 23:50 hgbot Checkin
2014-09-08 23:50 hgbot Note Added: 0070029
2014-09-08 23:50 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3 [^]
2014-09-08 23:50 hgbot Checkin
2014-09-08 23:50 hgbot Note Added: 0070030
2014-09-10 00:27 szapata Review Assigned To => szapata
2014-09-10 00:27 szapata Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker