Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027506Retail ModulesWeb POSpublic2014-08-29 11:082014-09-10 00:27
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in Version 
Merge Request Status
Review Assigned Toszapata
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027506: Stabilization: The 'pay' button should not be enabled if the order can't be payed
DescriptionStabilization: The 'pay' button should not be enabled if the order can't be payed
Steps To ReproduceLog into the WebPOS

Verify that the 'pay' button is enable even when:

- the receipt has not id:
      TestRegistry.registry('payment_paymentTabContent').enyoObject.model.get('order').get('id')
- the receipt has no product
- the receipt is deleted and a new one is shown

Verify that:
- if an old receipt is loaded, the pay button should be disabled
- if a stored layaway is loaded, the pay button should be enabled
- if a stored quotation is loaded, the pay button should be disabled
Proposed SolutionDisable the 'pay' button if the order has no 'id'

When the solution is made

Verify that loading an old receipt keeps the button disabled
Verify that layaways, multiorders, etc work properly
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0027287RR14Q4 closed Orekaria Stabilization: The 'pay' button should not be enabled by default on WebPOS load 
depends on feature request 0026894RR14Q4 closed Orekaria Stabilization: Improve the synchronization management 
blocks backport 0027431 closed Retail Sometimes the business partner is empty when the WebPOS loads 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-29 11:08OrekariaNew Issue
2014-08-29 11:08OrekariaAssigned To => Orekaria
2014-08-29 11:08OrekariaTriggers an Emergency Pack => No
2014-08-29 11:09OrekariaRelationship addedblocks 0027431
2014-08-29 11:09OrekariaRelationship addedblocks 0027329
2014-08-29 11:14OrekariaRelationship addeddepends on 0027287
2014-09-01 00:25OrekariaSummaryStabilization: The 'pay' button should not be enabled if the order has no 'id' => Stabilization: The 'pay' button should not be enabled if the order can't be payed
2014-09-01 00:25OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6504#r6504
2014-09-01 00:32OrekariaNote Added: 0069866
2014-09-01 00:32OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6505#r6505
2014-09-01 00:32OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6507#r6507
2014-09-01 01:23OrekariaNote Edited: 0069866bug_revision_view_page.php?bugnote_id=0069866#r6509
2014-09-01 02:56hgbotCheckin
2014-09-01 02:56hgbotNote Added: 0069868
2014-09-01 02:56hgbotStatusnew => resolved
2014-09-01 02:56hgbotResolutionopen => fixed
2014-09-01 02:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^]
2014-09-01 03:04hgbotCheckin
2014-09-01 03:04hgbotNote Added: 0069869
2014-09-01 10:01OrekariaRelationship addeddepends on 0026894
2014-09-02 11:58hgbotCheckin
2014-09-02 11:58hgbotNote Added: 0069903
2014-09-02 11:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^]
2014-09-08 23:50hgbotCheckin
2014-09-08 23:50hgbotNote Added: 0070029
2014-09-08 23:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3 [^]
2014-09-08 23:50hgbotCheckin
2014-09-08 23:50hgbotNote Added: 0070030
2014-09-10 00:27szapataReview Assigned To => szapata
2014-09-10 00:27szapataStatusresolved => closed

Notes
(0069866)
Orekaria   
2014-09-01 00:32   
(edited on: 2014-09-01 01:23)
How to test the fix

Open an old receipt
Create a new receipt and add a product
Open a stored layaway
Create a new ticket (do not add a product
Open a stored quotation

Delete one by one each ticket
Verify that the pay button is enabled/disabled as expected


Create a new receipt
Verify that the pay button is disabled
Add a product
Verify that the pay button is enabled
Delete the product
Verify that the pay button is kept enabled (because it has id)
(0069868)
hgbot   
2014-09-01 02:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 07afbe83e40163b674686b2d8afcdd9d9ba12a71
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 01 02:56:07 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/07afbe83e40163b674686b2d8afcdd9d9ba12a71 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0069869)
hgbot   
2014-09-01 03:04   
Repository: tools/automation/pi-mobile
Changeset: efe62660b9bde7c69bca9d52ade4c0e7c55c8d90
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 01 03:03:45 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/efe62660b9bde7c69bca9d52ade4c0e7c55c8d90 [^]

Added test to verify the Issue 27506 fix: The pay button enables/disables depending on the receipt

---
M src-test/org/openbravo/retail/integrationtest/tests/issues/RetailIssuesTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/issues/I27506_PayButtonEnablingDisabling.java
---
(0069903)
hgbot   
2014-09-02 11:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1422085708cdb5839c1aa243cb435cf089518e05
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 02 11:57:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1422085708cdb5839c1aa243cb435cf089518e05 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information. Added bp check

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0070029)
hgbot   
2014-09-08 23:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 08 22:57:53 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bf52a81816c6c0a36a80b67f5d4d9c2d6df4aab3 [^]

Fixes issue 27506: The pay button is enabled/disabled depending on the receipt information. Better algorithm

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0070030)
hgbot   
2014-09-08 23:50   
Repository: tools/automation/pi-mobile
Changeset: eefd568eee7875a65bbf10612ee4c1e4ee37789c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 08 23:03:44 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/eefd568eee7875a65bbf10612ee4c1e4ee37789c [^]

Related to issue 27506: 2 more tests have been added to verify the pay button states

---
M src-test/org/openbravo/retail/integrationtest/tests/RetailTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/PayButtonLayawayStates.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/PayButtonQuotationStates.java
A src-test/org/openbravo/retail/integrationtest/tests/general/paybutton/RetailGeneralPayButtonTestSuite.java
---