Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0026138 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | trivial | N/A | 2014-04-02 09:16 | 2014-06-05 09:00 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | shankarb | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR14Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | fee9a7256fe8 | ||||
Projection | none | ETA | none | Target Version | 3.0PR14Q3 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | alostale | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0026138: Small code clean up in HSAS | |||||||
Description | After patch to fix issue 0026095, some minor changes in HSAS are still pending: -There are two renderJR methods (lines 1197 and 1210) which body is duplicated: the one without forceRefresh param should invoke the other one. -There is a private renderJR method (line 1239) which solely calls the bigger renderJR (line 1247): private method can be completely removed changing its invocations to the bigger one | |||||||
Steps To Reproduce | - | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0067444) hgbot (developer) 2014-05-26 12:54 |
Repository: erp/devel/pi Changeset: fee9a7256fe8337582284d5d594b336bb79b80d0 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Mon May 26 13:27:53 2014 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^] Fixes Issue 26138: Small code clean up in HSAS Removed unneeded private method. Removed duplicate code. --- M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java --- |
(0067497) hudsonbot (developer) 2014-05-27 23:09 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/15bdf44a37ae [^] Maturity status: Test |
(0067770) alostale (manager) 2014-06-05 09:00 |
code reviewed |
Issue History | |||
Date Modified | Username | Field | Change |
2014-04-02 09:16 | alostale | New Issue | |
2014-04-02 09:16 | alostale | Assigned To | => shankarb |
2014-04-02 09:16 | alostale | Modules | => Core |
2014-04-02 09:16 | alostale | Triggers an Emergency Pack | => No |
2014-04-02 09:16 | alostale | Relationship added | related to 0026095 |
2014-05-26 05:44 | shankarb | Status | new => scheduled |
2014-05-26 05:44 | shankarb | fix_in_branch | => pi |
2014-05-26 12:43 | shankarb | Review Assigned To | => alostale |
2014-05-26 12:43 | shankarb | fix_in_branch | pi => |
2014-05-26 12:54 | hgbot | Checkin | |
2014-05-26 12:54 | hgbot | Note Added: 0067444 | |
2014-05-26 12:54 | hgbot | Status | scheduled => resolved |
2014-05-26 12:54 | hgbot | Resolution | open => fixed |
2014-05-26 12:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^] |
2014-05-27 23:09 | hudsonbot | Checkin | |
2014-05-27 23:09 | hudsonbot | Note Added: 0067497 | |
2014-06-05 09:00 | alostale | Note Added: 0067770 | |
2014-06-05 09:00 | alostale | Status | resolved => closed |
2014-06-05 09:00 | alostale | Fixed in Version | => PR14Q3 |
Copyright © 2000 - 2009 MantisBT Group |