Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024319
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminoralways2013-07-11 17:172017-02-15 09:12
ReportermaiteView Statuspublic 
Assigned Toinigosanchez 
PriorityhighResolutionfixedFixed in Version3.0PR16Q1
StatusclosedFix in branchFixed in SCM revision9f99e60411fc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024319: Grid mode should hide field content as per display logic rule

DescriptionGrid mode should hide field content as per display logic rule. System should not show (nor allow editing) values for these non-displayed fields in grid view
Steps To Reproduce1. Access Client window and Dimensions tab and configure "Business Partner" dimension as Not Showed in Lines for GL Journal document
2. Logout and login again
3. Access GL Journal window and create any record, add any header and add any line. Realize that you are not able to fill "Business Partner" data in form view but if you change to grid view and show Business Partner column you are able to see and edit it.
Proposed SolutionImplemented as a project: http://wiki.openbravo.com/wiki/Projects:Grid_Display_Logic_as_Read_Only [^]

Finally, the implementation consists in applying read only logic for fields with display logic when they are visualized in grid view.
TagsRoadMapAccelerator
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0017650 newTriage Platform Base It should be possible to not show a column in grid, and don't let the user to show it 
related to design defect 0017689 acknowledgedTriage Platform Base Display logic is not preventing a field to be edited in grid view 
related to feature request 0018483 newTriage Platform Base Display logic is not preventing a field to be edited in grid view 
related to feature request 0011391 newiciordia When Displaylogic is false and Show in Grid View selected, appears on the Grid view 
related to defect 0030868 closednonofrancisco Is possible to post transaction with accounting dimension information not enabled at client level 
related to defect 0031627 closedinigosanchez Fields with display logic equals to false cause js check error in log 
blocks defect 0030097 feedbackngarcia Financial Account Transaction status before processing is Awaiting Payment although a payment is already selected 
blocks defect 0032620 closedTriage Omni OMS Using price not including taxes, "Gross Unit Price" & "Line Gross Amount" are always set at "0.00" in "Lines" tab 
causes defect 0032240 closedinigosanchez Read only logic doesn't work on some columns in grid view 

-  Notes
(0062280)
alostale (manager)
2013-11-20 10:42

 When designing this we need to evaluate performance: display logic needs to be evaluated for each record in client-side, note display logic can require to take into account not only the fields within the record but also auxiliary inputs, in which case extra queries for each record would be required.
(0073293)
umartirena (reporter)
2015-01-02 14:12

 It would be nice to implement something at least similar to the functionality that currently exists for parameter windows grids, the "Display Logic for Grid Column", based session values, header values, that affects in the same way to all records of the grid.
(0082094)
alostale (manager)
2015-11-23 13:49

 In addition to test cases described in test, also tested:


Preferecens > Client - Editable field, not editable column (can be edited only on new)

Field | Read only logic | Display logic
--------------------------------------------+---------------------------------------------+---------------
Preference > Preference> Attribute | @Inherited_From@!null & @Inherited_From@!'' | @IsPropertyList@='N'
Role > Role > Template | | @IsManual@='Y'
Role > Window Access > Active | @Inherited_From@!null & @Inherited_From@!'' |
(0082095)
hgbot (developer)
2015-11-23 14:01

 Repository: erp/devel/pi
Changeset: 9f99e60411fcba42b78da7923bca7465ae71aa09
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Nov 23 13:59:26 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]

Fixed issue 24319: Merge Grid Display Logic

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-pick-and-execute-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-form.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0082273)
hudsonbot (developer)
2015-11-23 21:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082469)
alostale (manager)
2015-11-30 11:07

 code reviewed and tested withing project [1]

[1] http://wiki.openbravo.com/wiki/Projects:Grid_Display_Logic_as_Read_Only [^]
(0094342)
hgbot (developer)
2017-02-15 09:11

 Repository: tools/automation/int
Changeset: b63f1d4d60f17ace0fa72695e4761133a8798782
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Jan 04 10:34:20 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/b63f1d4d60f17ace0fa72695e4761133a8798782 [^]

Add automated tests for issue 24319 into a test suites

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/FormSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/build.xml
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GridSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/build.xml
---
(0094344)
hgbot (developer)
2017-02-15 09:11

 Repository: tools/automation/int
Changeset: b2323db83cf974c5cd576760115853f584799697
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 08 16:45:43 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/b2323db83cf974c5cd576760115853f584799697 [^]

Related with issue 24319: Test GDLb010 updated to use existing infrastructure.

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/GDLb010_DisplayLogicInForm.java
A src-test/com/openbravo/test/integration/erp/data/financial/assets/assets/AssetsDisplayLogic.java
---
(0094345)
hgbot (developer)
2017-02-15 09:12

 Repository: tools/automation/int
Changeset: 511e278ad99cfb4769e483864c71cfa1f24a7f3d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 08 16:39:50 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/511e278ad99cfb4769e483864c71cfa1f24a7f3d [^]

Related with issue 24319: Automated test for Grid Display Logic project.

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GDLa010_DisplayLogicInGrid.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GDLa020_DisplayLogicAndShowColumns.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GridSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/build.xml
---

- Issue History
Date Modified Username Field Change
2013-07-11 17:17 maite New Issue
2013-07-11 17:17 maite Assigned To => dmiguelez
2013-07-11 17:17 maite Modules => Core
2013-07-11 17:17 maite Triggers an Emergency Pack => No
2013-07-11 17:18 maite Issue Monitored: networkb
2013-07-12 10:45 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2013-08-19 16:46 jonalegriaesarte Target Version 3.0MP27 => 3.0MP28
2013-09-16 13:19 jonalegriaesarte Target Version 3.0MP28 => 3.0MP29
2013-10-07 16:32 jonalegriaesarte Target Version 3.0MP29 => 3.0MP30
2013-10-30 10:09 egoitz Relationship added related to 0017650
2013-10-30 10:10 egoitz Assigned To jonalegriaesarte => AugustoMauch
2013-10-30 10:10 egoitz Category 09. Financial management => A. Platform
2013-10-30 10:10 egoitz Issue Monitored: egoitz
2013-11-20 10:36 iciordia Type defect => design defect
2013-11-20 10:36 iciordia Summary Should not be possible to fill in grid mode a field not displayed in form mode => Grid mode should hide field content as per display logic rule
2013-11-20 10:36 iciordia Description Updated View Revisions
2013-11-20 10:36 iciordia Steps to Reproduce Updated View Revisions
2013-11-20 10:42 alostale Note Added: 0062280
2013-11-21 15:14 jonalegriaesarte Target Version 3.0MP30 =>
2014-11-07 14:44 ngarcia Relationship added related to 0017689
2015-01-02 14:12 umartirena Note Added: 0073293
2015-06-04 16:27 ngarcia Relationship added related to 0018483
2015-06-04 16:27 ngarcia Relationship added related to 0011391
2015-06-04 17:48 ngarcia Relationship added related to 0030097
2015-07-17 12:06 vmromanos Relationship deleted related to 0030097
2015-07-17 12:06 vmromanos Relationship added blocks 0030097
2015-09-09 09:32 alostale Assigned To AugustoMauch => platform
2015-09-18 09:41 maite Relationship added related to 0030868
2015-09-18 12:10 egoitz Tag Attached: RoadMapAccelerator
2015-11-23 13:48 alostale Proposed Solution updated
2015-11-23 13:48 alostale Status new => scheduled
2015-11-23 13:48 alostale Assigned To platform => inigosanchez
2015-11-23 13:48 alostale Review Assigned To => alostale
2015-11-23 13:49 alostale Note Added: 0082094
2015-11-23 14:01 hgbot Checkin
2015-11-23 14:01 hgbot Note Added: 0082095
2015-11-23 14:01 hgbot Status scheduled => resolved
2015-11-23 14:01 hgbot Resolution open => fixed
2015-11-23 14:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]
2015-11-23 21:17 hudsonbot Checkin
2015-11-23 21:17 hudsonbot Note Added: 0082273
2015-11-30 11:07 alostale Note Added: 0082469
2015-11-30 11:07 alostale Status resolved => closed
2015-11-30 11:07 alostale Fixed in Version => 3.0PR16Q1
2015-12-01 12:16 caristu Relationship added related to 0031627
2016-02-24 09:45 inigosanchez Relationship added causes 0032240
2016-04-07 17:07 aferraz Relationship added blocks 0032620
2017-02-15 09:11 hgbot Checkin
2017-02-15 09:11 hgbot Note Added: 0094342
2017-02-15 09:11 hgbot Checkin
2017-02-15 09:11 hgbot Note Added: 0094344
2017-02-15 09:12 hgbot Checkin
2017-02-15 09:12 hgbot Note Added: 0094345

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker