Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024319Openbravo ERPA. Platformpublic2013-07-11 17:172017-02-15 09:12
Reportermaite 
Assigned Toinigosanchez 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024319: Grid mode should hide field content as per display logic rule
DescriptionGrid mode should hide field content as per display logic rule. System should not show (nor allow editing) values for these non-displayed fields in grid view
Steps To Reproduce1. Access Client window and Dimensions tab and configure "Business Partner" dimension as Not Showed in Lines for GL Journal document
2. Logout and login again
3. Access GL Journal window and create any record, add any header and add any line. Realize that you are not able to fill "Business Partner" data in form view but if you change to grid view and show Business Partner column you are able to see and edit it.
Proposed SolutionImplemented as a project: http://wiki.openbravo.com/wiki/Projects:Grid_Display_Logic_as_Read_Only [^]

Finally, the implementation consists in applying read only logic for fields with display logic when they are visualized in grid view.
Additional Information
TagsRoadMapAccelerator
Relationships
related to feature request 0017650 new Triage Platform Base It should be possible to not show a column in grid, and don't let the user to show it 
related to design defect 0017689 acknowledged Triage Platform Base Display logic is not preventing a field to be edited in grid view 
related to feature request 0018483 new Triage Platform Base Display logic is not preventing a field to be edited in grid view 
related to feature request 0011391 new iciordia When Displaylogic is false and Show in Grid View selected, appears on the Grid view 
related to defect 0030868 closed nonofrancisco Is possible to post transaction with accounting dimension information not enabled at client level 
related to defect 0031627 closed inigosanchez Fields with display logic equals to false cause js check error in log 
blocks defect 0030097 feedback ngarcia Financial Account Transaction status before processing is Awaiting Payment although a payment is already selected 
blocks defect 0032620 closed Triage Omni OMS Using price not including taxes, "Gross Unit Price" & "Line Gross Amount" are always set at "0.00" in "Lines" tab 
causes defect 0032240 closed inigosanchez Read only logic doesn't work on some columns in grid view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-07-11 17:17maiteNew Issue
2013-07-11 17:17maiteAssigned To => dmiguelez
2013-07-11 17:17maiteModules => Core
2013-07-11 17:17maiteTriggers an Emergency Pack => No
2013-07-11 17:18maiteIssue Monitored: networkb
2013-07-12 10:45dmiguelezAssigned Todmiguelez => jonalegriaesarte
2013-08-19 16:46jonalegriaesarteTarget Version3.0MP27 => 3.0MP28
2013-09-16 13:19jonalegriaesarteTarget Version3.0MP28 => 3.0MP29
2013-10-07 16:32jonalegriaesarteTarget Version3.0MP29 => 3.0MP30
2013-10-30 10:09egoitzRelationship addedrelated to 0017650
2013-10-30 10:10egoitzAssigned Tojonalegriaesarte => AugustoMauch
2013-10-30 10:10egoitzCategory09. Financial management => A. Platform
2013-10-30 10:10egoitzIssue Monitored: egoitz
2013-11-20 10:36iciordiaTypedefect => design defect
2013-11-20 10:36iciordiaSummaryShould not be possible to fill in grid mode a field not displayed in form mode => Grid mode should hide field content as per display logic rule
2013-11-20 10:36iciordiaDescription Updatedbug_revision_view_page.php?rev_id=5198#r5198
2013-11-20 10:36iciordiaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5200#r5200
2013-11-20 10:42alostaleNote Added: 0062280
2013-11-21 15:14jonalegriaesarteTarget Version3.0MP30 =>
2014-11-07 14:44ngarciaRelationship addedrelated to 0017689
2015-01-02 14:12umartirenaNote Added: 0073293
2015-06-04 16:27ngarciaRelationship addedrelated to 0018483
2015-06-04 16:27ngarciaRelationship addedrelated to 0011391
2015-06-04 17:48ngarciaRelationship addedrelated to 0030097
2015-07-17 12:06vmromanosRelationship deletedrelated to 0030097
2015-07-17 12:06vmromanosRelationship addedblocks 0030097
2015-09-09 09:32alostaleAssigned ToAugustoMauch => platform
2015-09-18 09:41maiteRelationship addedrelated to 0030868
2015-09-18 12:10egoitzTag Attached: RoadMapAccelerator
2015-11-23 13:48alostaleProposed Solution updated
2015-11-23 13:48alostaleStatusnew => scheduled
2015-11-23 13:48alostaleAssigned Toplatform => inigosanchez
2015-11-23 13:48alostaleReview Assigned To => alostale
2015-11-23 13:49alostaleNote Added: 0082094
2015-11-23 14:01hgbotCheckin
2015-11-23 14:01hgbotNote Added: 0082095
2015-11-23 14:01hgbotStatusscheduled => resolved
2015-11-23 14:01hgbotResolutionopen => fixed
2015-11-23 14:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082273
2015-11-30 11:07alostaleNote Added: 0082469
2015-11-30 11:07alostaleStatusresolved => closed
2015-11-30 11:07alostaleFixed in Version => 3.0PR16Q1
2015-12-01 12:16caristuRelationship addedrelated to 0031627
2016-02-24 09:45inigosanchezRelationship addedcauses 0032240
2016-04-07 17:07aferrazRelationship addedblocks 0032620
2017-02-15 09:11hgbotCheckin
2017-02-15 09:11hgbotNote Added: 0094342
2017-02-15 09:11hgbotCheckin
2017-02-15 09:11hgbotNote Added: 0094344
2017-02-15 09:12hgbotCheckin
2017-02-15 09:12hgbotNote Added: 0094345

Notes
(0062280)
alostale   
2013-11-20 10:42   
When designing this we need to evaluate performance: display logic needs to be evaluated for each record in client-side, note display logic can require to take into account not only the fields within the record but also auxiliary inputs, in which case extra queries for each record would be required.
(0073293)
umartirena   
2015-01-02 14:12   
It would be nice to implement something at least similar to the functionality that currently exists for parameter windows grids, the "Display Logic for Grid Column", based session values, header values, that affects in the same way to all records of the grid.
(0082094)
alostale   
2015-11-23 13:49   
In addition to test cases described in test, also tested:


Preferecens > Client - Editable field, not editable column (can be edited only on new)

Field | Read only logic | Display logic
--------------------------------------------+---------------------------------------------+---------------
Preference > Preference> Attribute | @Inherited_From@!null & @Inherited_From@!'' | @IsPropertyList@='N'
Role > Role > Template | | @IsManual@='Y'
Role > Window Access > Active | @Inherited_From@!null & @Inherited_From@!'' |
(0082095)
hgbot   
2015-11-23 14:01   
Repository: erp/devel/pi
Changeset: 9f99e60411fcba42b78da7923bca7465ae71aa09
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Nov 23 13:59:26 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]

Fixed issue 24319: Merge Grid Display Logic

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-pick-and-execute-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-form.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0082273)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082469)
alostale   
2015-11-30 11:07   
code reviewed and tested withing project [1]

[1] http://wiki.openbravo.com/wiki/Projects:Grid_Display_Logic_as_Read_Only [^]
(0094342)
hgbot   
2017-02-15 09:11   
Repository: tools/automation/int
Changeset: b63f1d4d60f17ace0fa72695e4761133a8798782
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Jan 04 10:34:20 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/b63f1d4d60f17ace0fa72695e4761133a8798782 [^]

Add automated tests for issue 24319 into a test suites

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/FormSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/build.xml
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GridSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/build.xml
---
(0094344)
hgbot   
2017-02-15 09:11   
Repository: tools/automation/int
Changeset: b2323db83cf974c5cd576760115853f584799697
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 08 16:45:43 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/b2323db83cf974c5cd576760115853f584799697 [^]

Related with issue 24319: Test GDLb010 updated to use existing infrastructure.

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/form/GDLb010_DisplayLogicInForm.java
A src-test/com/openbravo/test/integration/erp/data/financial/assets/assets/AssetsDisplayLogic.java
---
(0094345)
hgbot   
2017-02-15 09:12   
Repository: tools/automation/int
Changeset: 511e278ad99cfb4769e483864c71cfa1f24a7f3d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 08 16:39:50 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/511e278ad99cfb4769e483864c71cfa1f24a7f3d [^]

Related with issue 24319: Automated test for Grid Display Logic project.

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GDLa010_DisplayLogicInGrid.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GDLa020_DisplayLogicAndShowColumns.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GridSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/build.xml
---