0009971: Manufacturing calculates quantity incorrectly when we have 2 sales orders exactly the same

Description

When we create two sales orders for the same manufactured product with the same delivery date no work requirement will be suggested for the second order.

Steps To Reproduce

Just to make things simple.
Product: some manufactured product; lets call it "Truck".
Safety stock=0 ; Minimum quantity=0 ; Quantity on hand=0 ; Capacity=0 ;
Pending purchases orders=0

1)Create two sales order, with the same delivery date and customer, for 500 units of "Truck"
2)Create manufacturing plan
2.1)Observe that one of the sales order will have a suggested work requirement of zero! Even though, there is no stock available for product "Truck".
So we have a total of 1000 units of "Truck" ordered but only 500 units are suggested as work requirements.
3)It should suggest two work requirements of 500 units each.

Proposed Solution

I've attached the original Postgres mrp_processplan_plan function and the new version.
I've tracked down the bug to function mrp_processplan_plan. The original version puts the sales order data after the work requirements data thus giving an incorrect stock value. All changes to the stock level should be process before the work requirements changes...

I've same some tests (see table below) and it seems to working just fine.
However the development has the full requirements so they can test it more thoroughly.

Safety Minimum Order1 Order2
Stock quantity QOH Quant. Quant. TestResult
0 0 0 600 600 Ok
10 700 0 600 600 Ok
10 1210 0 600 600 Ok
0 0 500 600 600 Ok

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0008439

closed

gorkaion

Manufacturing calculates quantity incorrectly when we have 2 sales orders exactly the same

Notes
(0018816) rafaroda (developer) 2009-08-04 10:38	Apply same solution as in https://issues.openbravo.com/view.php?id=8583#bugnotes [^]

(0018925) rafaroda (developer) 2009-08-12 13:03	This issue will not be resolved in 2.3x branch. It has been already resolved in 2.40 [1] and pi [2] branches. [1] https://issues.openbravo.com/view.php?id=8583#bugnotes [^] [2] https://issues.openbravo.com/view.php?id=8439#bugnotes [^]

Issue History
Date Modified	Username	Field	Change
2009-07-20 20:17	rafaroda	New Issue
2009-07-20 20:17	rafaroda	Assigned To	=> rafaroda
2009-07-20 20:17	rafaroda	Issue generated from	0008439
2009-07-20 20:17	rafaroda	Relationship added	blocks 0008439
2009-07-20 20:17	rafaroda	Reporter	rafaroda => networkb
2009-07-20 20:17	rafaroda	Status	new => scheduled
2009-07-20 20:18	rafaroda	fix_in_branch	=> 2.3x
2009-07-28 06:52	pjuvara	Target Version	=> 2.50MP4
2009-08-04 09:31	rafaroda	Priority	immediate => urgent
2009-08-04 10:38	rafaroda	Note Added: 0018816
2009-08-12 13:03	rafaroda	Status	scheduled => closed
2009-08-12 13:03	rafaroda	Note Added: 0018925
2009-08-12 13:03	rafaroda	Resolution	open => no change required