Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0009781
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] E. Translationminoralways2009-07-06 23:122009-10-20 00:00
ReporternetworkbView Statuspublic 
Assigned Tovmromanos 
PriorityurgentResolutionfixedFixed in Version2.50MP7
StatusclosedFix in branchpiFixed in SCM revisioncacae5939095
ProjectionnoneETA> 1 monthTarget Version2.50MP4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP1SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009781: There are some incorrect translations in Spanish translation (I)

DescriptionThere are some incorrect translations in Spanish translation module i.e:

1. Lot of error messages are in english (i.e ERROR: duplicate key value violates unique constraint "c_bpartner_value")
Steps To ReproduceThere are some incorrect translations in Spanish translation module i.e:

1. Lot of error messages are in english (i.e ERROR: duplicate key value violates unique constraint "c_bpartner_value")
- Go to Master data management > Business Partner. Create a new record with the same Search key than other existing record.
TagsNo tags attached.
Attached Filespng file icon Dibujo.PNG [^] (152,217 bytes) 2009-09-21 13:00

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0004601 closedshuehner Provide way for translated db-error messages without need for hundres mostly-identical translation entries 
related to defect 0010307 closedshuehner ErrorMessage translation for database check-constraints which are not boolean checks always returns "zero" 
related to defect 0009384 closedshuehner Poor error message inserting a duplicated search key for business partners 
related to defect 0008574 closedshuehner Error message for displaying the duplicate key of the business partner category should be user friendly 

-  Notes
(0018050)
vmromanos (manager)
2009-07-09 11:49

 The cause of this bug is that we don't have a message in the AD_Message table for the "c_bpartner_value" constraint. This is very easy to fix for this constraint, but the problem is that fixing for all the constraints which don't have an AD_Message record is a very long task. Moreover, after creating a new record per constraint, we must translated them into Spanish.

There is a feature request 0004601 that should be very useful in this case, because it will allow us to show a generic message for all of this constraint's messages
(0019015)
hgbot (developer)
2009-08-18 21:09

 Repository: erp/devel/pi
Changeset: 5ae80880d76ec122b7942522ce97148749ff5cd8
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Aug 17 16:33:26 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5ae80880d76ec122b7942522ce97148749ff5cd8 [^]

Issue 9781: Centralize common ErrorTextParser selects into new shared file, remove afterwards empty postgres verion

---
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
A src/org/openbravo/erpCommon/utility/ErrorTextParser_data.xsql
R src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE_data.xsql
---
(0019016)
hgbot (developer)
2009-08-18 21:09

 Repository: erp/devel/pi
Changeset: 5d8fa9bf1b30ba411f7b97c3e6b5ed4a4b20cb06
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Aug 17 16:56:58 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5d8fa9bf1b30ba411f7b97c3e6b5ed4a4b20cb06 [^]

Issue 9781: introduce new method handleConstraintViolation to be shared among the different dbms
- move lookup of message by constraint name to shared method

---
M src/org/openbravo/erpCommon/utility/ErrorTextParser.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---
(0019018)
hgbot (developer)
2009-08-18 21:09

 Repository: erp/devel/pi
Changeset: a7c9b84fa332ecb207ec0b806eb322402addcb28
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Aug 17 17:23:00 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a7c9b84fa332ecb207ec0b806eb322402addcb28 [^]

Issue 9781: Move more common constraint violation error parsing code to generic class

---
M src/org/openbravo/erpCommon/utility/ErrorTextParser.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---
(0019019)
hgbot (developer)
2009-08-18 21:09

 Repository: erp/devel/pi
Changeset: 7a3fbbcba4f1f3f2395ccaabbed477dadf7288fa
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 18 15:50:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7a3fbbcba4f1f3f2395ccaabbed477dadf7288fa [^]

Issue 9781: Add another new version of parseTranslation function, which can use a Map to retrieve the translation value
- to be used by a later commit to more flexibly replace tokens in the database ErrorTextParser code

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0019020)
hgbot (developer)
2009-08-18 21:09

 Repository: erp/devel/pi
Changeset: 2e8a99f92b61cf1f425836c43bd904dbd7af6343
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 18 21:07:08 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2e8a99f92b61cf1f425836c43bd904dbd7af6343 [^]

Issue 9781: Implement common translatable, auto-generated ErrorMessages for most constraint violations, if no specific error message is active for a specific constraint.
This changes adds generic/translatable ErrorMessages for the following cases:
- Duplicate primary key/uuid
- Unique constraints
- Check Constraints (not null, oracle only)
- Check Constraints (boolean checks)
- Foreign keys (same error message on insert/update and delete)
- Generic message about constraint violation for other checks constrainst not covered by these

New entries to be translated in AD_MESSAGE:
- ForeignKeyViolation, UniqueConstraintViolation, DuplicatePrimaryKey, NotNullError, NotYNError, UnspecifiedConstraintViolation

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/utility/ErrorTextParser.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE.java
M src/org/openbravo/erpCommon/utility/ErrorTextParserORACLE_data.xsql
M src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
M src/org/openbravo/erpCommon/utility/ErrorTextParser_data.xsql
---
(0019383)
vmromanos (manager)
2009-09-01 19:09

 Fixed in the Spanish Translation module version 1.0.3
(0020236)
psarobe (manager)
2009-09-21 12:59
edited on: 2009-09-21 13:00

 This issue is not fixed properly. The message is not clear for end users and there is still left some words in English

See attach Dibujo.PNG
(0020237)
vmromanos (manager)
2009-09-21 13:07

 @Pablo:
The word in English is the Java class name used by DAL and, we cannot translate all the Java class names of the application into Spanish.

What we can do is to change the message to use the table name instead, i.e: "a record in the table: TABLE_NAME ....".

We can also discuss about which are the constraints that should have a personalized message and add them into the AD_Message table (feature request).

Stefan, what do you think?
(0020238)
shuehner (administrator)
2009-09-21 13:20

 @Pablo:

For unclear message i am open to any suggestion, which will work with all available constraint, as this message is autogenerated.

@vmromanos:
I chose the dal classname a is the most clear value we have in the application referring to a table.
How does replacing it by c_bpartner make it more clear? Or help us with the translation? Currently we don't have a translation for names (classname,db table-name) as far a i know (not directly and not via ad_element). So if this is strictly required we need to add translation infrastructure to the aplication for tablenames and add translated names for the about 450 tables we have in the system.

Independently choosing a manually written message for a constraint is always possible and just adding it to ad_message uses it.. but this does not solve the general problem.
(0020986)
hgbot (developer)
2009-10-13 15:07

 Repository: erp/devel/pi
Changeset: 61fda85efacfc968daae6b6b188209a18bd39d3a
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Oct 13 15:06:28 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/61fda85efacfc968daae6b6b188209a18bd39d3a [^]

Issue 9781: Enhance UniqueConstraint error message generation
- also translate table name via its primary key entry in ad_element
- Enhance some ad_element entries with better human readable names

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/utility/ErrorTextParser.java
M src/org/openbravo/erpCommon/utility/ErrorTextParser_data.xsql
---
(0020987)
hgbot (developer)
2009-10-13 15:16

 Repository: erp/devel/pi
Changeset: cacae59390952c7fd5a86e1035c98bdc492dae94
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Oct 13 15:16:37 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cacae59390952c7fd5a86e1035c98bdc492dae94 [^]

Issue 9781: Use better error message text for boolean constraint checks

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0021063)
shuehner (administrator)
2009-10-15 15:20

 Reassigning to localization. This issue is only waiting for an updated spanish translation obx now.
(0021083)
vmromanos (manager)
2009-10-15 18:25

 Fixed in the Spanish Translation Module version 1.0.4, available at the Central Repository or at http://forge.openbravo.com/plugins/module/index.php?group_id=172 [^]
(0021144)
arunkumar (reporter)
2009-10-19 08:39

 While displaying the error message when adding a business partner with already existing search key, the error message does not have any english words.Please refer the attached screenshot(spanishtranslation.jpg).
Tested & Working fine.

- Issue History
Date Modified Username Field Change
2009-07-06 23:12 networkb New Issue
2009-07-06 23:12 networkb Assigned To => rafaroda
2009-07-08 09:03 rafaroda Assigned To rafaroda => vmromanos
2009-07-09 11:49 vmromanos Note Added: 0018050
2009-07-09 11:49 vmromanos Assigned To vmromanos => pjuvara
2009-07-09 11:49 vmromanos Status new => feedback
2009-07-10 14:58 pjuvara Assigned To pjuvara => shuehner
2009-07-10 14:59 pjuvara Priority immediate => urgent
2009-07-10 14:59 pjuvara ETA none => > 1 month
2009-07-10 14:59 pjuvara Status feedback => new
2009-07-10 14:59 pjuvara Status new => scheduled
2009-07-10 14:59 pjuvara fix_in_branch => pi
2009-07-10 14:59 pjuvara Relationship added related to 0004601
2009-07-13 06:31 pjuvara Target Version 2.50MP1 => 2.50MP5
2009-07-13 06:31 pjuvara fix_in_branch pi =>
2009-08-12 10:42 networkb Target Version 2.50MP5 => 2.50MP4
2009-08-17 17:07 shuehner Relationship added related to 0010307
2009-08-18 21:09 hgbot Checkin
2009-08-18 21:09 hgbot Note Added: 0019015
2009-08-18 21:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5ae80880d76ec122b7942522ce97148749ff5cd8 [^]
2009-08-18 21:09 hgbot Checkin
2009-08-18 21:09 hgbot Note Added: 0019016
2009-08-18 21:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5ae80880d76ec122b7942522ce97148749ff5cd8 [^] => http://code.openbravo.com/erp/devel/pi/rev/5d8fa9bf1b30ba411f7b97c3e6b5ed4a4b20cb06 [^]
2009-08-18 21:09 hgbot Checkin
2009-08-18 21:09 hgbot Note Added: 0019018
2009-08-18 21:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5d8fa9bf1b30ba411f7b97c3e6b5ed4a4b20cb06 [^] => http://code.openbravo.com/erp/devel/pi/rev/a7c9b84fa332ecb207ec0b806eb322402addcb28 [^]
2009-08-18 21:09 hgbot Checkin
2009-08-18 21:09 hgbot Note Added: 0019019
2009-08-18 21:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a7c9b84fa332ecb207ec0b806eb322402addcb28 [^] => http://code.openbravo.com/erp/devel/pi/rev/7a3fbbcba4f1f3f2395ccaabbed477dadf7288fa [^]
2009-08-18 21:09 hgbot Checkin
2009-08-18 21:09 hgbot Note Added: 0019020
2009-08-18 21:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/7a3fbbcba4f1f3f2395ccaabbed477dadf7288fa [^] => http://code.openbravo.com/erp/devel/pi/rev/2e8a99f92b61cf1f425836c43bd904dbd7af6343 [^]
2009-08-18 21:20 shuehner Assigned To shuehner => dalsasua
2009-08-30 11:07 dalsasua Assigned To dalsasua => vmromanos
2009-09-01 19:09 vmromanos Status scheduled => resolved
2009-09-01 19:09 vmromanos Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/2e8a99f92b61cf1f425836c43bd904dbd7af6343 [^] => http://code.openbrahttp://forge.openbravo.com/projects/languagemodulespanish/module [^]
2009-09-01 19:09 vmromanos Resolution open => fixed
2009-09-01 19:09 vmromanos Note Added: 0019383
2009-09-15 20:27 shuehner Relationship added related to 0009384
2009-09-15 20:28 shuehner Relationship added related to 0008574
2009-09-21 12:59 psarobe Status resolved => new
2009-09-21 12:59 psarobe Resolution fixed => open
2009-09-21 12:59 psarobe Note Added: 0020236
2009-09-21 13:00 psarobe File Added: Dibujo.PNG
2009-09-21 13:00 psarobe Note Edited: 0020236
2009-09-21 13:07 vmromanos Note Added: 0020237
2009-09-21 13:07 vmromanos Assigned To vmromanos => shuehner
2009-09-21 13:07 vmromanos Status new => feedback
2009-09-21 13:20 shuehner Note Added: 0020238
2009-10-09 16:44 psarobe Status feedback => scheduled
2009-10-09 16:44 psarobe fix_in_branch => pi
2009-10-13 15:07 hgbot Checkin
2009-10-13 15:07 hgbot Note Added: 0020986
2009-10-13 15:07 hgbot Fixed in SCM revision http://code.openbrahttp://forge.openbravo.com/projects/languagemodulespanish/module [^] => http://code.openbravo.com/erp/devel/pi/rev/61fda85efacfc968daae6b6b188209a18bd39d3a [^]
2009-10-13 15:16 hgbot Checkin
2009-10-13 15:16 hgbot Note Added: 0020987
2009-10-13 15:16 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/61fda85efacfc968daae6b6b188209a18bd39d3a [^] => http://code.openbravo.com/erp/devel/pi/rev/cacae59390952c7fd5a86e1035c98bdc492dae94 [^]
2009-10-13 15:30 shuehner Assigned To shuehner => vmromanos
2009-10-15 11:57 vmromanos Relationship added depends on 0010979
2009-10-15 11:58 vmromanos Assigned To vmromanos => shuehner
2009-10-15 12:00 vmromanos Note Added: 0021034
2009-10-15 15:09 vmromanos Relationship deleted depends on 0010979
2009-10-15 15:09 vmromanos Note Deleted: 0021034
2009-10-15 15:20 shuehner Note Added: 0021063
2009-10-15 15:20 shuehner Assigned To shuehner => vmromanos
2009-10-15 18:25 vmromanos Status scheduled => resolved
2009-10-15 18:25 vmromanos Resolution open => fixed
2009-10-15 18:25 vmromanos Note Added: 0021083
2009-10-19 08:39 arunkumar Status resolved => closed
2009-10-19 08:39 arunkumar Note Added: 0021144
2009-10-19 08:39 arunkumar Fixed in Version => 2.50MP7
2009-10-20 00:00 anonymous sf_bug_id 0 => 2882002

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker