Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0009727
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2009-06-30 20:402009-08-11 00:00
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version2.50MP3
StatusclosedFix in branchpiFixed in SCM revision9c8e98c4df2c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009727: All generated pages load the MessagesJS data after loading the page. This extra request should be removed to improve performance

DescriptionAll generated windows make a minimum of two requests:
1.) the html for the window itself
2.) a request to MessagesJS (in 2.50 DynamicJS) to read/preload some error messages.

This second request delays the page rendering until its result is recieved. As the error messages only change on language switch this extra request shoul be avoided to improve performance.
Steps To ReproduceEither:
Use firebug or a similar tool and the net panel to see the network request
Or:
Read apache/tomcat access log on the server to see the requests.

Goto to i.e. product edit view
See the an extra request to MessagesJS
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0009728 closedshuehner All generated pages load the MessagesJS data after loading the page. This extra request should be removed to improve performance 
blocks feature request 0009729 newshuehner Remove all DynamicJS requests. 

-  Notes
(0017696)
hgbot (developer)
2009-06-30 21:06

Repository: erp/devel/pi
Changeset: 9c8e98c4df2ceac3fe9e4e46fc2ee895a45f92e7
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 30 21:06:36 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9c8e98c4df2ceac3fe9e4e46fc2ee895a45f92e7 [^]

Fixed 9727: Remove unneeded DynamicJS requests from generated windows and search popup
part1:
- Remove request from edit view and grid view of generated window
- Remove request from search popup
- Instead take needed data from the menu frame

---
M src-wad/src/org/openbravo/wad/Template_Edition.html
M src-wad/src/org/openbravo/wad/Template_Relation.html
M src/org/openbravo/erpCommon/businessUtility/Buscador.html
M src/org/openbravo/erpCommon/security/Login_F1.html
M web/js/messages.js
M web/js/utils.js
---
(0017699)
shuehner (administrator)
2009-06-30 21:25

Needed testcases for verifying changes:
1.) search popup displays error message properly
goto product edit view
the search popup is automatically opened
remove all % character in there by default
press ok
A red error box should be shown as no fields are filled

2.) error messages work in edit view of generated window
goto i.e. product edit view (or any other generated window)
press ok in the opened search popup to display a single record
press delete in the toolbar
a popup should be opened displaying the confirmation message.

3.a) error message popup work in grid view of generated window
goto i.e. product grid view (or any other generatd window)
select (highlight) on record.
press delete in the toolbar
a popup should be opened displaying the confirmation message.
3.b) error message popup work in grid view of generated window
goto i.e. product grid view (or any other generatd window)
select (highlight) severals records.
click on the 'switch to edit view' icon in the LeftTabsBar.
a error message that more than one record is selected should be shown.

test another (unchanged) place to check for regression in error message display code
4.) automatically generated parameter popup for a report
goto financial management
goto Accounting
goto analysis tools
goto Create Tax Report
to not select any record in the dropdown
Press ok
a red box with an error message: 'This field is needed and cannot be blank' should be shown

4.)

- Issue History
Date Modified Username Field Change
2009-06-30 20:40 shuehner New Issue
2009-06-30 20:40 shuehner Assigned To => shuehner
2009-06-30 20:41 shuehner Status new => scheduled
2009-06-30 20:41 shuehner fix_in_branch => pi
2009-06-30 20:45 shuehner Relationship added blocks 0009729
2009-06-30 21:06 hgbot Checkin
2009-06-30 21:06 hgbot Note Added: 0017696
2009-06-30 21:06 hgbot Status scheduled => resolved
2009-06-30 21:06 hgbot Resolution open => fixed
2009-06-30 21:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9c8e98c4df2ceac3fe9e4e46fc2ee895a45f92e7 [^]
2009-06-30 21:25 shuehner Note Added: 0017699
2009-08-10 22:34 pjuvara Status resolved => closed
2009-08-10 22:34 pjuvara Fixed in Version => 2.50MP3
2009-08-11 00:00 anonymous sf_bug_id 0 => 2835189


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker