Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0008923
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 08. Project and service managementmajoralways2009-05-05 09:192009-06-03 11:12
ReporternetworkbView Statuspublic 
Assigned Tojayakumar 
PriorityimmediateResolutionfixedFixed in Version2.35MP13
StatusclosedFix in branch2.3xFixed in SCM revision2de29610cffc
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_11
OS VersionrPath LinuxDatabase version8.3.5Ant version1.7.1
Product Version2.40MP3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0008923: report "project profitability" is incorrect with invoices voids

Descriptionthe field "revenue real" in service column, and the field "reinvoicing real" in expense column, when exist any void invoice, the negative invoice is included in calcule, but the positive invoice is not included
Steps To Reproduce. create invoice I with total amount 100 euros with project p
. run project profitability report with project p selected:
   field real revenue in service column is 100
. void invoice I
. run project profitability report with project p selected:
   field real revenue in service column is -100

the same error is with expenses invoices.
Proposed SolutionThe problem is not in the report which correctly displays both invoices in Complete and Closed status.

The problem is that the negative invoice created when voiding has the status closed. Both the voided invoice and the invoice created to void it have to be in status void.

Review the following lines in the procedure C_INVOICE_POST:
-- Reversal Transaction is closed
          UPDATE C_INVOICE
            SET DocStatus='CL', -- the reversal transaction
            DocAction='--',
            Processed='Y'
          WHERE C_Invoice_ID=v_RInvoice_ID;
Tagscomsupchennai_sprint6
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to backport 0009089 closedrafaroda Change Project Profitability citeria for displaying invoices 
blocks defect 0008895 closedjayakumar report "project profitability" is incorrect with invoices voids 

-  Notes
(0016206)
hgbot (developer)
2009-05-11 06:05

 Repository: erp/stable/2.3x
Changeset: baaa085cb3f8fbfd7e4f1a220070137a33b2d1bf
Author: Jayakumar Kasinathan <jayakumar.kasinathan <at> openbravo.com>
Date: Sun May 10 21:36:37 2009 -0400
URL: http://code.openbravo.com/erp/stable/2.3x/rev/baaa085cb3f8fbfd7e4f1a220070137a33b2d1bf [^]

Fixes bug 8923 report \"project profitability\" is incorrect with invoices voids.

---
M database/model/functions/C_INVOICE_POST.xml
---
(0016348)
networkb (developer)
2009-05-14 11:27

 will be fix this bug in 2.35 MP12?
(0016350)
networkb (developer)
2009-05-14 12:25

 this change could affect to others reports. All reports should have the same criter. For example, "invoice dimensional" report has distinct criter that "project profitability" report.
could be solution to this bug that sql of this report have same conditions that "invioce dimensional" report ?
(0016362)
rafaroda (developer)
2009-05-15 08:19

 The behavior of all the reports which show invoices is the following:
* Show invoices which are processed: C_INVOICE.PROCESSED = 'Y'
* This means that the invoices status can be both Completed (CO), Closed (CL) and Void (VO)


The behavior of the Project Profitability Report (which is showing invoices associated to projects) is the following:
* Shows invoices which are in status both Completed (CO) and Closed (CL): : ia.docStatus IN ('CO', 'CL')

Why is the behavior different in the Project profitability Report?
* There is no functional reason but technical performance reasons: this report is using multiple subqueries and discarding invoices in status Void will make it faster.

For preserving the consistency of the reports which show invoices, a new minor defect has been opened in order to address this issue: https://issues.openbravo.com/view.php?id=9037 [^]

Thank you for your feedback.
(0016792)
hgbot (developer)
2009-06-01 09:27

 Repository: erp/stable/2.3x
Changeset: 2de29610cffc80d14344ce8b02fb9100d3070e32
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Mon Jun 01 08:41:24 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.3x/rev/2de29610cffc80d14344ce8b02fb9100d3070e32 [^]

Fixes issue 0008923 Invoice Voided is now in status VO

---
M database/model/functions/C_INVOICE_POST.xml
---
(0016800)
sureshbabu (reporter)
2009-06-01 11:40

 tested working fine

- Issue History
Date Modified Username Field Change
2009-05-06 11:06 psarobe Type defect => backport
2009-05-06 11:06 psarobe fix_in_branch pi => 2.3x
2009-05-07 12:53 rafaroda Assigned To rafaroda => sathiyan
2009-05-07 12:53 rafaroda Steps to Reproduce Updated
2009-05-07 13:15 sathiyan Assigned To sathiyan => jayakumar
2009-05-11 06:05 hgbot Checkin
2009-05-11 06:05 hgbot Note Added: 0016206
2009-05-11 06:05 hgbot Status scheduled => resolved
2009-05-11 06:05 hgbot Resolution open => fixed
2009-05-11 06:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.3x/rev/baaa085cb3f8fbfd7e4f1a220070137a33b2d1bf [^]
2009-05-11 06:19 jayakumar Tag Attached: comsupchennai_sprint6
2009-05-14 11:27 networkb Note Added: 0016348
2009-05-14 12:25 networkb Note Added: 0016350
2009-05-15 08:19 rafaroda Note Added: 0016362
2009-05-19 18:22 rafaroda Relationship added related to 0009089
2009-06-01 09:27 hgbot Checkin
2009-06-01 09:27 hgbot Note Added: 0016792
2009-06-01 09:27 hgbot Fixed in SCM revision http://code.openbravo.com/erp/stable/2.3x/rev/baaa085cb3f8fbfd7e4f1a220070137a33b2d1bf [^] => http://code.openbravo.com/erp/stable/2.3x/rev/2de29610cffc80d14344ce8b02fb9100d3070e32 [^]
2009-06-01 11:40 sureshbabu Status resolved => closed
2009-06-01 11:40 sureshbabu Note Added: 0016800
2009-06-01 11:40 sureshbabu Fixed in Version => 2.35MP14
2009-06-03 11:12 sureshbabu Fixed in Version 2.35MP14 => 2.35MP13

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker