0008912: User not able to complete the Sales Order, when it is created through Create Sales Orders from Expenses process

Description

when sales order are created through 'Create Sales Orders from Expenses process', system wrongly throws error message as 'In line10 has no storage bin defined' for Products with product type as Expense or service type, and also not allowing the user to complete the sales order manually.

Note: To produce this issue we need to create Project type & then we need create a Service project for the above created project type. Then we need to add few AR invoice able expenses to the project through Expense sheet and then move on to create sales order through 'Create Sales Orders from Expenses process'

Below I have drafted the sample steps to reproduce the issue (please use user, products , Business partner of your choice)

Steps To Reproduce

Define a project type with standard phases and tasks.

    * Additional data: Create the products SERVICE A, SERVICE B with the following attributes:
    * Search key: sera, serb, name: Service A, Service B, Tax category:VAT 10%, UOM: Day, Product type: Expense type
    * Login as userA
    * Go to Project & Service Management->Setup->Project Type
    * Click New and fill:
          o Name: Technical consultancy
    * Go to Standard Phase tab.
    * Click New and fill:
          o Name: Project preparation
          o Product: A Final goods
          o Standard Quantity: 10
    * Go to Standard Task tab.
    * Click New and fill:
          o Name: First draft
          o Product: Service A
          o Standard Quantity: 25
    * Click New and fill:
          o Name: Final prototype
    * Go back to Standard Phase tab.
    * Click New and fill:
          o Name: Project delivery
    * Go to Standard Task tab.
    * Click New and fill:
          o Name: Project closing
          o Product: A Final goods
          o Standard Quantity: 15

Start a new service project with lines that permits to create sales orders.

    * Login as userA
    * Go to Project & Service Management->Transactions->Service Project
    * Click New and fill:
          o Search Key: sca
          o Name: Service Project for Customer A
          o Create Temporary Price List: N (un-checked)
    * Move to Project Line tab.
    * Click New and fill:
          o Product: A Final goods
          o Planned Quantity: 10
          o Tax: VAT 3%
          o Planned Price: 1.75 and verify Planned Amount is 17.5
          o Planned Purchase Price: 1.2
    * Go back to Service Project tab.
    * Select Service Project for Customer A and edit:
          o Business Partner: CUSTOMER A
    * Verify that:
          o Partner Address: "Pamplona, Street Customer center nº1"
          o The combo box User/Contact must have the value: Alfred
          o Price list: CUSTOMER A
          o Form of payment: Money Order
          o Payment terms: 30 days, 5
    * Select:
          o Sales Representative: Eduard
    * Save and click on Change Project Status button and select Order.
    * Verify that:
          o Project Status is Order.
          o Price List is CUSTOMER A.

    * And click on Create Sales Order from Project button.
    * Navigate through Linked items to the Sales Order created.
    * Check that:
          o Business Partner: CUSTOMER A
          o Price List: CUSTOMER A
          o Invoice Terms: Customer schedule after delivery
          o Sales Representative: Eduard
          o Form of Payment: Money Order
          o Payment Terms: 30 days, 5
          o Project: sca - Service Project for Customer A
          o Summed Line Amount: 17.5
          o Grand Total Amount: 18.03
    * Move to Lines tab.
    * Select A Final goods line and check that:
          o Ordered Quantity: 10
          o UOM: Unit
          o Unit Price: 1.75
          o List Price: 2
          o Discount: 12.5
          o Tax: VAT 3%
          o Line Net Amount: 17.5
    * Go back to Header tab.
    * Click on Complete button.
    * Go back to Project & Service Management->Transactions->Service Project
    * Select Service Project for Customer A and click on Change Project Status button to close the project selecting Order closed option.

Fill some expense sheets.

# Login as userA
# Go to Project & Service Management->Transactions->Expense Sheet
# Click New and fill:

    * Description: Expenses Consultancy for Customer A project
    * Employee: Eduard

# Go to Lines tab.
# Click New and fill:

    * Reinvoincing: Y
    * Product: Service A
    * Quantity: 1
    * Project: Service Project for Customer A


# Check that:

    * UOM: Day
    * Expense Amount: 1
    * Business Partner: CUSTOMER A

# Go back to Header tab.
# Click on Process Expenses button.

Tags

250MP1

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0016063) hgbot (developer) 2009-05-05 16:48	Repository: erp/devel/pi Changeset: 14335553bf67e46fb2724e49046dfbdd2278caad Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Tue May 05 16:46:40 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/14335553bf67e46fb2724e49046dfbdd2278caad [^] Fixed bug 8912.Related to issue 7860. Changed the m_locator_id checking. The checking for null m_locator_id in the m_inout_line table now is done only if the product of the line is a stocked item. --- M src-db/database/model/functions/M_INOUT_POST.xml ---

(0017865) hgbot (developer) 2009-07-03 13:14	Repository: erp/devel/pi Changeset: 5945bf27bcbb6fa74364f7fa8e84be41439c06a9 Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Tue May 05 16:46:40 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/5945bf27bcbb6fa74364f7fa8e84be41439c06a9 [^] Fixed bug 8912.Related to issue 7860. Changed the m_locator_id checking. The checking for null m_locator_id in the m_inout_line table now is done only if the product of the line is a stocked item. --- M src-db/database/model/functions/M_INOUT_POST.xml ---

(0018042) sureshbabu (reporter) 2009-07-09 08:41	Tested working fine

Issue History
Date Modified	Username	Field	Change
2009-05-05 15:26	sureshbabu	New Issue
2009-05-05 15:26	sureshbabu	Assigned To	=> rafaroda
2009-05-05 15:26	sureshbabu	Regression testing	=> No
2009-05-05 15:29	psarobe	Assigned To	rafaroda => gorkaion
2009-05-05 15:29	psarobe	Status	new => scheduled
2009-05-05 15:40	psarobe	Tag Attached: 250MP1
2009-05-05 16:48	hgbot	Checkin
2009-05-05 16:48	hgbot	Note Added: 0016063
2009-05-05 16:48	hgbot	Status	scheduled => resolved
2009-05-05 16:48	hgbot	Resolution	open => fixed
2009-05-05 16:48	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/14335553bf67e46fb2724e49046dfbdd2278caad [^]
2009-05-07 23:15	psarobe	Status	resolved => closed
2009-05-08 00:00	anonymous	sf_bug_id	0 => 2788668
2009-07-03 13:14	hgbot	Checkin
2009-07-03 13:14	hgbot	Note Added: 0017865
2009-07-03 13:14	hgbot	Status	closed => resolved
2009-07-03 13:14	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/14335553bf67e46fb2724e49046dfbdd2278caad [^] => http://code.openbravo.com/erp/devel/pi/rev/5945bf27bcbb6fa74364f7fa8e84be41439c06a9 [^]
2009-07-09 08:41	sureshbabu	Status	resolved => closed
2009-07-09 08:41	sureshbabu	Note Added: 0018042
2009-07-09 08:41	sureshbabu	Fixed in Version	2.50MP1 => pi