Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0008853 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | have not tried | 2009-04-30 08:04 | 2009-05-10 00:00 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 2.50MP1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 2cd6c5bbdee5 | ||||
Projection | none | ETA | none | Target Version | pi | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | pi | SCM revision | ||||||
Review Assigned To | ||||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0008853: OBContext.setInAdministratorMode is not threadsafe | |||||||
Description | With ajax calls (and even with standard http requests) it is possible that multiple requests of one user end up at the server in the same time in different threads. If that happens then when one thread sets OBContext.setInAdministratorMode then other threads are influenced by that. This because the OBContext instance is shared by threads of the same user/httpsession. The solution is to use a ThreadLocal to store the administrator mode flag of the OBContext. This flag has to be cleaned at the end of the request (in the dal request filter). | |||||||
Tags | 250MP1 | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0015993) hgbot (developer) 2009-05-01 13:27 |
Repository: erp/devel/pi Changeset: 2cd6c5bbdee5e907088263d16ca8ca6e87c7a2b0 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri May 01 13:26:36 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2cd6c5bbdee5e907088263d16ca8ca6e87c7a2b0 [^] Fixes issue 8853: OBContext.setInAdministratorMode is not threadsafe --- M src-test/org/openbravo/test/AllAntTaskTests.java M src-test/org/openbravo/test/AllQuickAntTaskTests.java M src-test/org/openbravo/test/AntTaskTests.java M src/org/openbravo/base/model/ModelProvider.java M src/org/openbravo/dal/core/OBContext.java A src-test/org/openbravo/test/dal/OBContextTest.java --- |
(0016202) psarobe (manager) 2009-05-09 18:57 |
Not able to tested. Not enough description but let's assume is ok |
Issue History | |||
Date Modified | Username | Field | Change |
2009-04-30 08:04 | mtaal | New Issue | |
2009-04-30 08:04 | mtaal | Assigned To | => mtaal |
2009-04-30 08:04 | mtaal | Regression testing | => No |
2009-04-30 08:33 | iperdomo | Relationship added | blocks 0008449 |
2009-04-30 08:34 | iperdomo | Tag Attached: 250MP1 | |
2009-05-01 13:27 | hgbot | Checkin | |
2009-05-01 13:27 | hgbot | Note Added: 0015993 | |
2009-05-01 13:27 | hgbot | Status | new => resolved |
2009-05-01 13:27 | hgbot | Resolution | open => fixed |
2009-05-01 13:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2cd6c5bbdee5e907088263d16ca8ca6e87c7a2b0 [^] |
2009-05-09 18:57 | psarobe | Status | resolved => closed |
2009-05-09 18:57 | psarobe | Note Added: 0016202 | |
2009-05-10 00:00 | anonymous | sf_bug_id | 0 => 2789549 |
Copyright © 2000 - 2009 MantisBT Group |