Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0008624 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2009-04-17 15:39 | 2009-06-04 00:00 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 2.50MP1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 8b4f72c8b336 | ||||
| Projection | none | ETA | none | Target Version | pi | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0008624: Validation should not check field length of id/foreign key columns | |||||||
| Description | Transcript of email: Martin, there is a problem when importing a client with validations. The system cheks for ad_column.fieldlengh for ID and foreign key columns, and there are a lot that are not properly defined... So it is quite frequent to get an error (fieldlenght expected: 32 but it is 22). You can get all wrong columns through a simple query: select * from ad_column where fieldlength = 22 and ad_reference_id in (13, 18, 19, 30, 35) In my opinion the solution is not to change this fieldlength but remove the validation for this case. For ID and foreign key columns the fieldlength is useless, we dont use it. In fact, we should add a display logic to hide this field in case of these references... Can you please complete the list of references that are ID or foreign key? I prepared that list from the list of wrong columns, so there will be other references for foreign keys. Martin, can you please remove this validation (just for those references)? Asier, can you please add a display logic to hide this field for those references? Thanks, Ismael | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0015994) hgbot (developer) 2009-05-01 14:38 |
Repository: erp/devel/pi Changeset: 8b4f72c8b336e7cd54bc889ee5edd819043df836 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri May 01 14:37:55 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8b4f72c8b336e7cd54bc889ee5edd819043df836 [^] Fixes issue 8624: Validation should not check field length of id/foreign key columns --- M src-test/org/openbravo/test/dal/ValidationTest.java M src/org/openbravo/base/validation/StringPropertyValidator.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-04-17 15:39 | mtaal | New Issue | |
| 2009-04-17 15:39 | mtaal | Assigned To | => mtaal |
| 2009-04-17 15:39 | mtaal | Regression testing | => No |
| 2009-04-22 20:17 | psarobe | Status | new => scheduled |
| 2009-05-01 14:38 | hgbot | Checkin | |
| 2009-05-01 14:38 | hgbot | Note Added: 0015994 | |
| 2009-05-01 14:38 | hgbot | Status | scheduled => resolved |
| 2009-05-01 14:38 | hgbot | Resolution | open => fixed |
| 2009-05-01 14:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/8b4f72c8b336e7cd54bc889ee5edd819043df836 [^] |
| 2009-06-03 17:09 | psarobe | Status | resolved => closed |
| 2009-06-04 00:00 | anonymous | sf_bug_id | 0 => 2800772 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |