Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0008624Openbravo ERPA. Platformpublic2009-04-17 15:392009-06-04 00:00
mtaal 
mtaal 
normalmajorhave not tried
closedfixed 
5
pi 
pi2.50MP1 
Core
No
0008624: Validation should not check field length of id/foreign key columns
Transcript of email:
Martin,

there is a problem when importing a client with validations. The system
cheks for ad_column.fieldlengh for ID and foreign key columns, and there are
a lot that are not properly defined... So it is quite frequent to get an
error (fieldlenght expected: 32 but it is 22).

You can get all wrong columns through a simple query:

select * from ad_column
where fieldlength = 22
and ad_reference_id in (13, 18, 19, 30, 35)

In my opinion the solution is not to change this fieldlength but remove the
validation for this case. For ID and foreign key columns the fieldlength is
useless, we dont use it. In fact, we should add a display logic to hide this
field in case of these references...

Can you please complete the list of references that are ID or foreign key? I
prepared that list from the list of wrong columns, so there will be other
references for foreign keys.
Martin, can you please remove this validation (just for those references)?
Asier, can you please add a display logic to hide this field for those
references?

Thanks,

Ismael
No tags attached.
Issue History
2009-04-17 15:39mtaalNew Issue
2009-04-17 15:39mtaalAssigned To => mtaal
2009-04-17 15:39mtaalRegression testing => No
2009-04-22 20:17psarobeStatusnew => scheduled
2009-05-01 14:38hgbotCheckin
2009-05-01 14:38hgbotNote Added: 0015994
2009-05-01 14:38hgbotStatusscheduled => resolved
2009-05-01 14:38hgbotResolutionopen => fixed
2009-05-01 14:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8b4f72c8b336e7cd54bc889ee5edd819043df836 [^]
2009-06-03 17:09psarobeStatusresolved => closed
2009-06-04 00:00anonymoussf_bug_id0 => 2800772

Notes
(0015994)
hgbot   
2009-05-01 14:38   
Repository: erp/devel/pi
Changeset: 8b4f72c8b336e7cd54bc889ee5edd819043df836
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 01 14:37:55 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b4f72c8b336e7cd54bc889ee5edd819043df836 [^]

Fixes issue 8624: Validation should not check field length of id/foreign key columns

---
M src-test/org/openbravo/test/dal/ValidationTest.java
M src/org/openbravo/base/validation/StringPropertyValidator.java
---