0008031: export.database (for core) fails with new column of new module inside core table

Description

Adding a new column in a newly created module to a column in a core table and then doing export.database with having core and the new module indevelopment='Y' fails.

Error message is that the new column is present in the application dictionary but not in the database, even when it is in the db,

Steps To Reproduce

- Create a new module (just entry in the application, no need to register it)
- set the new module as indevelopment
- set the dbprefix to: 'howto'
- set the core-module to indevelopment
- Add a new db-column to an existing core table:
ALTER TABLE m_productprice ADD COLUMN em_howto_calc_average_price CHARACTER(1) NOT NULL DEFAULT ;
- Go to Tables and columns and navigate to the m_productprice table. Use the 'create columns from database' to import the new column into the application distionary.
- Change the module for the new column to the newly created module.
- try to use 'ant export.database'

See the described error message when trying to export the core module.

Tags

No tags attached.

Attached Files

workaround_to_highlight_problem.diff [^] (900 bytes) 2009-03-09 16:33 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/service/system/DatabaseValidator.java b/src/org/openbravo/service/system/DatabaseValidator.java
--- a/src/org/openbravo/service/system/DatabaseValidator.java
+++ b/src/org/openbravo/service/system/DatabaseValidator.java
@@ -249,8 +249,8 @@
     final String moduleId = (getValidateModule() == null ? null : getValidateModule().getId());
     for (Column column : adTable.getADColumnList()) {
       final boolean checkColumn = moduleId == null
-          || (adTable.getDataPackage().getModule() != null && adTable.getDataPackage().getModule()
-              .getId().equals(moduleId))
+//          || (adTable.getDataPackage().getModule() != null && adTable.getDataPackage().getModule()
+//              .getId().equals(moduleId))
           || (column.getModule() != null && column.getModule().getId().equals(moduleId));
       if (!checkColumn) {
         continue;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0014528) shuehner (administrator) 2009-03-09 16:35	Attached patch to pinpoint the place where most likely the problem pops up. The lines commented out by the patch force the validation to be run for the new module (belonging to module A) when trying to export the module core. => column from a not in module core (not in list of columns read from ddlutils) => error column from ad does not exist in db.

(0014540) hgbot (developer) 2009-03-10 10:51	Repository: erp/devel/pi Changeset: 52cb0e69a9dcb63e811b14b717986a89bca4b6f5 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Mar 10 10:50:52 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/52cb0e69a9dcb63e811b14b717986a89bca4b6f5 [^] Fixes issue 8031: export.database (for core) fails with new column of new module inside core table --- M src/org/openbravo/service/system/DatabaseValidator.java ---

Issue History
Date Modified	Username	Field	Change
2009-03-09 16:32	shuehner	New Issue
2009-03-09 16:32	shuehner	Assigned To	=> mtaal
2009-03-09 16:32	shuehner	OBNetwork customer	=> No
2009-03-09 16:32	shuehner	Regression testing	=> No
2009-03-09 16:33	shuehner	File Added: workaround_to_highlight_problem.diff
2009-03-09 16:35	shuehner	Note Added: 0014528
2009-03-10 10:51	hgbot	Checkin
2009-03-10 10:51	hgbot	Note Added: 0014540
2009-03-10 10:51	hgbot	Status	new => resolved
2009-03-10 10:51	hgbot	Resolution	open => fixed
2009-03-10 10:51	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/52cb0e69a9dcb63e811b14b717986a89bca4b6f5 [^]
2009-04-21 10:53	psarobe	Status	resolved => closed
2009-04-22 00:01	anonymous	sf_bug_id	0 => 2778058