0007466: FACT_ACCT_RESET database procedure unposts all manual settlements when unposting one record

Description

When having 5000 manual settlements and 5000 invoices.
If you want to unpost a manual settlement to unprocess the settlement, all the manual settlements are unposted.
Posting manual settlements with no direct accounting means changing all settlements from posted='N' to posted='Y'.
When you want to unpost a manual settlement, you just want to update posted='Y' to posted='N' so you can unprocess the settlement.
But the application unposts all the manual settlements. Although it does not change the accounting information, the accounting background process posts again all the 5000 manual settlements. So you have to wait until this are posted before the invoices get also posted.

Steps To Reproduce

Introduce 5 manual settlement.
Post them.
Unpost a manual settlement. Also the log says: "Success 5 updated".

Proposed Solution

Improve code at FACT_ACCT_RESET around line 220:

        v_Cmd:='UPDATE ' || Cur_Tables.TableName || ' SET Posted=''N'', Processing=''N'' WHERE AD_Client_ID=''' || Cur_Clients.AD_Client_ID
        || ''' AND (Posted=''Y'' OR Processing<>''N'' OR Processing IS NULL) AND NOT EXISTS (SELECT 1 FROM FACT_ACCT WHERE AD_TABLE_ID =''' || Cur_Tables.AD_Table_ID ||
        ''' AND RECORD_ID = ' || Cur_Tables.TableName || '_ID AND AD_CLIENT_ID =''' || Cur_Clients.AD_Client_ID || ''' )';
            -- DBMS_OUTPUT.PUT_LINE(' executing: ' || v_Cmd);

updates all the records not having accounting info at fact_acct.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0007327

closed

eduardo_Argal

FACT_ACCT_RESET database procedure unposts all manual settlements when unposting one record

Notes
(0013444) svnbot (viewer) 2009-02-12 19:54	Repository: openbravo Revision: 13120 Author: eduardoargal Date: 2009-02-12 19:54:02 +0100 (Thu, 12 Feb 2009) Fixes bug 0007466: FACT_ACCT_RESET database procedure unposts all manual settlements when unposting one record --- U branches/r2.3x/database/model/functions/FACT_ACCT_RESET.xml --- https://dev.openbravo.com/websvn/openbravo/?rev=13120&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2009-02-10 10:03	psarobe	Type	defect => backport
2009-02-10 10:03	psarobe	fix_in_branch	=> 2.3x
2009-02-10 10:04	psarobe	Assigned To	rafaroda => eduardo_Argal
2009-02-12 19:54	svnbot	Checkin
2009-02-12 19:54	svnbot	Note Added: 0013444
2009-02-12 19:54	svnbot	Status	scheduled => resolved
2009-02-12 19:54	svnbot	Resolution	open => fixed
2009-02-12 19:54	svnbot	svn_revision	=> 13120
2009-03-06 16:09	psarobe	Fixed in Version	=> 2.35MP12
2009-03-09 23:42	psarobe	Status	resolved => closed