Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0006874

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2009-01-13 18:04

2009-04-21 12:39

Reporter

shuehner

View Status

public

Assigned To

dbaz

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0006874: Validation of fields in the search popup does not work for numeric fields

Description

When you enable an extra filter field (i.e. Grand Total for the table C_Order) and open the search popup for i.e. the Sales Order window. Then the validation (if the content is a number) does not work for this new field.

Two Problems:
- the import for the javascript file containing the validation function is missing
- the html-code is generated with the wrong fieldname when calling this validation function.

Steps To Reproduce

Switch to System Administrator role
Go to "Tables and column", and search C_Order.
Check GrandTotal column as Filter column
Switch to i.e. openbravo admin role
Go to Sales Order window, and open seach pop-up.
enter "hello world" in i.e. the "Grand Total from" field
See that no error message is shown next to the field saying this text is not a number

Proposed Solution

- Add the missing js-import if a numeric field is shown
- fix the generated html to output the correct fieldname when calling the validateNumberBo function

Tags

No tags attached.

fix_for_6874_part1.diff [^] (924 bytes) 2009-01-13 19:40 [Show Content] [Hide Content]

Index: src/org/openbravo/erpCommon/businessUtility/Buscador.java
===================================================================
--- src/org/openbravo/erpCommon/businessUtility/Buscador.java	(revision 11825)
+++ src/org/openbravo/erpCommon/businessUtility/Buscador.java	(working copy)
@@ -930,6 +930,11 @@
                             "/js/default/DateTextBox.js\" type=\"text/javascript\"></script>");
         }
         if (scriptCalculator) {
+            scrScr
+                    .append("<script language=\"JavaScript\" src=\"")
+                    .append(strReplaceWith)
+                    .append(
+                            "/js/default/ValidationNumberBox.js\" type=\"text/javascript\"></script>");
             scrScr.append("<script language=\"JavaScript\" src=\"").append(
                     strReplaceWith).append(
                     "/js/calculator.js\" type=\"text/javascript\"></script>");

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0012153) shuehner (administrator) 2009-01-13 19:08	This issue exists in trunk,2.40,2.35

(0012160) shuehner (administrator) 2009-01-13 19:41	Attached patch for first part of the problem (missing js-script import for validateNumberBox). The wrong parameter/field-name problem on calling the validation function is still open.

(0013042) svnbot (reporter) 2009-02-02 21:41	Repository: openbravo Revision: 12690 Author: dbaz Date: 2009-02-02 21:41:17 +0100 (Mon, 02 Feb 2009) Fixed bug 0006874: added ids to numeric inputs of Buscador.java and fixed js error of auto_complete_number --- U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.html U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment.html U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Settlement.html U trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.html U trunk/src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.html U trunk/src/org/openbravo/erpCommon/ad_forms/ShowSessionPreferences.html U trunk/src/org/openbravo/erpCommon/businessUtility/Buscador.java U trunk/src/org/openbravo/erpCommon/info/AttributeSetInstance.java U trunk/src-wad/lib/openbravo-wad.jar U trunk/src-wad/src/org/openbravo/wad/WadActionButton.java U trunk/src-wad/src/org/openbravo/wad/WadUtility.java U trunk/web/js/utils.js --- https://dev.openbravo.com/websvn/openbravo/?rev=12690&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2009-01-13 18:04	shuehner	New Issue
2009-01-13 18:04	shuehner	Assigned To	=> rafaroda
2009-01-13 18:04	shuehner	sf_bug_id	0 => 2504957
2009-01-13 18:04	shuehner	Regression testing	=> No
2009-01-13 19:08	shuehner	Note Added: 0012153
2009-01-13 19:40	shuehner	File Added: fix_for_6874_part1.diff
2009-01-13 19:41	shuehner	Note Added: 0012160
2009-01-19 10:51	psarobe	Status	new => scheduled
2009-01-19 10:51	psarobe	Assigned To	rafaroda => dbaz
2009-01-19 10:51	psarobe	fix_in_branch	=> trunk
2009-02-02 21:41	svnbot	Checkin
2009-02-02 21:41	svnbot	Note Added: 0013042
2009-02-02 21:41	svnbot	Status	scheduled => resolved
2009-02-02 21:41	svnbot	Resolution	open => fixed
2009-02-02 21:41	svnbot	svn_revision	=> 12690
2009-04-21 12:39	psarobe	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group