0006394: Business partner selector - lines 90 and 91 are missing

(0011194)
rafaroda (viewer)
2008-12-11 17:30

Could not reproduce this issue in PostgreSQL 8.3.

For the creation of business partners I used the function below and run SELECT create_customers(200);

With this, I did the steps explained in 'Steps to reproduce' and the rows 90 and 91 displayed with the same data both times.

Any other additional information? Any video record of the error? Thank you.

CREATE OR REPLACE FUNCTION create_customers(IN customersno numeric)
RETURNS void AS
$BODY$ DECLARE
i INTEGER:= 0;
partner_id INTEGER:= 2000000;
partner_name VARCHAR(20000);
partner_value VARCHAR(20000);
BEGIN
LOOP
    partner_name := 'customer';
    partner_value := 'cus';
    partner_id := partner_id + i;
    partner_name := partner_name || to_char(i);
    partner_value := partner_value || to_char(i);

    INSERT INTO C_BPARTNER (c_bpartner_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby,
                c_bp_group_id, value, name, iscustomer)
    VALUES (partner_id, 1000000, 0, 'Y', NOW(), 100, NOW(), 100,
                1000003, partner_value, partner_name, 'Y');
    i := i + 1;
    IF i > customersno THEN
       EXIT; -- exit loop
    END IF;
    partner_name := '';
    partner_value := '';
END LOOP;
END ; $BODY$
  LANGUAGE 'plpgsql' VOLATILE
  COST 100;
ALTER FUNCTION create_customers(numeric) OWNER TO tadbranch240;

(0011291)
shuehner (administrator)
2008-12-13 15:49

@Villind:

I need to check which svn-revision you exactly have in your running installation. Can you give the the revision of the r2.40 branch until which you have merged all previous ones?

(0011688)
pjuvara (viewer)
2008-12-23 07:53

Reminder sent to: villind

Dear Reporter,

we would like to remind you that this issue is waiting for your feedback.
Please provide the requested information and set it in status new.

Thanks,

Paolo

(0011693)
shuehner (administrator)
2008-12-23 10:56

Feedback came in via email to rafarofa and me, adding notes here to have the info available in the issue:

Info from reporter:
This problem was happening on version:
URL: https://dev.openbravo.com/svn/openbravo/branches/bonware/r2.40 [^]
Revision: 11096
I've nothing against that you test it but be aware that there is no example data in our branch at the moment.

I just took a quick look at the issue and debugged the HTTP requests:

1. sort_dirs=ASC&sort_cols=value&offset=0&page_size=78&action=getRows&newFilter=0
2. sort_dirs=ASC&sort_cols=value&offset=80&page_size=78&action=getRows&newFilter=0

So it seems that there is a gap in between.

(0011750)
rafaroda (viewer)
2008-12-28 18:19

Does this issue also reproduces in 2.40 branch or in 2.40 tag?

(0011966)
rafaroda (viewer)
2009-01-07 21:12

Ville, this issue is still waiting for feedback to know if it is reproducible in 2.40 tag or 2.40 branch.

Thank you.

(0012162)
villind (viewer)
2009-01-13 22:59

This issue happens when a business partner has more that one address defined.

After this the offset calculation for the second page breaks:

Offset and page size for the second page (second data grid fetch)

When one address is defined:
offset=87&page_size 87

When two addresses are defined:
offset=88&page_size 87

When three addresses are defined:
offset=89&page_size 87

So the offset makes the data grid skip as many rows as there are additional addresses defined.

(0012166)
shuehner (administrator)
2009-01-14 12:45

Thanks Ville,

i will try to reproduce with that info and update the status here.

(0012180)
shuehner (administrator)
2009-01-14 18:04

This issue is a regression introduced with the latest performance changes and does affect trunk and r2.40

(0012259)
svnbot (viewer)
2009-01-16 15:02

Repository: openbravo
Revision: 11973
Author: huehner
Date: 2009-01-16 15:02:48 +0100 (Fri, 16 Jan 2009)

Fixed 6394
Partly revert change done in r7792 which broke Selector when
BP has multiple locations or contacts assigned.

---
U trunk/src/org/openbravo/erpCommon/info/BusinessPartner.java
U trunk/src/org/openbravo/erpCommon/info/BusinessPartner_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=11973&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-12-07 23:06	villind	New Issue
2008-12-07 23:06	villind	Assigned To	=> rafaroda
2008-12-07 23:06	villind	sf_bug_id	0 => 2404575
2008-12-07 23:06	villind	OBNetwork customer	=> No
2008-12-07 23:06	villind	Regression testing	=> No
2008-12-09 10:15	networkb	OBNetwork customer	No => Yes
2008-12-09 10:15	networkb	Priority	normal => immediate
2008-12-09 10:15	networkb	Severity	major => minor
2008-12-09 10:15	networkb	Issue Monitored: networkb
2008-12-09 14:05	pheenan	Assigned To	rafaroda => pheenan
2008-12-10 10:09	pheenan	Assigned To	pheenan => rafaroda
2008-12-11 17:30	rafaroda	Note Added: 0011194
2008-12-11 17:30	rafaroda	Status	new => feedback
2008-12-13 15:49	shuehner	Note Added: 0011291
2008-12-19 18:18	rafaroda	Assigned To	rafaroda => pheenan
2008-12-23 07:53	pjuvara	Note Added: 0011688
2008-12-23 10:56	shuehner	Note Added: 0011693
2008-12-28 18:11	rafaroda	Assigned To	pheenan => shuehner
2008-12-28 18:11	rafaroda	Status	feedback => new
2008-12-28 18:19	rafaroda	Note Added: 0011750
2008-12-28 18:19	rafaroda	Status	new => acknowledged
2009-01-07 21:11	rafaroda	Status	acknowledged => scheduled
2009-01-07 21:12	rafaroda	Note Added: 0011966
2009-01-07 21:12	rafaroda	Status	scheduled => feedback
2009-01-13 22:59	villind	Note Added: 0012162
2009-01-14 12:45	shuehner	Note Added: 0012166
2009-01-14 18:04	shuehner	Status	feedback => scheduled
2009-01-14 18:04	shuehner	Note Added: 0012180
2009-01-14 18:04	shuehner	fix_in_branch	=> trunk
2009-01-16 15:02	svnbot	Checkin
2009-01-16 15:02	svnbot	Note Added: 0012259
2009-01-16 15:02	svnbot	Status	scheduled => resolved
2009-01-16 15:02	svnbot	Resolution	open => fixed
2009-01-16 15:02	svnbot	svn_revision	=> 11973
2009-02-17 13:03	rafaroda	Relationship added	related to 0007572
2009-04-21 12:36	psarobe	Status	resolved => closed

Notes
(0011194) rafaroda (viewer) 2008-12-11 17:30	Could not reproduce this issue in PostgreSQL 8.3. For the creation of business partners I used the function below and run SELECT create_customers(200); With this, I did the steps explained in 'Steps to reproduce' and the rows 90 and 91 displayed with the same data both times. Any other additional information? Any video record of the error? Thank you. CREATE OR REPLACE FUNCTION create_customers(IN customersno numeric) RETURNS void AS $BODY$ DECLARE i INTEGER:= 0; partner_id INTEGER:= 2000000; partner_name VARCHAR(20000); partner_value VARCHAR(20000); BEGIN LOOP partner_name := 'customer'; partner_value := 'cus'; partner_id := partner_id + i; partner_name := partner_name \|\| to_char(i); partner_value := partner_value \|\| to_char(i); INSERT INTO C_BPARTNER (c_bpartner_id, ad_client_id, ad_org_id, isactive, created, createdby, updated, updatedby, c_bp_group_id, value, name, iscustomer) VALUES (partner_id, 1000000, 0, 'Y', NOW(), 100, NOW(), 100, 1000003, partner_value, partner_name, 'Y'); i := i + 1; IF i > customersno THEN EXIT; -- exit loop END IF; partner_name := ''; partner_value := ''; END LOOP; END ; $BODY$ LANGUAGE 'plpgsql' VOLATILE COST 100; ALTER FUNCTION create_customers(numeric) OWNER TO tadbranch240;

(0011291) shuehner (administrator) 2008-12-13 15:49	@Villind: I need to check which svn-revision you exactly have in your running installation. Can you give the the revision of the r2.40 branch until which you have merged all previous ones?

(0011688) pjuvara (viewer) 2008-12-23 07:53	Reminder sent to: villind Dear Reporter, we would like to remind you that this issue is waiting for your feedback. Please provide the requested information and set it in status new. Thanks, Paolo

(0011693) shuehner (administrator) 2008-12-23 10:56	Feedback came in via email to rafarofa and me, adding notes here to have the info available in the issue: Info from reporter: This problem was happening on version: URL: https://dev.openbravo.com/svn/openbravo/branches/bonware/r2.40 [^] Revision: 11096 I've nothing against that you test it but be aware that there is no example data in our branch at the moment. I just took a quick look at the issue and debugged the HTTP requests: 1. sort_dirs=ASC&sort_cols=value&offset=0&page_size=78&action=getRows&newFilter=0 2. sort_dirs=ASC&sort_cols=value&offset=80&page_size=78&action=getRows&newFilter=0 So it seems that there is a gap in between.

(0011750) rafaroda (viewer) 2008-12-28 18:19	Does this issue also reproduces in 2.40 branch or in 2.40 tag?

(0011966) rafaroda (viewer) 2009-01-07 21:12	Ville, this issue is still waiting for feedback to know if it is reproducible in 2.40 tag or 2.40 branch. Thank you.

(0012162) villind (viewer) 2009-01-13 22:59	This issue happens when a business partner has more that one address defined. After this the offset calculation for the second page breaks: Offset and page size for the second page (second data grid fetch) When one address is defined: offset=87&page_size 87 When two addresses are defined: offset=88&page_size 87 When three addresses are defined: offset=89&page_size 87 So the offset makes the data grid skip as many rows as there are additional addresses defined.

(0012166) shuehner (administrator) 2009-01-14 12:45	Thanks Ville, i will try to reproduce with that info and update the status here.

(0012180) shuehner (administrator) 2009-01-14 18:04	This issue is a regression introduced with the latest performance changes and does affect trunk and r2.40

(0012259) svnbot (viewer) 2009-01-16 15:02	Repository: openbravo Revision: 11973 Author: huehner Date: 2009-01-16 15:02:48 +0100 (Fri, 16 Jan 2009) Fixed 6394 Partly revert change done in r7792 which broke Selector when BP has multiple locations or contacts assigned. --- U trunk/src/org/openbravo/erpCommon/info/BusinessPartner.java U trunk/src/org/openbravo/erpCommon/info/BusinessPartner_data.xsql --- https://dev.openbravo.com/websvn/openbravo/?rev=11973&sc=1 [^]