0000061: Add custom field "Fixed in SVN Revision" - Openbravo Issue Tracking System

(0000008)
pjuvara (reporter)
2008-03-14 17:37

Adding a copy of the email thread for reference.

What do you guys think if, in the new bug tracker, we add a custom field for Fix Requests (background: bugs are logged as Defects and defects are solved by one or more Fix Requests linked to the defect) called "Fixed in SVN Revision"?
We could make that field mandatory to close the Fixed Request with resolution Fixed.

That way:
1) It would be automatically enforced
2) It would be easier to search than a comment

Jaime: do you think it is possible? I created feature request 61 in Mantis to track this.

Paolo
- Hide quoted text -

On Fri, Mar 14, 2008 at 5:03 PM, Ismael Ciordia, Openbravo <ismael.ciordia@openbravo.com> wrote:

    Hi Jordi,

    I agree with you but it would be better if release management team take care of this.

    Ismael

        -----Mensaje original-----
        De: Jordi Mas [mailto:jordi.mas@openbravo.com]
        Enviado el: viernes, 14 de marzo de 2008 16:27
        Para: Ismael Ciordia, Openbravo
        CC: 'qa'
        Asunto: RE: [qa] Indicating the revision number when closing a bug

        Isma,

        Is this is going to be a new policy from now it would be good to comment it on your next engineering meeting and also to send a message to openbravo-developer-announce.

        Jordi,

        El dv 14 de 03 del 2008 a les 16:00 +0100, en/na Ismael Ciordia, Openbravo va escriure:
> Agree
>
> -----Mensaje original-----
> De: qa-bounces@openbravo.com [mailto:qa-bounces@openbravo.com]En nombre de Jordi Mas
> Enviado el: viernes, 14 de marzo de 2008 15:28
> Para: qa
> Asunto: [qa] Indicating the revision number when closing a bug
>
>
> Hello,
>
> In a blog comment to my blog post a user says[1]:
>
> ;-----------------------------------------------------------------------------------------------------------------------------------------
> BTW, I noticed that lot's of bug corrections in the bug tracker don't include cross references to the corresponding SVN changes. Please could you ensure those are made? It's very important indeed to see them in order to gain good readability on which build may or may not have the listed regression. It also learns your community about what kind of resolutions have been made for what kind of bugs. Thanks and keep it great.
> ;-----------------------------------------------------------------------------------------------------------------------------------------
>
> He is right. It is a common practise in open source projects to:
>
> · Indicate in the commit comment or the ChangeLog if you are fixing a particular bug in the commit (we are currently doing this)
> · When you are closing a bug in Tracker, indicate in which revision (see [2] or [3]) you have closed the bug. For example, it is very common to include a comment like "Fixed. See revision XXXXX"
>
> I think that this is a good policy because people looking for the fix for a specific bug can quickly spot it.
>
> Jordi,
>
> [1] http://jordimash.blogspot.com/2008/02/openbravo-community-plans-for-2008.html [^]
> [2] http://dev.processing.org/bugs/show_bug.cgi?id=174 [^]
> [3] http://deuce.doc.wustl.edu/bugzilla/show_bug.cgi?id=2845 [^]
>
> --
> Jordi Mas, jordi.mas@openbravo.com - http://planet.openbravo.com [^]
> IRC channel #openbravo at irc.freenode.net - 24 hours per day!

        --
        Jordi Mas, jordi.mas@openbravo.com - http://planet.openbravo.com [^]
        IRC channel #openbravo at irc.freenode.net - 24 hours per day!

(0000319)
rafaroda (developer)
2008-05-23 11:38

An extra check for this mandatory field: must be a number. To facilitate the task of looking for the revision number, next to this field, add a link to [1] if issue is for Openbravo ERP, to [2] if issue is for Openbravo POS, etc...

[1] http://dev.openbravo.com/websvn/openbravo [^]
[2] https://dev.openbravo.com/websvn/openbravopos [^]

(0000320)
rafaroda (developer)
2008-05-23 11:46

An improvement for this request. Once we have the revision number, Mantis could automatically:
1) Take the link in the form [1] that shows the differences with the last revision, i.e., what has been commited.
2) Generate the patch using 'svn diff' [2] and add it as an attachment.
3) Take the message of the commit and add it as a note.

[1] https://dev.openbravo.com/websvn/openbravo/?op=comp&compare[]=%2Ftrunk@4486&compare[]=%2Ftrunk@4487 [^]
[2] http://wiki.openbravo.com/wiki/Subversion#Applying_revisions_to_your_copy [^]

(0000324)
jaimetorre (reporter)
2008-05-23 17:10

Field created and added in the workflow when resolving a bug. The rest of the feature requests suggested in the notes will be resolved when the integration with subversion gets done (feature request 0000384).

(0019698)
hudsonbot (developer)
2009-09-10 10:39

Fixed Issue 61

------
Integrated in http://builds.openbravo.com/job/mantis_test/20/ [^]
------

(0019712)
hudsonbot (developer)
2009-09-10 10:44

Fixed Issue 61

------
Integrated in http://builds.openbravo.com/job/mantis_test/21/ [^]
------

(0115421)
tarotcardreader (reporter)
2019-11-06 07:52

Wonderful post. I loved reading it. It is an art that takes time to practice. If you want to know how to read a birth chart, you must refer to Tarot Life and its astrology reports. It is amazing.
https://www.yourtarotlife.com/astrology/birth-chart/ [^]

(0120511)
johnridley (reporter)
2020-06-02 05:10

Adding a custom field for Fix Requests called "Fixed in SVN Revision"
https://www.just4dummies.com/gmail-sign-up [^]

Issue History
Date Modified	Username	Field	Change
2008-03-14 17:35	pjuvara	New Issue
2008-03-14 17:37	pjuvara	Note Added: 0000008
2008-05-14 17:22	jaimetorre	Assigned To	=> jaimetorre
2008-05-23 11:38	rafaroda	Note Added: 0000319
2008-05-23 11:46	rafaroda	Note Added: 0000320
2008-05-23 16:29	admin	Relationship added	related to 0000384
2008-05-23 16:30	admin	Status	new => scheduled
2008-05-23 17:08	admin	Status	scheduled => resolved
2008-05-23 17:08	admin	Resolution	open => fixed
2008-05-23 17:08	admin	Note Added: 0000323
2008-05-23 17:08	admin	Status	resolved => closed
2008-05-23 17:09	admin	Note Deleted: 0000323
2008-05-23 17:10	jaimetorre	Note Added: 0000324
2009-09-10 10:39	hudsonbot	Checkin
2009-09-10 10:39	hudsonbot	Note Added: 0019698
2009-09-10 10:39	hudsonbot	Status	closed => resolved
2009-09-10 10:44	hudsonbot	Checkin
2009-09-10 10:44	hudsonbot	Note Added: 0019712
2009-11-14 11:51	jpabloae	Status	resolved => closed
2019-11-06 07:52	tarotcardreader	Note Added: 0115421
2020-06-02 05:10	johnridley	Note Added: 0120511

Notes
(0000008) pjuvara (reporter) 2008-03-14 17:37	Adding a copy of the email thread for reference. What do you guys think if, in the new bug tracker, we add a custom field for Fix Requests (background: bugs are logged as Defects and defects are solved by one or more Fix Requests linked to the defect) called "Fixed in SVN Revision"? We could make that field mandatory to close the Fixed Request with resolution Fixed. That way: 1) It would be automatically enforced 2) It would be easier to search than a comment Jaime: do you think it is possible? I created feature request 61 in Mantis to track this. Paolo - Hide quoted text - On Fri, Mar 14, 2008 at 5:03 PM, Ismael Ciordia, Openbravo <ismael.ciordia@openbravo.com> wrote: Hi Jordi, I agree with you but it would be better if release management team take care of this. Ismael -----Mensaje original----- De: Jordi Mas [mailto:jordi.mas@openbravo.com] Enviado el: viernes, 14 de marzo de 2008 16:27 Para: Ismael Ciordia, Openbravo CC: 'qa' Asunto: RE: [qa] Indicating the revision number when closing a bug Isma, Is this is going to be a new policy from now it would be good to comment it on your next engineering meeting and also to send a message to openbravo-developer-announce. Jordi, El dv 14 de 03 del 2008 a les 16:00 +0100, en/na Ismael Ciordia, Openbravo va escriure: > Agree > > -----Mensaje original----- > De: qa-bounces@openbravo.com [mailto:qa-bounces@openbravo.com]En nombre de Jordi Mas > Enviado el: viernes, 14 de marzo de 2008 15:28 > Para: qa > Asunto: [qa] Indicating the revision number when closing a bug > > > Hello, > > In a blog comment to my blog post a user says[1]: > > ;----------------------------------------------------------------------------------------------------------------------------------------- > BTW, I noticed that lot's of bug corrections in the bug tracker don't include cross references to the corresponding SVN changes. Please could you ensure those are made? It's very important indeed to see them in order to gain good readability on which build may or may not have the listed regression. It also learns your community about what kind of resolutions have been made for what kind of bugs. Thanks and keep it great. > ;----------------------------------------------------------------------------------------------------------------------------------------- > > He is right. It is a common practise in open source projects to: > > · Indicate in the commit comment or the ChangeLog if you are fixing a particular bug in the commit (we are currently doing this) > · When you are closing a bug in Tracker, indicate in which revision (see [2] or [3]) you have closed the bug. For example, it is very common to include a comment like "Fixed. See revision XXXXX" > > I think that this is a good policy because people looking for the fix for a specific bug can quickly spot it. > > Jordi, > > [1] http://jordimash.blogspot.com/2008/02/openbravo-community-plans-for-2008.html [^] > [2] http://dev.processing.org/bugs/show_bug.cgi?id=174 [^] > [3] http://deuce.doc.wustl.edu/bugzilla/show_bug.cgi?id=2845 [^] > > -- > Jordi Mas, jordi.mas@openbravo.com - http://planet.openbravo.com [^] > IRC channel #openbravo at irc.freenode.net - 24 hours per day! -- Jordi Mas, jordi.mas@openbravo.com - http://planet.openbravo.com [^] IRC channel #openbravo at irc.freenode.net - 24 hours per day!

(0000319) rafaroda (developer) 2008-05-23 11:38	An extra check for this mandatory field: must be a number. To facilitate the task of looking for the revision number, next to this field, add a link to [1] if issue is for Openbravo ERP, to [2] if issue is for Openbravo POS, etc... [1] http://dev.openbravo.com/websvn/openbravo [^] [2] https://dev.openbravo.com/websvn/openbravopos [^]

(0000320) rafaroda (developer) 2008-05-23 11:46	An improvement for this request. Once we have the revision number, Mantis could automatically: 1) Take the link in the form [1] that shows the differences with the last revision, i.e., what has been commited. 2) Generate the patch using 'svn diff' [2] and add it as an attachment. 3) Take the message of the commit and add it as a note. [1] https://dev.openbravo.com/websvn/openbravo/?op=comp&compare[]=%2Ftrunk@4486&compare[]=%2Ftrunk@4487 [^] [2] http://wiki.openbravo.com/wiki/Subversion#Applying_revisions_to_your_copy [^]

(0000324) jaimetorre (reporter) 2008-05-23 17:10	Field created and added in the workflow when resolving a bug. The rest of the feature requests suggested in the notes will be resolved when the integration with subversion gets done (feature request 0000384).

(0019698) hudsonbot (developer) 2009-09-10 10:39	Fixed Issue 61 ------ Integrated in http://builds.openbravo.com/job/mantis_test/20/ [^] ------

(0019712) hudsonbot (developer) 2009-09-10 10:44	Fixed Issue 61 ------ Integrated in http://builds.openbravo.com/job/mantis_test/21/ [^] ------

(0115421) tarotcardreader (reporter) 2019-11-06 07:52	Wonderful post. I loved reading it. It is an art that takes time to practice. If you want to know how to read a birth chart, you must refer to Tarot Life and its astrology reports. It is amazing. https://www.yourtarotlife.com/astrology/birth-chart/ [^]

(0120511) johnridley (reporter) 2020-06-02 05:10	Adding a custom field for Fix Requests called "Fixed in SVN Revision" https://www.just4dummies.com/gmail-sign-up [^]