Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0058283 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | have not tried | 2025-03-17 20:28 | 2025-03-24 14:58 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR25Q1.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR25Q1.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0058283: Install from obx file does not handle AD_MODULE_MERGE entries | |||||||
| Description | Installing a new obx version from a file does not detect / handle ad_module_merge entries declared in the new version. That means that the merged module does not get auto-uninstalled as it should be. As a consequence the rest of the process has both the merge copy + the original module present and will fail with various errors Rebuilding system will have lots of duplicate errors Trying to install 2nd module from obx file will have in ‘verifyLocalChanges’ as that reads model from xml file which fails with seeing i.e. EM* columns twice It looks like that error is present from day1 on adding support code for ad_module_merge. https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/6a41faac00f680e468ff0b559605ac49ae9e0ef9#6fe7d4ebb49405382b6092f13a4a78c1b3cebab0_1247_1318 [^] https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/d7658bec195f8e4e5af0764eaa63c490a61c3ebe#6fe7d4ebb49405382b6092f13a4a78c1b3cebab0_1319_1320 [^] Problem seems to be the extra / in front of src-db. When parsing file for obx of core/ad_module_id=0 as created by script packagedistribution/packager/obx file the AD_MODULE_MERGE.xml file inside the ZipInputStream does not match with that leading / | |||||||
| Steps To Reproduce | Have context with backoffice only (git master) + org.openbravo.retail.config => Pre org.openbravo.retail.config merge into core Have local obx file ready with: - higher ad_module.version - ad_module_merge having and entry to declare merge of org.openbravo.retail.config Install this obx file from local. Expected: - Message telling about uninstalled org.openbravo.retail.config module as it has been merged. After confirming this the module folder should be deleted Actual: - This declared is not detected and obx file is installed without deleting the org.openbravo.retail.config module folder | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0176965) hgbot (developer) 2025-03-18 18:51 |
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1598 [^] |
|
(0177181) hgbot (developer) 2025-03-24 14:58 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo [^] Changeset: b0874f87c73c010424a92ba97055fbe986e3edb6 Author: Stefan Huehner <s.huehner@orisha.com> Date: 18-03-2025 18:48:57 URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/b0874f87c73c010424a92ba97055fbe986e3edb6 [^] Fixes ISSUE-58283: Fix reading module merges from local obx file. When installing an update to a module from local obx file the code to find and read AD_MODULE_MERGE.xml inside the obx file was using wrong filename comparison with an extra leading / in front of the src-db/database/sourcedata/AD_MODULE_MERGE.xml. As the filename stores in the obx file don't have a leading / it didn't find the file so never triggered handling of merged modules. Remove the leading / to have the name comparison working (and be same as done for the various other xml file like i.e. AD_MODULE_DBPREFIX in the same function. --- M src/org/openbravo/erpCommon/modules/ImportModule.java --- |
|
(0177182) hgbot (developer) 2025-03-24 14:58 |
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1598 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2025-03-18 18:45 | shuehner | Type | defect => backport |
| 2025-03-18 18:45 | shuehner | Target Version | => PR25Q1.1 |
| 2025-03-18 18:51 | hgbot | Note Added: 0176965 | |
| 2025-03-24 13:35 | hgbot | Merge Request Status | open => approved |
| 2025-03-24 14:58 | hgbot | Resolution | open => fixed |
| 2025-03-24 14:58 | hgbot | Status | scheduled => closed |
| 2025-03-24 14:58 | hgbot | Fixed in Version | => PR25Q1.1 |
| 2025-03-24 14:58 | hgbot | Note Added: 0177181 | |
| 2025-03-24 14:58 | hgbot | Note Added: 0177182 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |