Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0057781 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Discounts and Promotions | major | always | 2025-01-28 13:35 | 2025-03-04 08:53 | |||
Reporter | sofidossant | View Status | public | |||||
Assigned To | sreehari | |||||||
Priority | high | Resolution | fixed | Fixed in Version | RR25Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | RR24Q4 | SCM revision | ||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0057781: Error with positive discount | |||||||
Description | We have a problem when placing a specific order in which when we apply a discount of type “Variable Discount per Total Amount”, it generates a positive discount in a line of the order. This line generates error with the RTPrinter, since the fiscalization does not accept positive discounts. | |||||||
Steps To Reproduce | 1- Configurate a discount type “Variable Discount per Total Amount”, for all org, all product, any filter. 2- Open the webpos. 3- Add 21 product without discounts and change the price (I attached the table with the price in the lines) 4- Then add the discount in 9 EUR 5- See the last line with the discount in positive 0.01 EUR | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() | |||||||
![]() |
|
![]() |
|
(0174821) sofidossant (developer) 2025-01-28 13:37 |
Table with price https://docs.google.com/spreadsheets/d/1MgmRcKdjHlufH1LHPCrcpM3p6OkfUm0sug1ekiVWHa4/edit?usp=sharing [^] Video in livebuilds https://drive.google.com/file/d/1sQbtXXAiRCp2goR4UI3Vp_8mG68tgdrT/view?usp=sharing [^] |
(0175054) sreehari (developer) 2025-02-03 12:55 |
Reproduced Video - https://drive.google.com/file/d/1e5dAuc7yfKWoskKIr4bOLyv9v735YCrw/view?usp=sharing [^] |
(0175076) hgbot (developer) 2025-02-04 06:05 |
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/162 [^] |
(0175234) hgbot (developer) 2025-02-06 17:19 |
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/162 [^] |
(0175235) hgbot (developer) 2025-02-06 17:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: c8291ac3d3d063079cf28f30cce9d5f168028c10 Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com> Date: 03-02-2025 17:46:06 URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c8291ac3d3d063079cf28f30cce9d5f168028c10 [^] Fixes ISSUE-57781: Updated ByTotalAmount Discount *now when the line discount is more than the expected discount, it will be reset to remaining amount available to be discounted for the line *and so avoiding +ve discounts on the line --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-amount-discount.js --- |
(0176022) sofidossant (developer) 2025-02-21 15:44 |
With the new change, there are discount lines at 0, and this generates an error in the RTPRINTER. There do not have to be lines in 0 or positive discounts. |
(0176182) hgbot (developer) 2025-02-27 06:01 |
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/170 [^] |
(0176388) hgbot (developer) 2025-03-04 08:53 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 4333a87c462c0da84b5c8b1cd285a61a0057c1a9 Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com> Date: 26-02-2025 16:57:02 URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4333a87c462c0da84b5c8b1cd285a61a0057c1a9 [^] Fixes ISSUE-57781: Added case to avoid promotion object when discount is 0 --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/by-total-amount-discount.js --- |
(0176389) hgbot (developer) 2025-03-04 08:53 |
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/170 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2025-01-28 13:35 | sofidossant | New Issue | |
2025-01-28 13:35 | sofidossant | Assigned To | => Retail |
2025-01-28 13:35 | sofidossant | Triggers an Emergency Pack | => No |
2025-01-28 13:35 | sofidossant | File Added: Captura de pantalla -2025-01-28 09-19-36.png | |
2025-01-28 13:37 | sofidossant | Note Added: 0174821 | |
2025-01-28 13:37 | sofidossant | File Added: JSONERROR01.json | |
2025-01-28 14:22 | sreehari | Assigned To | Retail => sreehari |
2025-01-28 14:22 | sreehari | Status | new => scheduled |
2025-02-03 12:55 | sreehari | Note Added: 0175054 | |
2025-02-04 06:05 | hgbot | Note Added: 0175076 | |
2025-02-06 17:19 | hgbot | Resolution | open => fixed |
2025-02-06 17:19 | hgbot | Status | scheduled => closed |
2025-02-06 17:19 | hgbot | Note Added: 0175234 | |
2025-02-06 17:19 | hgbot | Fixed in Version | => RR25Q2 |
2025-02-06 17:19 | hgbot | Note Added: 0175235 | |
2025-02-21 15:43 | sofidossant | Status | closed => new |
2025-02-21 15:44 | sofidossant | Note Added: 0176022 | |
2025-02-26 12:08 | sreehari | Status | new => scheduled |
2025-02-27 06:01 | hgbot | Note Added: 0176182 | |
2025-03-04 08:53 | hgbot | Status | scheduled => closed |
2025-03-04 08:53 | hgbot | Note Added: 0176388 | |
2025-03-04 08:53 | hgbot | Note Added: 0176389 |
Copyright © 2000 - 2009 MantisBT Group |