Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0057568
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Fashionminoralways2025-01-06 11:332025-01-20 16:53
Reporterphilippe_muiView Statuspublic 
Assigned ToBimla_vm 
PriorityhighResolutionopenFixed in Version
StatusscheduledFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057568: RM-20135 [COUPONS] - Coupon imported by csv is not active on the WebPos

DescriptionWhen using Business API data load to generate Coupon codes for a discount and promotion, the coupon is Active = Y but it is not usable on the POS.
However when we deactivate and save then activate and save again, the coupon is usable. It should be usable right after being generated.

See video : https://drive.google.com/file/d/17IXrP9NYiTMLTQJJIYWsVSFASeYcjJFe/view?usp=sharing [^]

https://openbravo.atlassian.net/browse/RM-20135 [^]

In attachment, the CSV file used.
Steps To Reproduce- Create a promotion with uses coupon codes = Y
- Import a csv file of coupons in a promotion on the back office via Business API Data load
- Connect to the back office and verify the result of the import :
the coupon is present in the tab ‘Coupon’ of the promotion
the field ‘Active’ of the coupon is ticked => the coupon must be active on the webpos
- Connect to the web pos and do a ‘refresh masterdata’
- Add a produit on the webpos
- Apply the coupon on the webpos (3 dots/Coupons/Redeem coupon/Coupon code)
A popup displayed ‘Invalid coupon’ (see video joined) = KO

Go back to BO to edit the coupon
Untick the field ‘Active’ of the coupon and save the coupon
Tick the field ‘Active’ of the coupon and save the coupon
In POS, refresh masterdata and use the coupon = OK

=> The coupon should be activated and should be able to be used on the webpos directly after being generated.
TagsFASH
Attached Filescsv file icon Fichier_FR_Import_FURSAC_EUR_FR.csv [^] (291 bytes) 2025-01-06 11:33
diff file icon candidate57568.diff [^] (1,221 bytes) 2025-01-08 07:55 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0173888)
guillermogil (developer)
2025-01-08 08:02

See candidate patch as a proposed solution
(0173900)
guilleaer (manager)
2025-01-08 09:57

The issue here is related to the fact of having the crmExternalReference with blank values. When they are created in this way at first they are saved as blank values when all the code expect a null. Activating and deactivating the values changes that empty into null and that’s why they start working.

A workaround for now is just removing that column from the CSV and it will work in the way it is supposed to.

The issue has been assigned to the proper team with a proposed solution.
(0174359)
hgbot (developer)
2025-01-20 09:30

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/77 [^]
(0174375)
hgbot (developer)
2025-01-20 11:17

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: ff8eebe1307086f3d480d19a986bed8b07fd189b
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 20-01-2025 08:30:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/ff8eebe1307086f3d480d19a986bed8b07fd189b [^]

Fixed ISSUE-57568: Modified criteria restriction for crmReference while coupon redeem

---
M src/org/openbravo/retail/discounts/coupons/DISCPUtils.java
---
(0174376)
hgbot (developer)
2025-01-20 11:17

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/77 [^]
(0174423)
hgbot (developer)
2025-01-20 16:52

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 5fbadb45e05fac97fbf12c4efb08a3fecaf0f255
Author: Guillermo Alvarez de Eulate <g.alvarez@orisha.com>
Date: 20-01-2025 15:52:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/5fbadb45e05fac97fbf12c4efb08a3fecaf0f255 [^]

Revert "Fixed ISSUE-57568: Modified criteria restriction for crmReference while coupon redeem"

This reverts merge request !77
---
M src/org/openbravo/retail/discounts/coupons/DISCPUtils.java
---

- Issue History
Date Modified Username Field Change
2025-01-06 11:33 philippe_mui New Issue
2025-01-06 11:33 philippe_mui Assigned To => Retail
2025-01-06 11:33 philippe_mui File Added: Fichier_FR_Import_FURSAC_EUR_FR.csv
2025-01-06 11:33 philippe_mui Triggers an Emergency Pack => No
2025-01-06 11:33 philippe_mui Tag Attached: FASH
2025-01-08 07:55 jorgewederago File Added: candidate57568.diff
2025-01-08 07:57 jorgewederago Assigned To Retail => guilleaer
2025-01-08 07:57 jorgewederago Status new => acknowledged
2025-01-08 08:02 guillermogil Note Added: 0173888
2025-01-08 09:57 guilleaer Note Added: 0173900
2025-01-08 10:10 Bimla_vm Assigned To guilleaer => Bimla_vm
2025-01-08 10:10 Bimla_vm Status acknowledged => scheduled
2025-01-08 12:03 guillermogil Severity major => minor
2025-01-20 09:30 hgbot Note Added: 0174359
2025-01-20 11:17 hgbot Resolution open => fixed
2025-01-20 11:17 hgbot Status scheduled => closed
2025-01-20 11:17 hgbot Note Added: 0174375
2025-01-20 11:17 hgbot Note Added: 0174376
2025-01-20 16:52 hgbot Note Added: 0174423
2025-01-20 16:53 guilleaer Status closed => new
2025-01-20 16:53 guilleaer Resolution fixed => open
2025-01-20 16:53 guilleaer Status new => scheduled


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker