Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0057546
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajorhave not tried2024-12-31 12:452025-01-03 13:26
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in Version25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057546: Missing checks in configurable toolbar tables

DescriptionThere are several missing checks in configurable toolbar tables:
- Incorrect check in OBC2_ACTIONGROUP for column HIDEIFNOTACCESSIBLETOROLE (should check that column instead of isActive)
- Missing AD_MODULE_ID check in development for OBC2_ACTIONGROUP and OBC2_TOOLBAR tables.

Other required changes:
- Usage of count instead of list with limit 1(might be heavy on performance) in OBC2ToolbarConfigurationEventHandler
- Incorrect use of OBContext.setAdminMode in OBC2ToolbarConfigurationEventHandler and ConfigurableToolbarUtils
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0056966 closedcberner Metadatical definition of toolbars as source data 

-  Notes
(0173768)
hgbot (developer)
2024-12-31 14:39

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1707 [^]
(0173826)
hgbot (developer)
2025-01-03 13:26

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1c861763215e47746127e722f86d6ee488e0dfdb
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 03-01-2025 12:26:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1c861763215e47746127e722f86d6ee488e0dfdb [^]

Fixes ISSUE-57546: Missing checks in configurable toolbar tables

These fixes have been applied:
- Added proper check for the HIDEIFNOTACCESSIBLETOROLE column in
OBC2_ACTIONGROUP table
- Added triggers for OBC2_ACTIONGROUP and OBC2_TOOLBAR AD_MODULE_ID
columns, to make sure the module is set as in development when doing
changes.
- Changed count to a list with maxResults 1 in
OBC2ToolbarConfigurationEventHandler file
- Changed usages of OBContext.setAdminMode to have the proper boolean
variable set.

---
A src-db/database/model/triggers/OBC2_ACTIONGROUP_MOD_TRG.xml
A src-db/database/model/triggers/OBC2_TOOLBAR_MOD_TRG.xml
M src-db/database/model/tables/OBC2_ACTIONGROUP.xml
M src/org/openbravo/core2/event/OBC2ToolbarConfigurationEventHandler.java
M src/org/openbravo/core2/utility/ConfigurableToolbarUtils.java
---
(0173827)
hgbot (developer)
2025-01-03 13:26

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1707 [^]

- Issue History
Date Modified Username Field Change
2024-12-31 12:45 cberner New Issue
2024-12-31 12:45 cberner Assigned To => Triage Platform Base
2024-12-31 12:45 cberner Triggers an Emergency Pack => No
2024-12-31 12:46 cberner Assigned To Triage Platform Base => cberner
2024-12-31 12:46 cberner Status new => acknowledged
2024-12-31 12:47 cberner Relationship added caused by 0056966
2024-12-31 14:39 hgbot Note Added: 0173768
2025-01-03 13:26 hgbot Resolution open => fixed
2025-01-03 13:26 hgbot Status acknowledged => closed
2025-01-03 13:26 hgbot Fixed in Version => 25Q1
2025-01-03 13:26 hgbot Note Added: 0173826
2025-01-03 13:26 hgbot Note Added: 0173827

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker