Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057211 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Retail Configuration | major | have not tried | 2024-11-20 16:18 | 2024-11-22 17:25 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR25Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057211: Retail Config: Move buildvalidation + 1 modulescript which depend on posterminal module into posterminal module | |||||||
| Description | Retail config module does not depend on posterminal. But 2 items inside it: - buildvalidation RemoteProductPreferenceCheck - modulescript InitializeExtendedProductList depend on posterminal by using the OBPOS_remote.product preference from posterminal. To fix the undeclared dependency and as prep work for moving retail.config into backoffice move those 2 elements from org.openbravo.retail.config into org.openbravo.retail.posterminal module. | |||||||
| Steps To Reproduce | Check xsql files of those 2 scripts and find OBPOS_remote.product preference used in both OBPOS dbprefix means it is a preference only added by posterminal module check retail.config list of dependencies to not have posterminal module in it. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0172362) hgbot (developer) 2024-11-20 16:40 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1797 [^] |
|
(0172363) hgbot (developer) 2024-11-20 16:44 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/33 [^] |
|
(0172491) hgbot (developer) 2024-11-22 17:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1797 [^] |
|
(0172492) hgbot (developer) 2024-11-22 17:25 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 68d791f4d2a60708de102600c37aa928255b0d47 Author: Stefan Huehner <s.huehner@orisha.com> Date: 22-11-2024 17:23:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/68d791f4d2a60708de102600c37aa928255b0d47 [^] ISSUE-57211: Add buildvalidation RemoteProductPreferenceCheck to posterminal Part of moving this buildvalidation from org.openbravo.retail.config to org.openbravo.retail.posterminal module (as it depends on OBPOS_remote.product preference from posterminal already) Apart from moving the file adjust: - javapackage - ModuleExecution Limit - Change module_id to check version against to one from posterminal - and rename variable - Change version limit from 1.0.241900 to 1.2.241900 As posterminal uses 1.2 major version while having minor versions the same (as both are centrally published by RM team) --- A build/classes/org/openbravo/retail/posterminal/buildvalidation/RemoteProductPreferenceCheck.class A src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/RemoteProductPreferenceCheck.java --- |
|
(0172493) hgbot (developer) 2024-11-22 17:25 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: fc64a94efb3fd023159fb74204188bc5bef9e0b0 Author: Stefan Huehner <s.huehner@orisha.com> Date: 22-11-2024 17:23:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/fc64a94efb3fd023159fb74204188bc5bef9e0b0 [^] ISSUE-57211: Add modulescript InitializeExtendedProductList to posterminal Part of moving this modulescript from org.openbravo.retail.config to org.openbravo.retail.posterminal module (as it depends on OBPOS_remote.product preference from posterminal already) Apart from moving the file adjust: - javapackage - ModuleExecution Limit - Change module_id to check version against to one from posterminal - and rename variable - Change version limit from 1.0.241900 to 1.2.241900 As posterminal uses 1.2 major version while having minor versions the same (as both are centrally published by RM team) --- A build/classes/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList.class A build/classes/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductListData.class A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList.java A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList_Data.xsql --- |
|
(0172494) hgbot (developer) 2024-11-22 17:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/33 [^] |
|
(0172495) hgbot (developer) 2024-11-22 17:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^] Changeset: df57951556694e9e3e1693c04295f0999108d4dd Author: Stefan Huehner <s.huehner@orisha.com> Date: 22-11-2024 17:23:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/df57951556694e9e3e1693c04295f0999108d4dd [^] Fixes ISSUE-57211: Remove RemoteProductPreferenceCheck & InitializeExtendedProductList Part of moving this buildvalidation and modulescript from org.openbravo.retail.config to org.openbravo.retail.posterminal module (as it depends on OBPOS_remote.product preference from posterminal already) Remove both from this module. --- R build/classes/org/openbravo/retail/config/buildvalidation/RemoteProductPreferenceCheck.class R build/classes/org/openbravo/retail/config/modulescript/InitializeExtendedProductList.class R build/classes/org/openbravo/retail/config/modulescript/InitializeExtendedProductListData.class R src-util/buildvalidation/src/org/openbravo/retail/config/buildvalidation/RemoteProductPreferenceCheck.java R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeExtendedProductList.java R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeExtendedProductList_Data.xsql --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-11-20 16:18 | shuehner | New Issue | |
| 2024-11-20 16:18 | shuehner | Assigned To | => Retail |
| 2024-11-20 16:18 | shuehner | Triggers an Emergency Pack | => No |
| 2024-11-20 16:18 | shuehner | Relationship added | blocks 0057210 |
| 2024-11-20 16:40 | hgbot | Note Added: 0172362 | |
| 2024-11-20 16:44 | hgbot | Note Added: 0172363 | |
| 2024-11-20 17:40 | shuehner | Assigned To | Retail => shuehner |
| 2024-11-22 17:25 | hgbot | Note Added: 0172491 | |
| 2024-11-22 17:25 | hgbot | Note Added: 0172492 | |
| 2024-11-22 17:25 | hgbot | Note Added: 0172493 | |
| 2024-11-22 17:25 | hgbot | Resolution | open => fixed |
| 2024-11-22 17:25 | hgbot | Status | new => closed |
| 2024-11-22 17:25 | hgbot | Note Added: 0172494 | |
| 2024-11-22 17:25 | hgbot | Fixed in Version | => RR25Q1 |
| 2024-11-22 17:25 | hgbot | Note Added: 0172495 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |