Openbravo Issue Tracking System - Retail Modules
View Issue Details
0057211Retail ModulesRetail Configurationpublic2024-11-20 16:182024-11-22 17:25
shuehner 
shuehner 
normalmajorhave not tried
closedfixed 
5
 
RR25Q1 
No
0057211: Retail Config: Move buildvalidation + 1 modulescript which depend on posterminal module into posterminal module
Retail config module does not depend on posterminal.
But 2 items inside it:
- buildvalidation RemoteProductPreferenceCheck
- modulescript InitializeExtendedProductList
depend on posterminal by using the OBPOS_remote.product preference from posterminal.

To fix the undeclared dependency and as prep work for moving retail.config into backoffice move those 2 elements from org.openbravo.retail.config into org.openbravo.retail.posterminal module.
Check xsql files of those 2 scripts and find OBPOS_remote.product preference used in both
OBPOS dbprefix means it is a preference only added by posterminal module
check retail.config list of dependencies to not have posterminal module in it.
No tags attached.
blocks feature request 0057210 new Triage Platform Base Openbravo ERP Move content of org.openbravo.retail.config module to backoffice/core repo 
Issue History
2024-11-20 16:18shuehnerNew Issue
2024-11-20 16:18shuehnerAssigned To => Retail
2024-11-20 16:18shuehnerTriggers an Emergency Pack => No
2024-11-20 16:18shuehnerRelationship addedblocks 0057210
2024-11-20 16:40hgbotNote Added: 0172362
2024-11-20 16:44hgbotNote Added: 0172363
2024-11-20 17:40shuehnerAssigned ToRetail => shuehner
2024-11-22 17:25hgbotNote Added: 0172491
2024-11-22 17:25hgbotNote Added: 0172492
2024-11-22 17:25hgbotNote Added: 0172493
2024-11-22 17:25hgbotResolutionopen => fixed
2024-11-22 17:25hgbotStatusnew => closed
2024-11-22 17:25hgbotNote Added: 0172494
2024-11-22 17:25hgbotFixed in Version => RR25Q1
2024-11-22 17:25hgbotNote Added: 0172495

Notes
(0172362)
hgbot   
2024-11-20 16:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1797 [^]
(0172363)
hgbot   
2024-11-20 16:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/33 [^]
(0172491)
hgbot   
2024-11-22 17:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1797 [^]
(0172492)
hgbot   
2024-11-22 17:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 68d791f4d2a60708de102600c37aa928255b0d47
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 22-11-2024 17:23:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/68d791f4d2a60708de102600c37aa928255b0d47 [^]

ISSUE-57211: Add buildvalidation RemoteProductPreferenceCheck to posterminal

Part of moving this buildvalidation from org.openbravo.retail.config to
org.openbravo.retail.posterminal module (as it depends on
OBPOS_remote.product preference from posterminal already)

Apart from moving the file adjust:
- javapackage
- ModuleExecution Limit
  - Change module_id to check version against to one from posterminal
    - and rename variable
  - Change version limit from 1.0.241900 to 1.2.241900
    As posterminal uses 1.2 major version while having minor versions
    the same (as both are centrally published by RM team)

---
A build/classes/org/openbravo/retail/posterminal/buildvalidation/RemoteProductPreferenceCheck.class
A src-util/buildvalidation/src/org/openbravo/retail/posterminal/buildvalidation/RemoteProductPreferenceCheck.java
---
(0172493)
hgbot   
2024-11-22 17:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: fc64a94efb3fd023159fb74204188bc5bef9e0b0
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 22-11-2024 17:23:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/fc64a94efb3fd023159fb74204188bc5bef9e0b0 [^]

ISSUE-57211: Add modulescript InitializeExtendedProductList to posterminal

Part of moving this modulescript from org.openbravo.retail.config to
org.openbravo.retail.posterminal module (as it depends on
OBPOS_remote.product preference from posterminal already)

Apart from moving the file adjust:
- javapackage
- ModuleExecution Limit
  - Change module_id to check version against to one from posterminal
    - and rename variable
  - Change version limit from 1.0.241900 to 1.2.241900
    As posterminal uses 1.2 major version while having minor versions
    the same (as both are centrally published by RM team)

---
A build/classes/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList.class
A build/classes/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductListData.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InitializeExtendedProductList_Data.xsql
---
(0172494)
hgbot   
2024-11-22 17:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/33 [^]
(0172495)
hgbot   
2024-11-22 17:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^]
Changeset: df57951556694e9e3e1693c04295f0999108d4dd
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 22-11-2024 17:23:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/df57951556694e9e3e1693c04295f0999108d4dd [^]

Fixes ISSUE-57211: Remove RemoteProductPreferenceCheck & InitializeExtendedProductList

Part of moving this buildvalidation and modulescript from org.openbravo.retail.config to
org.openbravo.retail.posterminal module (as it depends on
OBPOS_remote.product preference from posterminal already)

Remove both from this module.

---
R build/classes/org/openbravo/retail/config/buildvalidation/RemoteProductPreferenceCheck.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeExtendedProductList.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeExtendedProductListData.class
R src-util/buildvalidation/src/org/openbravo/retail/config/buildvalidation/RemoteProductPreferenceCheck.java
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeExtendedProductList.java
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeExtendedProductList_Data.xsql
---