0056852: Request approval dialog does not show username + password

Description

When in a user-action there are two prehooks, one does show an inputDataDialog, through requestData API, and afterwards, another calls a method that does user action approval, the approval does not show the "username + password" part, it instead shows what was previously shown in the requestData call.

This seems to work fine, if we stop for some seconds between the requestData finishes and the call for approval is done.

Steps To Reproduce

1. Login into POS2 as vallblanca
2. Run the following in Developer Tools - Console:

setTimeout(() => OB.App.View.DialogUIHandler.inputData('OBDISCP_COUPON'), 5000);
await OB.App.View.DialogUIHandler.inputData(
        'OBDISCP_CouponDialog',
        {
          title: '$OBDISCP_RedeemCoupon',
          subTitle: '$OBDISCP_EnterCouponCode',
          variantClass: 'obdiscpCouponDialog',
          properties: {
            fields: [
              {
                name: 'code',
                iconClass: 'obdiscpIconCoupon',
                label: 'Coupon Code',
                variantClass: 'obdiscpCouponDialog-input'
              }
            ]
          },
          hideOk: true,
          extraButtons: [
            {
              name: 'OBDISCP_Redeem',
              label: '$OBDISCP_Redeem',
              icon: 'obc2IconPlus',
              variantClass: 'obdiscpConfirmButton'
            }
          ]
        }
      );

Proposed Solution

Properly clear whatever is in the content of the corresponding BaseDialog, before showing another dialog.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0056736

scheduled

guilleaer

Incorrect Approval Dialog Display for Coupons with Extra Validity Days if triggered though Coupons options

Notes
(0172190) guilleaer (manager) 2024-11-18 17:36	Moved to major because approvals cannot be completed blocking the flow

Issue History
Date Modified	Username	Field	Change
2024-10-21 16:37	cberner	New Issue
2024-10-21 16:37	cberner	Assigned To	=> Triage Platform Base
2024-10-21 16:37	cberner	Triggers an Emergency Pack	=> No
2024-10-21 16:40	guilleaer	Relationship added	blocks 0056736
2024-11-18 17:35	guilleaer	Severity	minor => major
2024-11-18 17:36	guilleaer	Note Added: 0172190