0056852: Request approval dialog does not show username + password

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0056852

POS2

Core

public

2024-10-21 16:37

2024-12-13 09:30

Reporter

cberner

Assigned To

Triage Platform Base

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

25Q1

Merge Request Status

Review Assigned To

cberner

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0056852: Request approval dialog does not show username + password

Description

When in a user-action there are two prehooks, one does show an inputDataDialog, through requestData API, and afterwards, another calls a method that does user action approval, the approval does not show the "username + password" part, it instead shows what was previously shown in the requestData call.

This seems to work fine, if we stop for some seconds between the requestData finishes and the call for approval is done.

Steps To Reproduce

1. Login into POS2 as vallblanca
2. Run the following in Developer Tools - Console:

setTimeout(() => OB.App.View.DialogUIHandler.inputData('OBDISCP_COUPON'), 5000);
await OB.App.View.DialogUIHandler.inputData(
        'OBDISCP_CouponDialog',
        {
          title: '$OBDISCP_RedeemCoupon',
          subTitle: '$OBDISCP_EnterCouponCode',
          variantClass: 'obdiscpCouponDialog',
          properties: {
            fields: [
              {
                name: 'code',
                iconClass: 'obdiscpIconCoupon',
                label: 'Coupon Code',
                variantClass: 'obdiscpCouponDialog-input'
              }
            ]
          },
          hideOk: true,
          extraButtons: [
            {
              name: 'OBDISCP_Redeem',
              label: '$OBDISCP_Redeem',
              icon: 'obc2IconPlus',
              variantClass: 'obdiscpConfirmButton'
            }
          ]
        }
      );

Proposed Solution

Properly clear whatever is in the content of the corresponding BaseDialog, before showing another dialog.

Additional Information

Tags

No tags attached.

Relationships

duplicate of	design defect	0057022		closed	njimenez	Input dialog global component does not support showing twice at the same time
blocks	defect	0056736		closed	guilleaer	Incorrect Approval Dialog Display for Coupons with Extra Validity Days if triggered though Coupons options