0056721: Send Mail creating error while importing

Description

If a customer without contact is selected, while trying to send the ticket by email, an EWI is created:

org.openbravo.base.exception.OBException: Business partner user ID is a mandatory field to create a new customer from Web Pos
    at org.openbravo.retail.posterminal.CustomerLoader.editBPartnerContact(CustomerLoader.java:262)
    at org.openbravo.retail.posterminal.CustomerLoader.saveRecord(CustomerLoader.java:107)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)

Steps To Reproduce

In livebuilds:

In the backoffice
- Configure the VBS-2 terminal to show the send by mail popup after the sales done.

In the POS
- Log in the VBS-2
- Select the TestBP business partner
- Do a sale
- In the popup, fulfill it with an email and save it

Go to the Backoffice and check that an Error while importing has been created

Proposed Solution

Remove the exception and generate here an UUID

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/e64759b2bce77985e2f062f0a5287ac0d13949fe/src/org/openbravo/retail/posterminal/CustomerLoader.java#L261 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0056709

closed

Bimla_vm

Send Mail creating error while importing

Notes
(0170359) hgbot (developer) 2024-10-14 13:45	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1717 [^]

(0170403) hgbot (developer) 2024-10-15 08:31	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1717 [^]

(0170404) hgbot (developer) 2024-10-15 08:31	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: dbb0ffe961dfaa169f2ce1409bc2d2eaa8cd7989 Author: Bimla Mayavan <b.mayavan@external.orisha.com> Date: 10-10-2024 18:26:13 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dbb0ffe961dfaa169f2ce1409bc2d2eaa8cd7989 [^] Fixed ISSUE-56721: Removed the exception and generated UUID for user --- M src/org/openbravo/retail/posterminal/CustomerLoader.java ---

Issue History
Date Modified	Username	Field	Change
2024-10-10 10:07	marvintm	Type	defect => backport
2024-10-10 10:07	marvintm	Target Version	24Q4 => 24Q3.2
2024-10-14 13:45	hgbot	Note Added: 0170359
2024-10-15 08:31	hgbot	Merge Request Status	open => approved
2024-10-15 08:31	hgbot	Note Added: 0170403
2024-10-15 08:31	hgbot	Resolution	open => fixed
2024-10-15 08:31	hgbot	Status	scheduled => closed
2024-10-15 08:31	hgbot	Fixed in Version	=> RR24Q3.2
2024-10-15 08:31	hgbot	Note Added: 0170404